Re: [PATCH] wifi: brcmfmac: cfg80211: Use WSEC to set SAE password

[Arend Van Spriel <arend.vanspriel@broadcom.com>]

[-- Attachment #1: Type: text/plain, Size: 1467 bytes --]

On December 17, 2023 12:25:23 PM Kalle Valo <kvalo@kernel.org> wrote:

> Hector Martin <marcan@marcan.st> wrote:
>
>> Using the WSEC command instead of sae_password seems to be the supported
>> mechanism on newer firmware, and also how the brcmdhd driver does it.
>>
>> According to user reports [1], the sae_password codepath doesn't actually
>> work on machines with Cypress chips anyway, so no harm in removing it.
>>
>> This makes WPA3 work with iwd, or with wpa_supplicant pending a support
>> patchset [2].
>>
>> [1] https://rachelbythebay.com/w/2023/11/06/wpa3/
>> [2] http://lists.infradead.org/pipermail/hostap/2023-July/041653.html
>>
>> Signed-off-by: Hector Martin <marcan@marcan.st>
>> Reviewed-by: Neal Gompa <neal@gompa.dev>
>
> Arend, what do you think?
>
> We recently talked about people testing brcmfmac patches, has anyone else
> tested this?

Not sure I already replied so maybe I am repeating myself. I would prefer 
to keep the Cypress sae_password path as well although it reportedly does 
not work. The vendor support in the driver can be used to accommodate for 
that. The other option would be to have people with Cypress chipset test 
this patch. If that works for both we can consider dropping the 
sae_password path.

Regards,
Arend

> --
> https://patchwork.kernel.org/project/linux-wireless/patch/20231107-brcmfmac-wpa3-v1-1-4c7db8636680@marcan.st/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches




[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]