From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tanmay Shah <tanmay.shah@amd.com>,
andersson@kernel.org, mathieu.poirier@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, michal.simek@amd.com, ben.levinsky@amd.com
Cc: linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Subject: Re: [PATCH v12 2/4] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings
Date: Tue, 12 Mar 2024 13:10:02 +0100 [thread overview]
Message-ID: <18d34385-fd0b-401c-9ca4-ccf22106bd68@linaro.org> (raw)
In-Reply-To: <2c45d7fb-06e4-468d-9415-0eaa48c5250b@amd.com>
On 11/03/2024 17:27, Tanmay Shah wrote:
>>> + then:
>>> + patternProperties:
>>> + "^r5f@[0-9a-f]+$":
>>> + type: object
>>> +
>>> + properties:
>>> + reg:
>>> + minItems: 1
>>> + items:
>>> + - description: ATCM internal memory
>>> + - description: BTCM internal memory
>>> + - description: extra ATCM memory in lockstep mode
>>> + - description: extra BTCM memory in lockstep mode
>>> +
>>> + reg-names:
>>> + minItems: 1
>>> + items:
>>> + - const: atcm0
>>> + - const: btcm0
>>> + - const: atcm1
>>> + - const: btcm1
>>
>> Why power domains are flexible?
>
> User may not want to use all the TCMs. For example, if users want to turn-on only TCM-A and rest of them want to keep off, then
>
> they can avoid having power-domains of other TCMs in the device-tree. This helps with less power-consumption when needed.
>
> Hence flexible list of power-domains list.
>
Isn't turning on/off driver's job? Sorry, but what is "user" here? DTS
describes bindings, not OS policy.
Also, please wrap your replies to match email style.
> I can certainly mention "items:" under power-domains property.
>
>
>>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-12 12:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 18:16 [PATCH v12 0/4] add zynqmp TCM bindings Tanmay Shah
2024-03-01 18:16 ` [PATCH v12 1/4] remoteproc: zynqmp: fix lockstep mode memory region Tanmay Shah
2024-03-01 18:16 ` [PATCH v12 2/4] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings Tanmay Shah
2024-03-09 13:25 ` Krzysztof Kozlowski
2024-03-11 16:27 ` Tanmay Shah
2024-03-12 12:10 ` Krzysztof Kozlowski [this message]
2024-03-12 15:49 ` Tanmay Shah
2024-03-11 18:39 ` Tanmay Shah
2024-03-12 12:10 ` Krzysztof Kozlowski
2024-03-12 15:33 ` Tanmay Shah
2024-03-01 18:16 ` [PATCH v12 3/4] dts: zynqmp: add properties for TCM in remoteproc Tanmay Shah
2024-03-01 18:16 ` [PATCH v12 4/4] remoteproc: zynqmp: parse TCM from device tree Tanmay Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18d34385-fd0b-401c-9ca4-ccf22106bd68@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=ben.levinsky@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=michal.simek@amd.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=robh+dt@kernel.org \
--cc=tanmay.shah@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®