From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f42.google.com (mail-dl1-f42.google.com [74.125.82.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8199E36EA86 for ; Wed, 1 Apr 2026 07:53:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775029986; cv=none; b=itRWx40LH6ZUFmfV6CRDBj4cGVaEGgOhzmf39kyK0aAz/xLpoLJKCvSQ4JXHXNSpPljDqUX4rLHuqC1jMB5RVLeY4OIDZChUA0cF5x5n8XclmZ0yaSP1QxsQSHnkutR8S0SjHyT/dLojdNmQ+ttK94/EDxkKh6OqmQ4VR539goM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775029986; c=relaxed/simple; bh=zOZC2aKClSnAidR0vLOY85xgZZqHZ5x5vrQqdnyVDhI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BUycoedfRkFyxyoOVV0xLMUxhzVNLNr7aPmSazdJGtd4RgBi/cisr8OXBdxeZWQ5OQu0GjZRiSByFn+rc3m7iXpAoUjusu65ytIGCOCD3FYipejqw+N+/CM/ESRr8uG75oZNYPI3E5GDb50dyDo+XgTNzr3NSBYOTXajOJalufg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lbA51mQJ; arc=none smtp.client-ip=74.125.82.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lbA51mQJ" Received: by mail-dl1-f42.google.com with SMTP id a92af1059eb24-126ea4b77adso9399517c88.1 for ; Wed, 01 Apr 2026 00:53:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775029983; x=1775634783; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gn7BFBkoPg/Mi40J2CvkBtL8T6I0G+ldprB7tkZkwBc=; b=lbA51mQJreoSSy6Zfm6ppyHazRemK9OOQ3Fx3MsQcU/h+bsd0C0/tnQKjG8ccLAfII mzDtVpCM9T1mhg5tEdeCuFqBK1hb55wJnPntJdBjSErneivH3bNTXjC7IeNTLEa8/a6T qDy1SwDfbLPkqUp3Sh/2ksJVlmfErlvnhvUijKMQ8V8iFmpcee09mU9DkeCjMjNhitVz rEN2ZcoXyt8GjYLQ3b/EE/ApjAG4xuhbbZPOWYXUo5c1qd4oEI9lyNbi/pZQILrGDeGX yqvuv3u28ITfjUrejXUhmHcWjtPDV9had3zaosZ3kJR23Jix7T1WR6bshnY4wy3oHswP 2WFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775029983; x=1775634783; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gn7BFBkoPg/Mi40J2CvkBtL8T6I0G+ldprB7tkZkwBc=; b=d5EzABEdowuGTCQFPPcR/qRaqlNwngamGqGOG9uFe2NKRMecrv/yNNKGf/DlrNqK5e BvhG1EoQDVJrsh/VjWWItb9ayFFQhUkMZpKXFYADhEKfYwGY81khvzjDsorrsPj43GTo s/4heW20ueOJg0VdJKmN7fRUPZ9sebmWCtSwMZRVNBT+mHlUP5zU9ajXvStIi6GeDnbv DO6z34A0d3tcEhMa7Cmm8a+BnvrVDbHahOfSqD1ZkjpRbNXZsQZFN2v8uy+Zi25wV7w8 rsVGugKB1Ui/pZVpGW/maEZgS5Sd2hnB5GmWdBmL7b6mZ/EZu+LeD2acXJ+NW7FCD9NN iXLQ== X-Gm-Message-State: AOJu0Ywz/FfUah/Ivmfo9/9n9fe/NHURG8zYwiJndgQHhvmkv/sYhci0 wXFoKt0yCYNUHqEFuofdFObrvFXXzYPhylYQYSxkJxkmg/3picNrfKvv X-Gm-Gg: ATEYQzzA1wO1Y/6QI/HWohl0elkHJ1AVuaqnOKLNwLEn4bUDvOzYvJ+LQ8f56xNEano mWjmr/yRlMDQiv8KqtHz6gWk8vBOcL04efBn0I2bcucc+z3765RD0kH0o62e5nso67RDQZP7Ogk KR2bvWzcF2GVJIDMEBgqLZqrws61rAdr7jMnp4KiVMpImDfYVMQtohWEQFP/HQjqCdnxTNE1ki5 rJ4gs+I9yQGHYePgl8Rv4GamRrMiH9Tz2ZPFPH8LrX94iQYR+4aJlbP3AYEKxJi2LZ9MeIoDuxO OrlvgfGD/1y6jt5umq0+E4G2IDBG8hSu178IWduX+mf3C4qouGkVw5mADSkw8y8YAYFLuIgt/9S 5A35APkUI5M3Y3HGsm0CIP0BtJxolpKQmMMVV2DmwrIs0RA6iZc52opIcxqCycUTUUVtih9jO+C +o+jBgwtLR02rvcww9/ECJf9wsKx+oXQoPHm95y/VTzoJedwwyf49tC2KXGBEZ10nNd/8KhG8= X-Received: by 2002:a05:7022:b81:b0:127:3f2a:af21 with SMTP id a92af1059eb24-12be647ca0amr1320002c88.15.1775029982608; Wed, 01 Apr 2026 00:53:02 -0700 (PDT) Received: from ?IPV6:2620:10d:c085:21e1::139a? ([2620:10d:c090:400::5:51bb]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12ab983f904sm17793034c88.9.2026.04.01.00.53.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Apr 2026 00:53:01 -0700 (PDT) Message-ID: <18d5a9b7-9c8d-4fc4-9332-fab27449dc58@gmail.com> Date: Wed, 1 Apr 2026 00:53:00 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v03 3/6] hinic3: Add ethtool coalesce ops To: Fan Gong , Zhu Yikai , netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Andrew Lunn , Ioana Ciornei Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, luosifu , Xin Guo , Zhou Shuai , Wu Like , Shi Jing , Zheng Jiezhen , Maxime Chevallier References: Content-Language: en-US From: Mohsin Bashir In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > +static int is_coalesce_exceed_limit(struct net_device *netdev, > + const struct ethtool_coalesce *coal) > +{ > + const struct { > + const char *name; > + u32 value; > + u32 limit; > + } coalesce_limits[] = { > + {"rx_coalesce_usecs", > + coal->rx_coalesce_usecs, > + COALESCE_MAX_TIMER_CFG}, > + {"rx_max_coalesced_frames", > + coal->rx_max_coalesced_frames, > + COALESCE_MAX_PENDING_LIMIT}, > + {"rx_max_coalesced_frames_low", > + coal->rx_max_coalesced_frames_low, > + COALESCE_MAX_PENDING_LIMIT}, > + {"rx_max_coalesced_frames_high", > + coal->rx_max_coalesced_frames_high, > + COALESCE_MAX_PENDING_LIMIT}, > + }; > + > + for (int i = 0; i < ARRAY_SIZE(coalesce_limits); i++) { > + if (coalesce_limits[i].value > coalesce_limits[i].limit) { > + netdev_err(netdev, "%s out of range %d-%d\n", > + coalesce_limits[i].name, 0, > + coalesce_limits[i].limit); > + return -EOPNOTSUPP; Since we are failing a range check, maybe -ERANGE or -EINVAL would be more appropriate here. > + } > + } > + return 0; > +} > + > +static int is_coalesce_legal(struct net_device *netdev, > + const struct ethtool_coalesce *coal) > +{ > + int err; > + > + err = is_coalesce_exceed_limit(netdev, coal); > + if (err) > + return err; > + > + if (coal->rx_max_coalesced_frames_low >= > + coal->rx_max_coalesced_frames_high && > + coal->rx_max_coalesced_frames_high > 0) { So this would allow non-zero low and zero high. For example, low = 10, high = 0. Is this expected? > + netdev_err(netdev, "invalid coalesce frame high %u, low %u, unit %d\n", > + coal->rx_max_coalesced_frames_high, > + coal->rx_max_coalesced_frames_low, > + COALESCE_PENDING_LIMIT_UNIT); > + return -EOPNOTSUPP; > + } > + > + return 0; > +} > + > +static void check_coalesce_align(struct net_device *netdev, > + u32 item, u32 unit, const char *str) > +{ > + if (item % unit) > + netdev_warn(netdev, "%s in %d units, change to %u\n", > + str, unit, item - item % unit); > +} > + > +#define CHECK_COALESCE_ALIGN(member, unit) \ > + check_coalesce_align(netdev, member, unit, #member) > + > +static void check_coalesce_changed(struct net_device *netdev, > + u32 item, u32 unit, u32 ori_val, > + const char *obj_str, const char *str) > +{ > + if ((item / unit) != ori_val) > + netdev_dbg(netdev, "Change %s from %d to %u %s\n", > + str, ori_val * unit, item - item % unit, obj_str); > +} > + > +#define CHECK_COALESCE_CHANGED(member, unit, ori_val, obj_str) \ > + check_coalesce_changed(netdev, member, unit, ori_val, obj_str, #member) > + > +static int hinic3_set_hw_coal_param(struct net_device *netdev, > + struct hinic3_intr_coal_info *intr_coal) > +{ > + struct hinic3_nic_dev *nic_dev = netdev_priv(netdev); > + int err; > + u16 i; > + > + for (i = 0; i < nic_dev->max_qps; i++) { > + err = hinic3_set_queue_coalesce(netdev, i, intr_coal); > + if (err) > + return err; > + } > + > + return 0; > +} > + > +static int hinic3_get_coalesce(struct net_device *netdev, > + struct ethtool_coalesce *coal, > + struct kernel_ethtool_coalesce *kernel_coal, > + struct netlink_ext_ack *extack) > +{ > + struct hinic3_nic_dev *nic_dev = netdev_priv(netdev); > + struct hinic3_intr_coal_info *interrupt_info; > + > + interrupt_info = &nic_dev->intr_coalesce[0]; > + > + /* TX/RX uses the same interrupt. > + * So we only declare RX ethtool_coalesce parameters. > + */ > + coal->rx_coalesce_usecs = interrupt_info->coalesce_timer_cfg * > + COALESCE_TIMER_CFG_UNIT; > + coal->rx_max_coalesced_frames = interrupt_info->pending_limit * > + COALESCE_PENDING_LIMIT_UNIT; > + > + coal->use_adaptive_rx_coalesce = nic_dev->adaptive_rx_coal; > + > + coal->rx_max_coalesced_frames_high = > + interrupt_info->rx_pending_limit_high * > + COALESCE_PENDING_LIMIT_UNIT; > + > + coal->rx_max_coalesced_frames_low = > + interrupt_info->rx_pending_limit_low * > + COALESCE_PENDING_LIMIT_UNIT; > + > + return 0; > +} > + > +static int hinic3_set_coalesce(struct net_device *netdev, > + struct ethtool_coalesce *coal, > + struct kernel_ethtool_coalesce *kernel_coal, > + struct netlink_ext_ack *extack) > +{ > + struct hinic3_nic_dev *nic_dev = netdev_priv(netdev); > + struct hinic3_intr_coal_info *ori_intr_coal; > + struct hinic3_intr_coal_info intr_coal = {}; > + char obj_str[32]; > + int err; > + > + err = is_coalesce_legal(netdev, coal); > + if (err) > + return err; > + > + CHECK_COALESCE_ALIGN(coal->rx_coalesce_usecs, COALESCE_TIMER_CFG_UNIT); > + CHECK_COALESCE_ALIGN(coal->rx_max_coalesced_frames, > + COALESCE_PENDING_LIMIT_UNIT); > + CHECK_COALESCE_ALIGN(coal->rx_max_coalesced_frames_high, > + COALESCE_PENDING_LIMIT_UNIT); > + CHECK_COALESCE_ALIGN(coal->rx_max_coalesced_frames_low, > + COALESCE_PENDING_LIMIT_UNIT); > + > + ori_intr_coal = &nic_dev->intr_coalesce[0]; > + snprintf(obj_str, sizeof(obj_str), "for netdev"); > + > + CHECK_COALESCE_CHANGED(coal->rx_coalesce_usecs, COALESCE_TIMER_CFG_UNIT, > + ori_intr_coal->coalesce_timer_cfg, obj_str); > + CHECK_COALESCE_CHANGED(coal->rx_max_coalesced_frames, > + COALESCE_PENDING_LIMIT_UNIT, > + ori_intr_coal->pending_limit, obj_str); > + CHECK_COALESCE_CHANGED(coal->rx_max_coalesced_frames_high, > + COALESCE_PENDING_LIMIT_UNIT, > + ori_intr_coal->rx_pending_limit_high, obj_str); > + CHECK_COALESCE_CHANGED(coal->rx_max_coalesced_frames_low, > + COALESCE_PENDING_LIMIT_UNIT, > + ori_intr_coal->rx_pending_limit_low, obj_str); > + > + intr_coal.coalesce_timer_cfg = > + (u8)(coal->rx_coalesce_usecs / COALESCE_TIMER_CFG_UNIT); > + intr_coal.pending_limit = (u8)(coal->rx_max_coalesced_frames / > + COALESCE_PENDING_LIMIT_UNIT); > + > + nic_dev->adaptive_rx_coal = coal->use_adaptive_rx_coalesce; > + > + intr_coal.rx_pending_limit_high = > + (u8)(coal->rx_max_coalesced_frames_high / > + COALESCE_PENDING_LIMIT_UNIT); > + > + intr_coal.rx_pending_limit_low = > + (u8)(coal->rx_max_coalesced_frames_low / > + COALESCE_PENDING_LIMIT_UNIT); > + > + /* coalesce timer or pending set to zero will disable coalesce */ > + if (!nic_dev->adaptive_rx_coal && > + (!intr_coal.coalesce_timer_cfg || !intr_coal.pending_limit)) > + netdev_warn(netdev, "Coalesce will be disabled\n"); > + > + return hinic3_set_hw_coal_param(netdev, &intr_coal); > +} > + > static const struct ethtool_ops hinic3_ethtool_ops = { > - .supported_coalesce_params = ETHTOOL_COALESCE_USECS | > - ETHTOOL_COALESCE_PKT_RATE_RX_USECS, > + .supported_coalesce_params = ETHTOOL_COALESCE_RX_USECS | > + ETHTOOL_COALESCE_RX_MAX_FRAMES | > + ETHTOOL_COALESCE_USE_ADAPTIVE_RX | > + ETHTOOL_COALESCE_RX_MAX_FRAMES_LOW | > + ETHTOOL_COALESCE_RX_MAX_FRAMES_HIGH, Looks like ETHTOOL_COALESCE_TX_USECS support got dropped. is it intentional? > .get_link_ksettings = hinic3_get_link_ksettings, > .get_drvinfo = hinic3_get_drvinfo, > .get_msglevel = hinic3_get_msglevel, > @@ -1004,6 +1231,8 @@ static const struct ethtool_ops hinic3_ethtool_ops = { > .get_eth_ctrl_stats = hinic3_get_eth_ctrl_stats, > .get_rmon_stats = hinic3_get_rmon_stats, > .get_pause_stats = hinic3_get_pause_stats, > + .get_coalesce = hinic3_get_coalesce, > + .set_coalesce = hinic3_set_coalesce, > }; > > void hinic3_set_ethtool_ops(struct net_device *netdev)