From: "Julio Auto" <mindvortex@gmail.com>
To: "Solar Designer" <solar@openwall.com>
Cc: "Willy Tarreau" <w@1wt.eu>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] loop.c: kernel_thread() retval check
Date: Sun, 20 Aug 2006 23:47:30 -0300 [thread overview]
Message-ID: <18d709710608201947r59c83c92vfd3f2476b705053b@mail.gmail.com> (raw)
In-Reply-To: <20060821023217.GA23416@openwall.com>
On 8/20/06, Solar Designer <solar@openwall.com> wrote:
> You need to make sure that the cleanup code added with the patch matches
> the loop device initialization preceding the kernel_thread() call. You
> should not blindly take the cleanup code out of the 2.4 patch and apply
> it to 2.6 - it might not be correct for 2.6.
Yes, I already had that in mind, but thanks for the worry, anyway.
> No. But you won't be able to reproduce this with strace on 2.6 since
> 2.6's kernel_thread() uses CLONE_UNTRACED instead of failing on ptrace.
> You'll probably need to temporarily replace the kernel_thread() call in
> loop.c with -EAGAIN to comfortably test your cleanup code without
> forcing the system to run out of resources.
Thanks for the tip. I'll see what I can do. :)
Cheers,
Julio Auto
prev parent reply other threads:[~2006-08-21 2:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-19 23:46 Solar Designer
2006-08-20 7:21 ` Willy Tarreau
2006-08-20 14:32 ` Solar Designer
2006-08-20 18:15 ` Alan Cox
2006-08-20 22:34 ` Solar Designer
2006-08-20 23:11 ` Alan Cox
2006-08-20 22:58 ` Willy Tarreau
2006-08-21 1:59 ` Julio Auto
2006-08-21 2:32 ` Solar Designer
2006-08-21 2:47 ` Julio Auto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18d709710608201947r59c83c92vfd3f2476b705053b@mail.gmail.com \
--to=mindvortex@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=solar@openwall.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®