mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Julio Auto" <mindvortex@gmail.com>
To: "David Wagner" <daw-usenet@taverner.cs.berkeley.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [S390] cio: kernel stack overflow.
Date: Wed, 30 Aug 2006 16:25:03 -0300	[thread overview]
Message-ID: <18d709710608301225x7407b216o74420d0b4034a484@mail.gmail.com> (raw)
In-Reply-To: <ed4nih$gb0$2@taverner.cs.berkeley.edu>

First of all, about your previous e-mail: you're correct, the members
not explicitly initialized behave like when  a _static_ object is not
explicitly initialized (ie., zero'ing it), instead of behaving like an
_automatic_ object not being explicitly initialized (which was the
kind of behavior I was expecting). This is part of the C99
specification, indeed.

See section 6.7.8, constraints no. 10 and 19, for more info.

On 8/30/06, David Wagner <daw@cs.berkeley.edu> wrote:
> I don't see any obvious place that zeroes out cdev->id.
> In particular, it looks like cdev->id.match_flags and .driver_info
> are never cleared (i.e., they retain whatever old garbage they had
> before).  More importantly, if anyone ever adds any more fields to
> struct ccw_device_id, then they will also be retain old garbage values,
> which is a maintenance pitfall.  Is this right, or did I miss something
> again?

Nicely pointed out, I hadn't thought about this possible maintenance
issue. Looks like a nice place for a memset() to reside.

Cheers,

    Julio Auto

      parent reply	other threads:[~2006-08-30 19:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-30 12:40 Martin Schwidefsky
2006-08-30 17:09 ` David Wagner
2006-08-30 17:40   ` Martin Schwidefsky
2006-08-30 17:52   ` Julio Auto
2006-08-30 18:20     ` Julio Auto
2006-08-30 18:41     ` David Wagner
2006-08-30 19:05 ` David Wagner
2006-08-30 19:19   ` Heiko Carstens
2006-08-31  9:06     ` Martin Schwidefsky
2006-08-30 19:25   ` Julio Auto [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18d709710608301225x7407b216o74420d0b4034a484@mail.gmail.com \
    --to=mindvortex@gmail.com \
    --cc=daw-usenet@taverner.cs.berkeley.edu \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome