From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 276FEC10F28 for ; Sun, 8 Mar 2020 09:00:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3A662072A for ; Sun, 8 Mar 2020 09:00:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726298AbgCHJAK (ORCPT ); Sun, 8 Mar 2020 05:00:10 -0400 Received: from smtprelay0190.hostedemail.com ([216.40.44.190]:39920 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726210AbgCHJAK (ORCPT ); Sun, 8 Mar 2020 05:00:10 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 0C66D1004E724; Sun, 8 Mar 2020 09:00:09 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: sign64_1254e082133d X-Filterd-Recvd-Size: 2023 Received: from XPS-9350.home (unknown [47.151.143.254]) (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA; Sun, 8 Mar 2020 09:00:07 +0000 (UTC) Message-ID: <18d7df753cb90d6c6f5a6b5e2a12b4c102ac8749.camel@perches.com> Subject: Re: [PATCH] cvt_fallthrough: A tool to convert /* fallthrough */ comments to fallthrough; From: Joe Perches To: "Gustavo A. R. Silva" , Andrew Morton , linux-kernel@vger.kernel.org Cc: clang-built-linux@googlegroups.com Date: Sun, 08 Mar 2020 00:58:29 -0800 In-Reply-To: <1f71509d-6c58-412d-a817-45b1cc78c06e@embeddedor.com> References: <576fe2ab-7937-4698-b32a-8599813d6ad1@embeddedor.com> <4304de54a44b7c8c22d8c2d9249d716664cf5ce8.camel@perches.com> <6773b7e3-8ce4-55d1-8bb7-bde6d9f6e887@embeddedor.com> <259f405155a948f90229d3fc8cad928d434b46f9.camel@perches.com> <1f71509d-6c58-412d-a817-45b1cc78c06e@embeddedor.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2020-03-08 at 01:11 -0600, Gustavo A. R. Silva wrote: > On 3/8/20 01:02, Joe Perches wrote: > > > or if you are suggesting that > > > the maintainers will have the predisposition of applying > > > patches that will modify their coding style and then go and > > > willingly fix that. I doubt the latter, though. > > > > If any do actually use the script, I guess we'll see. > > > Yep. In the meantime is a NACK from me for this version > of your patch. Generic code reformatters of comments to code are not particularly common. Instead of suggesting a nak for something that works pretty well, it would perhaps be more fruitful if you were to try either to write something else or try to improve the existing code. I'd be interested in seeing whatever code you produce. cheers, Joe