From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D5DB1369B9 for ; Mon, 24 Jun 2024 10:07:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719223649; cv=none; b=A3jZMCHIaDGtLR9hTT6q2WO+081sTgxNpRrJklVft1csSuEJQXhF1PAnwDUV4ucEiME13phKqZz9v2Qub0DGXIGCyHh6rC/9qa1pK/oyVs7sjBTKFT95vVuCJWvC+OCgX76B0mutM8Buy3rVzMrz/KwWW3LY39zDZeuIQvtKGW4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719223649; c=relaxed/simple; bh=r7/1IGaMLyBX5FetvH0z0WAcr9gpDIyubqQI/9Qmf0I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sPL99JBZvYQjTO28+dOIJD5e+9qxdBB3CNTO6vgu80V7QDSv83aqyV3yr2QmmVG6VgZpMB2VuunOriKOO1AIgMO8ihtthc9i3erioqhNc/Eb1rsTDPiWytqG9SAt9K8Ekwi20NBut3s7MyvPfR/g5md9t1Pl//c5GY7mAxYgIkU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yDsYVtFJ; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yDsYVtFJ" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-42172ed3597so23971895e9.0 for ; Mon, 24 Jun 2024 03:07:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719223645; x=1719828445; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DoIbdnv0I4lEFVQL9hNXgZOdZbepF06dTpWMDSVvSGE=; b=yDsYVtFJsnKMV1ZGPbgV3qmanV5P6ejmV8kdTa2RfDovEK69wXn92aApCAKFjoFyRS BolNkfOxzCQVMjzq/OzGMSg33bH3+ob8aFFtbHKYtvxdLAexfKFYkkDno2BWBbXeWSF7 8ad1vQUQLfcnah3lx2dctJGEAU8Ic7Tu0Reod2CotxDyf0VDFS0BoxUrNMhLXKXMlUtA UmqOHA7cA/RvwZVcQ44862cq8cx0meD4AKbdeDHQhewapKxdTF5RMiWZFtahWFcdoEeH u+gH59SCXSAMb2YhABJjkZPpLtmtemC4cvmElrNTTveuaI2kDyFQAOQQjXYz782AMDlB wzZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719223645; x=1719828445; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DoIbdnv0I4lEFVQL9hNXgZOdZbepF06dTpWMDSVvSGE=; b=xNNc+tHpLxMn+BpVjzWOGjfOd5rc1jn1lN/Y7n5+NvKY+gfkoZOLvwZ1dj5c18zk0T 4FnXTa22qbwsOus2uhLBjzKHIOd9AChWEBsXUJdPRUZqVGYhnFungy4/7JtBWc+ZKgz0 0bDe3sYASjIqvAUZWYinaRLZTgN0WWtEqTulXxJTGmDPhr4UdpR+V3zBvBtP0oBtd4LI xiz0vwUSqPse3ihOrulwy8ua1WC3O6XDSIaM444YEDqsjz/KCtbsQI8XctRQJOmiMw28 7p96zGVoT/1G08EZ5uR3cP6yc4OEAhyVfot/QLNCWpJidd+szJKjkPZWYIKVyFahwcsl uDFg== X-Forwarded-Encrypted: i=1; AJvYcCWqdkmhsG+x6QuZAuQJNds2WFlnfcY1CfjV7BzZnfDUiDxV1xhboqSswBeF/tpwOdyKZNqN7FgVb93cMDfnZ8Pm/vkRXnxPxnfrJKpU X-Gm-Message-State: AOJu0Yxc+zW8qqR5hCaNEkPuZE+u4dbnW3ym164oTPdLUROVgQj5/OuX nNbanYacGH8FdZLA+rQHd+dyRjrQS9z8TM1QF8SqriqfrNacW/CmCGrat8Tqo9M= X-Google-Smtp-Source: AGHT+IGFuIz1PalP36Z34AYkGOztlJ2XlnnVZCRPHiKbW3qfaoF4mCxs+lp1GKv51ihPubiVU6YwPQ== X-Received: by 2002:a05:600c:6a11:b0:421:8234:9bb4 with SMTP id 5b1f17b1804b1-424895fb1c5mr43871465e9.19.1719223645531; Mon, 24 Jun 2024 03:07:25 -0700 (PDT) Received: from [192.168.0.3] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-424817b53f2sm134536635e9.25.2024.06.24.03.07.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jun 2024 03:07:24 -0700 (PDT) Message-ID: <18df8577-5268-4a36-83fe-7cd7a7bbb7d3@linaro.org> Date: Mon, 24 Jun 2024 11:07:23 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/8] Add debug log info to camss_enable_clocks function To: gchan9527@gmail.com, Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org, Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240624-b4-sc7180-camss-v2-0-0dfecdc50073@gmail.com> <20240624-b4-sc7180-camss-v2-5-0dfecdc50073@gmail.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240624-b4-sc7180-camss-v2-5-0dfecdc50073@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 24/06/2024 00:22, George Chan via B4 Relay wrote: > From: George Chan > > Print out missing clock's name when doing camss_enable_clocks(). > > Signed-off-by: George Chan > --- > drivers/media/platform/qcom/camss/camss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c > index 86ba80c47188..d50f98565531 100644 > --- a/drivers/media/platform/qcom/camss/camss.c > +++ b/drivers/media/platform/qcom/camss/camss.c > @@ -1467,7 +1467,7 @@ int camss_enable_clocks(int nclocks, struct camss_clock *clock, > for (i = 0; i < nclocks; i++) { > ret = clk_prepare_enable(clock[i].clk); > if (ret) { > - dev_err(dev, "clock enable failed: %d\n", ret); > + dev_err(dev, "clock enable failed: %s %d\n", clock[i].name, ret); > goto error; > } > } > Acked-by: Bryan O'Donoghue