Re: [PATCH] fpga: xilinx-pr-decoupler: Use readl wrapper instead of pure readl

[Tom Rix <trix@redhat.com>]

On 3/21/23 8:33 AM, Michal Simek wrote:
> Driver has IO wrappers but xlnx_pr_decouple_read() is not used and readl is
> used instead which is just wrong.
> It is also generating sparse issue that xlnx_pr_decouple_read() is unused.
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>
> Created based on discussion with Tom here
> https://lore.kernel.org/r/20230317230617.1673923-1-trix@redhat.com
> ---
>   drivers/fpga/xilinx-pr-decoupler.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
> index 2d9c491f7be9..b76d85449b8f 100644
> --- a/drivers/fpga/xilinx-pr-decoupler.c
> +++ b/drivers/fpga/xilinx-pr-decoupler.c
> @@ -69,7 +69,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge)
>   	if (err)
>   		return err;
>   
> -	status = readl(priv->io_base);
> +	status = xlnx_pr_decouple_read(priv, CTRL_OFFSET);

Thanks for the change.

Reviewed-by: Tom Rix <trix@redhat.com>

>   
>   	clk_disable(priv->clk);
>