From: Logan Gunthorpe <logang@deltatee.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>,
linux-ntb@googlegroups.com,
linux-crypto <linux-crypto@vger.kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Horia Geantă" <horia.geanta@nxp.com>,
"Jon Mason" <jdmason@kudzu.us>
Subject: Re: [PATCH v11 7/7] ntb: ntb_hw_switchtec: Cleanup 64bit IO defines to use the common header
Date: Tue, 6 Mar 2018 10:03:55 -0700 [thread overview]
Message-ID: <18e6f79d-04db-463a-8916-09d7d859d273@deltatee.com> (raw)
In-Reply-To: <CAHp75Vf6sYss8q5FjgLYaQXYN761M4awmLVjZ48Cdd8+NrrhxQ@mail.gmail.com>
On 06/03/18 04:57 AM, Andy Shevchenko wrote:
> On Tue, Mar 6, 2018 at 1:46 PM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
>> On Tue, Mar 06, 2018 at 12:48:29PM +0200, Andy Shevchenko wrote:
>>> On Mon, Mar 5, 2018 at 9:08 PM, Logan Gunthorpe <logang@deltatee.com> wrote:
>>>> Clean up the ifdefs which conditionally defined the io{read|write}64
>>>> functions in favour of the new common io-64-nonatomic-lo-hi header.
>>>
>>>> #include <linux/kthread.h>
>>>> #include <linux/interrupt.h>
>>>> #include <linux/ntb.h>
>>>> +#include <linux/io-64-nonatomic-lo-hi.h>
>>>
>>> A nit, can we preserve alphabetical ordering?
>>
>> Ugh, why, it doesn't matter at all :)
>
> I'm fine with either way, but ordering is a good thing to have in long
> term prospective.
> Easy to find what headers are in there, easy to understand if you need
> another one or not, easy to maintain the list w/o duplications.
>
> I saw already few examples where long list of headers contained
> duplications b/c it was in messy order.
>
I agree with Greg here. This is a bit silly. The list isn't even
alphabetical to begin with so it can't be preserved. However, if I do a
v12 I'll make it alphabetical.
Logan
prev parent reply other threads:[~2018-03-06 17:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 19:08 [PATCH v11 0/7] Add io{read|write}64 to io-64-atomic headers Logan Gunthorpe
2018-03-05 19:08 ` [PATCH v11 1/7] powerpc: io.h: move iomap.h include so that it can use readq/writeq defs Logan Gunthorpe
2018-03-05 19:08 ` [PATCH v11 2/7] powerpc: iomap.c: introduce io{read|write}64_{lo_hi|hi_lo} Logan Gunthorpe
2018-03-05 19:08 ` [PATCH v11 3/7] iomap: " Logan Gunthorpe
2018-03-05 19:08 ` [PATCH v11 4/7] io-64-nonatomic: add io{read|write}64[be]{_lo_hi|_hi_lo} macros Logan Gunthorpe
2018-03-05 19:08 ` [PATCH v11 5/7] ntb: ntb_hw_intel: use io-64-nonatomic instead of in-driver hacks Logan Gunthorpe
2018-03-05 19:08 ` [PATCH v11 6/7] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64 Logan Gunthorpe
2018-03-06 12:37 ` Horia Geantă
2018-03-06 16:56 ` Logan Gunthorpe
2018-03-05 19:08 ` [PATCH v11 7/7] ntb: ntb_hw_switchtec: Cleanup 64bit IO defines to use the common header Logan Gunthorpe
2018-03-06 10:48 ` Andy Shevchenko
2018-03-06 11:46 ` Greg Kroah-Hartman
2018-03-06 11:57 ` Andy Shevchenko
2018-03-06 17:03 ` Logan Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18e6f79d-04db-463a-8916-09d7d859d273@deltatee.com \
--to=logang@deltatee.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=horia.geanta@nxp.com \
--cc=jdmason@kudzu.us \
--cc=linux-arch@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®