mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Werner Sembach <wse@tuxedocomputers.com>
Cc: Armin Wolf <W_Armin@gmx.de>, Hans de Goede <hansg@kernel.org>,
	 platform-driver-x86@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: uniwill-laptop: Add TUXEDO Stellaris 16 - Gen8 - Intel
Date: Wed, 11 Nov 2026 14:26:51 +0200 (EET)	[thread overview]
Message-ID: <18e8c77c-f605-8eb6-158c-69f3b49ed458@linux.intel.com> (raw)
In-Reply-To: <20261111115811.498955-1-wse@tuxedocomputers.com>

On Wed, 11 Nov 2026, Werner Sembach wrote:

> Same features as the Gen7. Just 2 new entries for the new boardnames.

The changelog should be readable as standalone, which this clearly isn't.

> I wrote the ident the same way the system product dmi string is written,

Don't use personalized terms like "I wrote".

> which itself now follows how the device is listed in your online shop. The
> only actual change was adding the '-' with spaces around.

What online shop have is irrelevant detail when it comes to kernel changes.

--
 i.

> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> ---
> This commit was built on top of Armins latest series:
> https://lore.kernel.org/all/20261110165318.631010-1-W_Armin@gmx.de/
> 
>  drivers/platform/x86/uniwill/uniwill-acpi.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/platform/x86/uniwill/uniwill-acpi.c b/drivers/platform/x86/uniwill/uniwill-acpi.c
> index dc99bf8a8568c..e2a6a704e942e 100644
> --- a/drivers/platform/x86/uniwill/uniwill-acpi.c
> +++ b/drivers/platform/x86/uniwill/uniwill-acpi.c
> @@ -3629,6 +3629,22 @@ static const struct dmi_system_id uniwill_dmi_table[] __initconst = {
>  		},
>  		.driver_data = &gmxixxx_xxxx45xx_xxxx55xx_xxxx57xx_descriptor,
>  	},
> +	{
> +		.ident = "TUXEDO Stellaris 16 - Gen8 - Intel",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),
> +			DMI_EXACT_MATCH(DMI_BOARD_NAME, "XxAF5xxx"),
> +		},
> +		.driver_data = &gmxixxx_xxxx45xx_xxxx55xx_xxxx57xx_descriptor,
> +	},
> +	{
> +		.ident = "TUXEDO Stellaris 16 - Gen8 - Intel",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),
> +			DMI_EXACT_MATCH(DMI_BOARD_NAME, "XxAF5xxx_mLED"),
> +		},
> +		.driver_data = &gmxixxx_xxxx45xx_xxxx55xx_xxxx57xx_descriptor,
> +	},
>  	{
>  		.ident = "TUXEDO Book BA15 Gen10 AMD",
>  		.matches = {
> 


      reply	other threads:[~2026-11-11 12:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 11:56 Werner Sembach
2026-11-11 12:26 ` Ilpo Järvinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18e8c77c-f605-8eb6-158c-69f3b49ed458@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=W_Armin@gmx.de \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=wse@tuxedocomputers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®