From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-187.mta1.migadu.com (out-187.mta1.migadu.com [95.215.58.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEB6C29ACFD for ; Wed, 25 Mar 2026 03:35:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.187 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774409729; cv=none; b=aeaV84cQLBid7Af4+++c9VxzvVjWduV9QzELX+CrUNKHj8o0zdpw7DA02eNCzTRB7XzPreerNyRdZ0VlSpA6kLc4jtMXKJbtcIINyu3sKmaya7Qzdbx/b/VH9X7Iyc0wVPoXVhdsoEgl8lGJgbx7aNa5MTUtKhqdaQ1iUBXNJmU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774409729; c=relaxed/simple; bh=DEtj95pUe3wqfw4kGZHdd83YnHL9RM1RUUCU25bLD8c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Xp4aGPi8fj09LzTIQf/gX3PM3nWVpUGUM28zpgQzKU4VaOwg9LrorkcTX6hHAtqMLkep8bhtC0mYDDSP/8WH5VBCq9gxX9dygWXdFy1EVPgeW/dCKXjFZ3W2P+zeqTiBDv5v+RluvyqR31ZdN89MRY4O9+rU8R9JbBmXpEBi3iw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=BOj/KfMt; arc=none smtp.client-ip=95.215.58.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="BOj/KfMt" Message-ID: <18ee1c67-f905-4b38-8f1e-8a2a77017ceb@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1774409725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3OpymkQSEIKE7Fqn9V/VdkGHTLFOzEO+6mJnfDDyy/Y=; b=BOj/KfMt+1WEUT7P6P9uUUJQmnHMsWXDCl5EPEw4x4QerN0OZjHxJCUE3Bc8vRcnZb12Xz tuHab2WH0/haqInhIBlBryL1W7FI15wcO/yFnpPiLyAPvVoHV7xbLBhP/z+yO1NadQoYGa 2RnPdmnU9G58oRg0bEQwJQfONqiKXRk= Date: Wed, 25 Mar 2026 11:34:55 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH 3/3] mm: memcontrol: correct the nr_pages parameter type of mem_cgroup_update_lru_size() To: "Harry Yoo (Oracle)" , "Lorenzo Stoakes (Oracle)" Cc: Qi Zheng , hannes@cmpxchg.org, hughd@google.com, mhocko@suse.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, david@kernel.org, lorenzo.stoakes@oracle.com, ziy@nvidia.com, yosry.ahmed@linux.dev, imran.f.khan@oracle.com, kamalesh.babulal@oracle.com, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, chenridong@huaweicloud.com, mkoutny@suse.com, akpm@linux-foundation.org, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com, lance.yang@linux.dev, bhe@redhat.com, usamaarif642@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Qi Zheng References: <2cf06f9faf51900ce6acbb4740fc60355a2842ed.1774342371.git.zhengqi.arch@bytedance.com> <641f8cfa-3a8a-439e-bf03-87af4c49ca2e@lucifer.local> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 3/25/26 8:27 AM, Harry Yoo (Oracle) wrote: > On Tue, Mar 24, 2026 at 12:28:08PM +0000, Lorenzo Stoakes (Oracle) wrote: >> On Tue, Mar 24, 2026 at 07:31:29PM +0800, Qi Zheng wrote: >>> From: Qi Zheng >>> >>> The nr_pages parameter of mem_cgroup_update_lru_size() should clearly >>> be long instead of int, let's correct it. >> >> Hmm, but are you ever going to be adding that many pages? I guess technically >> correct though. > > It has been fine as-is, but reparenting changes that. > Reparenting in theory could add billions of pages at once! Right. Thanks for the explanation! > > And yeah the commit message could be improved. Yes, I've omitted a lot of background information, which might seem abrupt to some reviewers unfamiliar with it. I will improve this in the next version. Thanks, Qi >