mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nihal Kumar Gupta <nihal.gupta@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Bryan O'Donoghue <bod@kernel.org>,
	Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	Loic Poulain <loic.poulain@oss.qualcomm.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Suresh Vankadara <svankada@qti.qualcomm.com>,
	Vikram Sharma <vikram.sharma@oss.qualcomm.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: media: qcom,glymur-camss: Drop port@3
Date: Thu, 19 Nov 2026 19:04:11 +0530	[thread overview]
Message-ID: <18effb9d-b83a-4842-a32c-0f2305cf0a14@oss.qualcomm.com> (raw)
In-Reply-To: <d741093d-345d-4cdf-a48d-2c5e55be2129@kernel.org>



On 19-11-2026 17:36, Krzysztof Kozlowski wrote:
>> How would you prefer this ABI issue to be handled, or should I
>> send the next version incorporating Loic's comments?
> Commit msg should be clear that ABI is changed, whether that ABI was
> ever working or even correct/possible to work in the first place. You do
> not answer my question really, because if description was not correct
> but everything was working fine, then clearly IT WAS correct to some level.

Yes, you are right. The old ABI was functional with the driver data at that
time, even though it used the X1E80100 CSIPHY resource index instead of a
Glymur-specific port mapping.

Old mapping:
  port@0 -> X1E80100 csiphy_res[0] -> CSIPHY0
  port@1 -> X1E80100 csiphy_res[1] -> CSIPHY1
  port@2 -> X1E80100 csiphy_res[2] -> CSIPHY2, not present on Glymur
  port@3 -> X1E80100 csiphy_res[3] -> CSIPHY4

So port@3 was functional before.

Now, Glymur is using linear graph ports instead of reusing X1E80100:
  port@0 -> csiphy_res[0] -> CSIPHY0
  port@1 -> csiphy_res[1] -> CSIPHY1
  port@2 -> csiphy_res[2] -> CSIPHY4

I will make this ABI change clear in the commit message.
-- 
Regards,
Nihal Kumar Gupta


  reply	other threads:[~2026-11-19 13:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13  8:20 [PATCH v2 0/2] media: qcom: camss: Fix Glymur CSIPHY topology Nihal Kumar Gupta
2026-11-13  8:20 ` [PATCH v2 1/2] dt-bindings: media: qcom,glymur-camss: Drop port@3 Nihal Kumar Gupta
2026-11-13  9:54   ` Loic Poulain
2026-11-15  6:49     ` Nihal Kumar Gupta
2026-11-16 12:09   ` Krzysztof Kozlowski
2026-11-16 12:18     ` Nihal Kumar Gupta
2026-11-16 12:22       ` Krzysztof Kozlowski
2026-11-16 12:32         ` Nihal Kumar Gupta
2026-11-19 11:37           ` Nihal Kumar Gupta
2026-11-19 12:06             ` Krzysztof Kozlowski
2026-11-19 13:34               ` Nihal Kumar Gupta [this message]
2026-11-13  8:20 ` [PATCH v2 2/2] media: qcom: camss: Add Glymur-specific resources Nihal Kumar Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18effb9d-b83a-4842-a32c-0f2305cf0a14@oss.qualcomm.com \
    --to=nihal.gupta@oss.qualcomm.com \
    --cc=bod@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=svankada@qti.qualcomm.com \
    --cc=vikram.sharma@oss.qualcomm.com \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®