Re: [PATCH v11 1/4] power_supply: Add additional health properties to the header

[Ricardo Rivera-Matos <r-rivera-matos@ti.com>]

On 5/28/20 9:16 AM, Andrew F. Davis wrote:
> On 5/28/20 10:05 AM, Ricardo Rivera-Matos wrote:
>> From: Dan Murphy <dmurphy@ti.com>
>>
>> Add HEALTH_WARM, HEALTH_COOL and HEALTH_HOT to the health enum.
>>
>> HEALTH_WARM, HEALTH_COOL, and HEALTH_HOT properties are taken from the JEITA spec.
>
> Wouldn't hurt to list the specific version of the spec these are from,
> but not super important,
>
> Acked-by: Andrew F. Davis <afd@ti.com>
ACK. This originates from JISC8712:2015, but is more succinctly 
explained in "A Guide to the Safe Use of Secondary Lithium Ion Batteries 
in Notebook-type Personal Computer"
>
>
>> Tested-by: Guru Das Srinagesh <gurus@codeaurora.org>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>>   Documentation/ABI/testing/sysfs-class-power | 2 +-
>>   drivers/power/supply/power_supply_sysfs.c   | 2 +-
>>   include/linux/power_supply.h                | 3 +++
>>   3 files changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
>> index bf3b48f022dc..9f3fd01a9373 100644
>> --- a/Documentation/ABI/testing/sysfs-class-power
>> +++ b/Documentation/ABI/testing/sysfs-class-power
>> @@ -190,7 +190,7 @@ Description:
>>   		Valid values: "Unknown", "Good", "Overheat", "Dead",
>>   			      "Over voltage", "Unspecified failure", "Cold",
>>   			      "Watchdog timer expire", "Safety timer expire",
>> -			      "Over current"
>> +			      "Over current", "Warm", "Cool", "Hot"
>>   
>>   What:		/sys/class/power_supply/<supply_name>/precharge_current
>>   Date:		June 2017
>> diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
>> index f37ad4eae60b..d0d549611794 100644
>> --- a/drivers/power/supply/power_supply_sysfs.c
>> +++ b/drivers/power/supply/power_supply_sysfs.c
>> @@ -61,7 +61,7 @@ static const char * const power_supply_charge_type_text[] = {
>>   static const char * const power_supply_health_text[] = {
>>   	"Unknown", "Good", "Overheat", "Dead", "Over voltage",
>>   	"Unspecified failure", "Cold", "Watchdog timer expire",
>> -	"Safety timer expire", "Over current"
>> +	"Safety timer expire", "Over current", "Warm", "Cool", "Hot"
>>   };
>>   
>>   static const char * const power_supply_technology_text[] = {
>> diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
>> index dcd5a71e6c67..8670e90c1d51 100644
>> --- a/include/linux/power_supply.h
>> +++ b/include/linux/power_supply.h
>> @@ -61,6 +61,9 @@ enum {
>>   	POWER_SUPPLY_HEALTH_WATCHDOG_TIMER_EXPIRE,
>>   	POWER_SUPPLY_HEALTH_SAFETY_TIMER_EXPIRE,
>>   	POWER_SUPPLY_HEALTH_OVERCURRENT,
>> +	POWER_SUPPLY_HEALTH_WARM,
>> +	POWER_SUPPLY_HEALTH_COOL,
>> +	POWER_SUPPLY_HEALTH_HOT,
>>   };
>>   
>>   enum {
>>