From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756578AbdEULqM (ORCPT ); Sun, 21 May 2017 07:46:12 -0400 Received: from goliath.siemens.de ([192.35.17.28]:44340 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751315AbdEULqJ (ORCPT ); Sun, 21 May 2017 07:46:09 -0400 To: Sudip Mukherjee Cc: Linux Kernel Mailing List , linux-serial , linux-gpio From: Jan Kiszka Subject: gpio-exar: Why filtering out Commtech devices? Message-ID: <18f4b5cb-cba0-aab4-7958-84a5b8d28935@siemens.com> Date: Sun, 21 May 2017 13:46:01 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sudip, why do we carry if (pcidev->vendor != PCI_VENDOR_ID_EXAR) return -ENODEV; in gpio_exar_probe? This effectively prevents that EXAR_DEVICE(COMMTECH, COMMTECH_4222PCIE, pbn_exar_XR17V35x), EXAR_DEVICE(COMMTECH, COMMTECH_4224PCIE, pbn_exar_XR17V35x), EXAR_DEVICE(COMMTECH, COMMTECH_4228PCIE, pbn_exar_XR17V35x), gain GPIO support. Do those devices lack access to the pins? Or can we drop the filter. I don't have access to those devices, just wondering because the code is not explaining the reason. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux