From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 195C5387362 for ; Thu, 19 Mar 2026 02:40:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773888035; cv=none; b=tFRdLz+DXrI8b2DRz5uPoprYlXMPo8ijk8ARHu2wHSRwaTCiA/SM1ERnVbZtxsBwp/np0HroYOoJySMtcNsyFj56Y6qXysbIxEfU091emMJWWj+XkOWgujxcSzrMBWo1zaVgW5MnMI2Ccwqr7VYxbmVt1/5SqV8sK41OwrcSIYY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773888035; c=relaxed/simple; bh=LDwZhBLJRJS0XzP/o3wjKWKQr8zFZKOvpYF6ozks28w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YF4ZK1MNk38Avj5QzImC8VpAa34U9FVJFbMtn63mLQp8kIJH9wJmyiQWucOiU1IyrOs4kLyvVo4GHmL+paL1d/fbAtUp3VghaAmCyNeSpIajpECLt279goxXDpdy5sJa8Q58D/q5r44TcDqTNQV7FSoBLE4eI+mQXRucitfm7MM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fXK6Yqr7; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fXK6Yqr7" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-82987437624so291584b3a.1 for ; Wed, 18 Mar 2026 19:40:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773888033; x=1774492833; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qBu63CJPO7UWTxKfklYPpnd3YM/gcmd39X2brzmYCN4=; b=fXK6Yqr7hcfHn1rkNdTLPxOYnj4emi/9FF2YmU7Mfp5iY9XL8x6hJvDIiliMTy5QJi BLfuWGdBPq54ZeA4iQf+o2qRaenL0/tlhIEdBbSv1Tp7gT9XYvDPcAJSL7WKaJpzIDlu MBVFOeUnhxxKlpY28ArjhKMkvyTdcdz071Cc2LIPiumR4WXXD43wPVODIZzDDzlUD5RV 3bJn/7x2o09d8VHB2jMppEGP4IYahYYZBFAEvnG6mSo40Hp4pUW6Ko3uaumYgB3l+mD/ 28B9BuEg5CCp2sJdhxWYf/4pBRTu39tmDiZ3a5wUslOZO2zdfUY/XDf/rbjdctSnp1fO 1VLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773888033; x=1774492833; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qBu63CJPO7UWTxKfklYPpnd3YM/gcmd39X2brzmYCN4=; b=GyMgkCs5tpFhZiqEwfG4FP5bAyeCp7kyieJKPgJL1rZ5riP+Eo0pCBY8zlKlTkBZnd apyr9pDmHREndE4cr5n2xQF8j6HwMwq40VCBLCG0HwHm7CSXUO6Z4LbIZBKfvlJ8sUTO cYHgMoy12cfa0A6RaUwMZmEKmLKbkENWbaHS5QkopHDAEd5nziTN+KTkNpzI0ifWaYkN 6XAo9noOub1GAoC+w8pGQiXrMUXPBjLnB6xKN4wEqdrCJXOSroXtFkMBp7kxszsFvTeY k7C3vneXZoC4xssW0ywHoBi5cIavsVY/pgTmc686fPdbl6g7gBg5QFn/JmaXThPWc3dd AUvQ== X-Forwarded-Encrypted: i=1; AJvYcCXhbgDkWqQWNUV9BPR3TpD5gkTlKr/qIhjhMT0lU2g06D7bCe9baD434oBFKUSxNM1fxCNOqr5f0CYaVMg=@vger.kernel.org X-Gm-Message-State: AOJu0YzIgtzrJZS4yx/K/VGtl2C67/TJ/aFy1tK40MpLJI9TAUTrNLM8 Kr5+TVeQ9Sx40xnsB+ad0nxRnZmbjBU7ehe3oIsoSxCO5Fa+5KO+yka/ X-Gm-Gg: ATEYQzyM3QYQbEMMxqePunXQS71CU/8+g3atGG6WclmvwoCZwngoxtTnIp6GpAXCz1g CD9lVGTWA770mXOT4AbcdOWnD652FpdPesA1qJSx70ZRn0tz2vXXth7Ie2AjHh+BMQ3gSYLDHJ+ rJ1R3P+FmxVHLuG5f12iOELkSkPhp0IhS/BLWE9XrAKz68urcT1viOWxKGejpyFNcMjkYK3Yhxi rBUhM/aVMoxwcxs0ryrxfGlrJIeTV7fqS6XT0w2D+iY2lEmXY0votDci8xhBacDRVxa4mCkrwOw HNGGVtyRMsfZBqGlWWUe4ozX3ygCUld2xu+CbYQSDKHS7tkNnkAFKlDHFqZ1uT9I3WcDp3uOf55 IUGkKTpFf2emwHQ6BVRSm7heWs9/ffmJq0Syyrrt8rlRnRaXKhtPeys+/+a6nhBVn41qoDehuXu pOIJPxy0tAkigfiFv0gLO1unj76E4tWmcdr/SP/1/A3B717bJzlaSrmYGrpscHAhnLyhtPWjjHW nNjnWEY9Rk64F8TzwBLrDgTRneKr5nE7wlUL4zmG5Mo0ktLILMRS0DSQnyuiNIPOBNz9NhDoLbM MA== X-Received: by 2002:a05:6a00:ab84:b0:829:8083:472b with SMTP id d2e1a72fcca58-82a7a7ffad1mr1502135b3a.4.1773888033409; Wed, 18 Mar 2026 19:40:33 -0700 (PDT) Received: from ?IPV6:2601:1c0:5780:9200:9662:a5ea:aac3:575e? ([2601:1c0:5780:9200:9662:a5ea:aac3:575e]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a6bbe1869sm4874011b3a.40.2026.03.18.19.40.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 19:40:33 -0700 (PDT) Message-ID: <18f74625-5f97-425b-8389-17d1bbecd4ac@gmail.com> Date: Wed, 18 Mar 2026 19:40:32 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] drm/panel: novatek-nt36672a: Convert to mipi_dsi_*_multi() helpers To: Doug Anderson Cc: sumit.semwal@linaro.org, neil.armstrong@linaro.org, jesszhan0024@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260305044921.10942-1-chintanlike@gmail.com> Content-Language: en-US From: Chintan Patel In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 3/6/26 09:40, Doug Anderson wrote: > Hi, > > On Wed, Mar 4, 2026 at 8:49 PM Chintan Patel wrote: >> >> Convert the driver to use the non-deprecated mipi_dsi_*_multi() helpers and >> mipi_dsi_msleep(). >> >> Switch DCS command sequences to the multi context API and >> accumulate errors via struct mipi_dsi_multi_context. Replace >> open-coded error handling with the multi helpers and convert >> nt36672a_send_cmds() and power sequencing accordingly. >> >> This patch is intended to functionally be a no-op, though there is one >> slight change. Previously a failure in regulator_bulk_disable() would >> have caused nt36672a_panel_unprepare() to return an error. Now it >> won't. No other errors in nt36672a_panel_unprepare() were propagated, >> so this makes things consistent. >> >> Signed-off-by: Chintan Patel >> --- >> Changes in v3: >> - Keep local ret variable in nt36672a_panel_power_off() to preserve error code in logging. >> - Change mipi_dsi_msleep() back to regular msleep(60) in power-down sequence to preserve behavior. >> - Reset dsi_ctx.accum_err before set_display_off_multi() and before power-down to preserve original error-tolerant shutdown behavior. >> >> Changes in v2: >> - Address alignment feedback from Doug. >> - Restore original power-down ordering. >> - Drop return value from nt36672a_panel_power_off(). >> - Consolidate error handling around dsi_ctx.accum_err. >> >> .../gpu/drm/panel/panel-novatek-nt36672a.c | 94 ++++++------------- >> 1 file changed, 30 insertions(+), 64 deletions(-) > > Looks good to me now. I'll plan to apply in ~1 week if there is no > further feedback. > > Reviewed-by: Douglas Anderson > > As per my response in v1 [1], someone could still do additional > cleanup to move away from the table-based initialization, but it > doesn't make sense to block this patch on that. :-) > Agree - I have plan to address as separate patch. > [1] https://lore.kernel.org/r/CAD=FV=WtjW5WWmjeb2zwF2PjiJeZv1jZS_UKZ0bT1658=CkwVA@mail.gmail.com > > -Doug