From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AECB2D8DDB for ; Mon, 6 Apr 2026 13:39:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775482769; cv=none; b=oaPr/SPwdh8yKNE1Wqa9HekKJdFh90BWd4QosQdTDFeShl3zR8S8Rw8Y/HacOhs/tUjE+w7odAFqZPzQi5QeUpCJ7GSiK9MX6OHiV6JB5Achzz9hieufF0a6vqU2UKPfV+Q7suxKod+VUWo/OhLp20Y6ZLE5vnZSpIf5zKR0DBM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775482769; c=relaxed/simple; bh=wkrJeNFWF2uMlRZnWrjqBwY2c14k9cP+d6D7rKAU8LI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pzLYKg+IlTdVEfUBerpDrmGRCXpfMWYExO6zYf3aWPwymC894+QhJJjEz3uz0PSCELDNZbG3yej4r0DnQWFINyEfgs8sYc4xCSx/A/r0eDeoidF9TB0F9pc6/+xEl9V6UKmIZcFpWV5sX25PccIGT3OH921kCJP5lax0Vdjgkww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=aD3K9pC7; arc=none smtp.client-ip=209.85.210.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="aD3K9pC7" Received: by mail-ot1-f52.google.com with SMTP id 46e09a7af769-7dbcf927395so868841a34.0 for ; Mon, 06 Apr 2026 06:39:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1775482766; x=1776087566; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1lorUh8imlkbzF1MrlVYRw6zvFFtCWMp5F11QdFDe9Y=; b=aD3K9pC7+rTAKV/iXTsVgBDse/4vpMthyb/KDFQgV63WpPiEnmyCldJO5vJ628jicF 3WKrk3tArUltkrCCMjwlyCILDZxdyRHEIJ1T2R28pEXs6+LTU/GnaJELtrizwWZZlU9Q SPjLyu7ddgigIsKfds4wcIwDshAvMZFoXlB9Urc3Qk2y4frxfSFyr92qGtcLVNP6wys8 WV2s5v29oBCfykNFmTDjLmofeNxwjXw2EXyIgbdndHEJEGyi09kbjg3YJIFqvHmjQVMM n1zRdgVrZ+OfNAUsCIOpTnHDzH0oFKV7rNwnicJ4rqISh3FcUtjWRPRy3u+meSjWUQeI Mstg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775482766; x=1776087566; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1lorUh8imlkbzF1MrlVYRw6zvFFtCWMp5F11QdFDe9Y=; b=fEoGHlXnhJIeb8f2CyM/IiCaep0y+BAadvgATHzQvE/oPPCAEctG60g0O58OF14QFY O1z7pNniXnHJdEmssRAp0gml0QGB9QT+WoId5RLzwk0mcwEOO5lnjlhzxYrgnzKBRiqz f0e/e9Q+dq5BU9BEXrAuJCrWAM/AZaznTvevXkhAKpynWIGmV/Jrq0pv6aL9RL63oPrI yYwwunwDgvO70uqDoJnGhKYzanLMG6IX8uDtJTmR5iLXneIHMumUOVsXKLH1DLjd5nAv 4T770+BrDSAEJCRsmjEtViWdYlJRwPv5TFkIbC2tqOml7BtfCBvNbdlVGZFZWexgIgru ZykA== X-Forwarded-Encrypted: i=1; AJvYcCXnjUHU1cssp3VMIDyv6M0IiwZngPrJm/lTQQ5W9STV5KHSHlgZgKP7ZWCxx5jg59+FOu9Iw9rRD2mFOZM=@vger.kernel.org X-Gm-Message-State: AOJu0YyuQBTJHOCkO+8GBJvRo8tUZwNXjfZs38OPYu2qjrhBT+E8OSXO WUhkn2WKGp5rr58HPHMciFIJfJgwTgl73xBmaS9wGMDwmQdwDVnZz0vEUEXeQzCALnY= X-Gm-Gg: AeBDiesmTPHhYqJxW3v11IBxt/6WpCcQ4P68Gds8jtW61heaRxGoQsNfpBESWufVcZx CSeITwf3isTCVBrcXNTEqBVKqLygiBU0jtx4VQnorKYD46HQTftWV2G6yIoh238tbYv4Q2LEMC9 I280XlUXu8cQkqkLbWhZ+0vv7nAJCGLuN4vW0eUJt+gBduy93UktwcBXukyOXeC+x9+LdVXDZwJ pu0yk8gqoOUMYdhLIlBVzgmvgMkVHRkvkQiLxb37/4BGz+7Pd4VZl2tR/fvzEEEehf7axNotIKk tH6Kc/fEGZofC0KbrLrCbwSKBT0TRJ8LFVepXW8vOwu6bEhzQiBgjGE8yad4lkbtuHU7uvKyHCh n//fzj68UCs886atEacIzg6NARsFeG+pxI6MFZRb6AUSH20FBB0WspODEAAZtfXQUBjlxCwViMK 6fLFj0OOa6VX/hQ33PYOvj4iAgGvjhnGiOCc3M0zsoPVXQyQM8zYL52a19nf3C9BpjQpcJ1qA= X-Received: by 2002:a05:6830:3783:b0:7d7:b6b2:6352 with SMTP id 46e09a7af769-7dbb6f961eamr7766540a34.13.1775482766251; Mon, 06 Apr 2026 06:39:26 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:90d7:b13f:c53:8ca3? ([2600:8803:e7e4:500:90d7:b13f:c53:8ca3]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7dbb7c3a0c8sm7531599a34.12.2026.04.06.06.39.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Apr 2026 06:39:25 -0700 (PDT) Message-ID: <18f79a5d-2f64-4984-9df0-40234f72646d@baylibre.com> Date: Mon, 6 Apr 2026 08:39:24 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 3/4] iio: adc: ad4691: add triggered buffer support To: "Sabau, Radu bogdan" , Lars-Peter Clausen , "Hennerich, Michael" , Jonathan Cameron , "Sa, Nuno" , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski , Philipp Zabel , Jonathan Corbet , Shuah Khan Cc: "linux-iio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pwm@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-doc@vger.kernel.org" References: <20260403-ad4692-multichannel-sar-adc-driver-v6-0-fa2a01a57c4e@analog.com> <20260403-ad4692-multichannel-sar-adc-driver-v6-3-fa2a01a57c4e@analog.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/6/26 4:22 AM, Sabau, Radu bogdan wrote: >> -----Original Message----- >> From: David Lechner >> Sent: Saturday, April 4, 2026 6:12 PM > > ... > >>> + >>> +/* >>> + * Valid ACC_DEPTH values where the effective divisor equals the count. >>> + * From Table 13: ACC_DEPTH = 2^N yields right-shift = N, divisor = 2^N. >>> + */ >>> +static const int ad4691_oversampling_ratios[] = { 1, 2, 4, 8, 16, 32 }; >> >> It would be nice to add oversampling in a separate commit as that is a >> separate feature. > > Do you think this would be suitable after the offload commit? > Yes, I think that would be OK.