From: Maninder Singh <maninder1.s@samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Lee Jones <lee.jones@linaro.org>
Cc: "sameo@linux.intel.com" <sameo@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
PANKAJ MISHRA <pankaj.m@samsung.com>
Subject: Re: [PATCH 1/1] mfd: remove unnecessary check
Date: Thu, 02 Jul 2015 03:14:11 +0000 (GMT) [thread overview]
Message-ID: <1900291101.154281435806850680.JavaMail.weblogic@ep2mlwas01a> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=windows-1252, Size: 1435 bytes --]
Hello,
>>> >> >
>>> >> > Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
>>> >> > Reviewed-by: Vaneet Narang <v.narang@samsung.com>
>>> >> > ---
>>> >> > drivers/mfd/t7l66xb.c | 4 ++--
>>> >> > 1 file changed, 2 insertions(+), 2 deletions(-)
>>> >>
>>> >> Applied, with a properly formatted subject line.
>>> >
>>> > Should have probably been more forthcomming with some advice.
>>> >
>>> > Next time, please use `git log --oneline -- <subsystem>` to see what
>>> > the accepted format is.
I did not know this thing.
I will keep that in mind from next time thanks.
>>> ... and a spell-check could be useful as well :). The reviewed-by tag
>>> was not sent on LKML and the person (Vaneet Narang) was not even CC-ed
>>> so I think it should be dropped.
Thanks for your feedback and noticing spell mistake "statndard" :-) and I applied reviewed-by tag in patch,
it is not from LKML, because if we reply any mail, our email client broke the mail thread,
Like my this reply will break down the mail chain from LKML.
>> Fair points. Patch dropped.
>
>I meant the reviewed-by tag should be dropped :) .
>
>So now... Maninder Singh, could you resent the patch with this minor
>issues fixed?
Yes I am sending patch with these fixes.
Thanks,
Maninder
.........
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next reply other threads:[~2015-07-02 3:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 3:14 Maninder Singh [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-06-30 12:12 Maninder Singh
2015-07-01 7:39 ` Lee Jones
2015-07-01 7:40 ` Lee Jones
2015-07-01 7:59 ` Krzysztof Kozlowski
2015-07-01 14:08 ` Lee Jones
2015-07-02 0:14 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1900291101.154281435806850680.JavaMail.weblogic@ep2mlwas01a \
--to=maninder1.s@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pankaj.m@samsung.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome