From: Mikael Pettersson <mikpe@it.uu.se>
To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
grundler@parisc-linux.org, tglx@linutronix.de, mikpe@it.uu.se
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/urgent] Revert "x86: cap iomem_resource to addressable physical memory"
Date: Sat, 27 Jun 2009 23:49:09 +0200 [thread overview]
Message-ID: <19014.37845.373626.810453@pilspetsen.it.uu.se> (raw)
In-Reply-To: <tip-fc1dbec8ae1a451557ade978bf7777b267690ca9@git.kernel.org>
tip-bot for H. Peter Anvin writes:
> Commit-ID: fc1dbec8ae1a451557ade978bf7777b267690ca9
> Gitweb: http://git.kernel.org/tip/fc1dbec8ae1a451557ade978bf7777b267690ca9
> Author: H. Peter Anvin <hpa@zytor.com>
> AuthorDate: Sat, 27 Jun 2009 12:22:27 -0700
> Committer: H. Peter Anvin <hpa@zytor.com>
> CommitDate: Sat, 27 Jun 2009 12:22:27 -0700
>
> Revert "x86: cap iomem_resource to addressable physical memory"
>
> This reverts commit 95ee14e4379c5e19c0897c872350570402014742.
> Mikael Petterson <mikpe@it.uu.se> reported that at least one of his
> systems will not boot as a result. We have ruled out the detection
> algorithm malfunctioning, so it is not a matter of producing the
> incorrect bitmasks; rather, something in the application of them
> fails.
>
> Revert the commit until we can root cause and correct this problem.
>
> -stable team: this means the underlying commit should be rejected.
>
> Reported-and-isolated-by: Mikael Petterson <mikepe@it.uu.se>
Typo, please s/mikepe/mikpe/ here.
> Signed-off-by: H. Peter Anvin <hpa@zytor.com>
> LKML-Reference: <200906261559.n5QFxJH8027336@pilspetsen.it.uu.se>
> Cc: stable@kernel.org
> Cc: Grant Grundler <grundler@parisc-linux.org>
>
>
> ---
> arch/x86/kernel/cpu/common.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
> index 6b26d4d..f1961c0 100644
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -848,9 +848,6 @@ static void __cpuinit identify_cpu(struct cpuinfo_x86 *c)
> #if defined(CONFIG_NUMA) && defined(CONFIG_X86_64)
> numa_add_cpu(smp_processor_id());
> #endif
> -
> - /* Cap the iomem address space to what is addressable on all CPUs */
> - iomem_resource.end &= (1ULL << c->x86_phys_bits) - 1;
> }
>
> #ifdef CONFIG_X86_64
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2009-06-27 21:50 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-26 15:59 [BUG 2.6.31-rc1] HIGHMEM64G causes hang in PCI init on 32-bit x86 Mikael Pettersson
2009-06-27 1:13 ` Mikael Pettersson
2009-06-27 4:25 ` Grant Grundler
2009-06-27 5:31 ` H. Peter Anvin
2009-06-29 2:24 ` Grant Grundler
2009-06-27 9:42 ` Mikael Pettersson
2009-06-27 19:27 ` H. Peter Anvin
2009-06-27 21:34 ` Mikael Pettersson
2009-06-27 4:53 ` H. Peter Anvin
2009-06-27 9:45 ` Mikael Pettersson
2009-06-29 2:29 ` Grant Grundler
2009-06-29 5:00 ` H. Peter Anvin
2009-06-29 11:12 ` Mikael Pettersson
2009-06-29 11:21 ` Matthew Wilcox
2009-06-29 11:57 ` Mikael Pettersson
2009-06-29 18:29 ` H. Peter Anvin
2009-06-29 22:47 ` Yinghai Lu
2009-06-29 23:29 ` Yinghai Lu
2009-06-30 0:27 ` H. Peter Anvin
2009-06-30 1:14 ` Yinghai Lu
2009-06-30 1:18 ` H. Peter Anvin
2009-06-30 1:24 ` Yinghai Lu
2009-06-30 2:41 ` H. Peter Anvin
2009-06-30 1:26 ` Linus Torvalds
2009-06-30 1:41 ` Yinghai Lu
2009-06-30 8:45 ` Mikael Pettersson
2009-06-30 14:48 ` H. Peter Anvin
2009-06-30 15:00 ` Rolf Eike Beer
2009-06-30 18:52 ` H. Peter Anvin
2009-06-30 19:33 ` Yinghai Lu
2009-06-30 19:44 ` H. Peter Anvin
2009-06-30 20:05 ` Yinghai Lu
2009-06-30 21:21 ` H. Peter Anvin
2009-06-30 21:50 ` Yinghai Lu
2009-06-30 22:10 ` Linus Torvalds
2009-06-30 22:30 ` Yinghai Lu
2009-06-30 22:51 ` Yinghai Lu
2009-06-30 22:54 ` H. Peter Anvin
2009-06-30 23:00 ` Linus Torvalds
2009-06-30 23:04 ` Linus Torvalds
2009-06-30 23:13 ` Yinghai Lu
2009-06-30 23:19 ` H. Peter Anvin
2009-07-01 19:32 ` [PATCH] x86: add boundary check for 32bit res before expand e820 resource to alignment Yinghai Lu
2009-07-01 19:33 ` [PATCH] fix round_up/down Yinghai Lu
2009-07-01 19:39 ` Joe Perches
2009-07-01 20:02 ` Andrew Morton
2009-07-02 18:10 ` [PATCH] x86: add boundary check for 32bit res before expand e820 resource to alignment -v2 Yinghai Lu
2009-07-03 8:05 ` Ingo Molnar
2009-06-30 23:16 ` [BUG 2.6.31-rc1] HIGHMEM64G causes hang in PCI init on 32-bit x86 H. Peter Anvin
2009-06-30 20:10 ` Linus Torvalds
2009-06-30 1:44 ` H. Peter Anvin
2009-06-30 0:22 ` H. Peter Anvin
2009-06-27 19:33 ` [tip:x86/urgent] Revert "x86: cap iomem_resource to addressable physical memory" tip-bot for H. Peter Anvin
2009-06-27 21:49 ` Mikael Pettersson [this message]
2009-06-27 22:04 ` tip-bot for H. Peter Anvin
2009-06-28 7:39 ` tip-bot for H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19014.37845.373626.810453@pilspetsen.it.uu.se \
--to=mikpe@it.uu.se \
--cc=grundler@parisc-linux.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®