mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrei Warkentin <awarkentin@vmware.com>
To: Jason Wessel <jason.wessel@windriver.com>
Cc: kgdb-bugreport@lists.sourceforge.net,
	linux-kernel@vger.kernel.org,
	Andrei Warkentin <andreiw@vmware.com>
Subject: Re: [PATCH] KDB: Fix usability issues relating to the 'enter' key.
Date: Sun, 26 Feb 2012 17:04:18 -0800 (PST)	[thread overview]
Message-ID: <190287371.1567191.1330304658088.JavaMail.root@zimbra-prod-mbox-2.vmware.com> (raw)
In-Reply-To: <4F4A3A8D.7030700@windriver.com>

Hi,

----- Original Message -----
> From: "Jason Wessel" <jason.wessel@windriver.com>
> To: "Andrei Warkentin" <andreiw@vmware.com>
> Cc: kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org
> Sent: Sunday, February 26, 2012 8:58:37 AM
> Subject: Re: [PATCH] KDB: Fix usability issues relating to the 'enter' key.

> 
> Andrei, if you agree with the attached patch, I'll put it in the
> merge queue.  If you find problems we can go another iteration. :-)
>

Nak. As I've mentioned in my original email, I went down this route as well, only
to ask the question of why the special ENTER code was there, since all it did
was introduce problems elsewhere (like repeat ENTER handling, KP ENTER key...).
This is exactly why my solution was to get rid of the special ENTER code altogether.

The code in kgdboc already will do input device reset on kdb exit, so there is no need
to explicitely empty out the keyboard FIFO on every ENTER.

Thanks,
A

  reply	other threads:[~2012-02-27  1:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-17 23:52 Andrei Warkentin
2012-02-25  3:20 ` Andrei Warkentin
2012-02-26 13:10 ` Jason Wessel
2012-02-26 13:58   ` Jason Wessel
2012-02-27  1:04     ` Andrei Warkentin [this message]
2012-02-27 22:50       ` Jason Wessel
2012-02-27 23:18         ` Andrei Warkentin
2012-02-27 23:28           ` Jason Wessel
2012-02-27 23:35             ` Andrei Warkentin
2012-02-28  1:27             ` Andrei Warkentin
2012-02-28  4:26             ` Andrei Warkentin
2012-02-28 13:53               ` Jason Wessel
2012-02-28 17:24                 ` Andrei Warkentin
2012-02-27  1:01   ` Andrei Warkentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=190287371.1567191.1330304658088.JavaMail.root@zimbra-prod-mbox-2.vmware.com \
    --to=awarkentin@vmware.com \
    --cc=andreiw@vmware.com \
    --cc=jason.wessel@windriver.com \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome