From: Paul Mackerras <paulus@samba.org>
To: Roland Dreier <rdreier@cisco.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: lib: Export generic atomic64_t functions
Date: Thu, 9 Jul 2009 11:09:24 +1000 [thread overview]
Message-ID: <19029.17220.326485.724846@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <ada63e221js.fsf@cisco.com>
Roland Dreier writes:
> The generic atomic64_t implementation in lib/ did not export the
> functions it defined, which means that modules that use atomic64_t
> would not link on platforms (such as 32-bit powerpc). For example,
> trying to build a kernel with CONFIG_NET_RDS on such a platform would
> fail with:
>
> ERROR: "atomic64_read" [net/rds/rds.ko] undefined!
> ERROR: "atomic64_set" [net/rds/rds.ko] undefined!
>
> Fix this by exporting the atomic64_t functions to modules. (I export
> the entire API even if it's not all currently used by in-tree modules to
> avoid having to continue fixing this in dribs and drabs)
>
> Signed-off-by: Roland Dreier <rolandd@cisco.com>
Nice, thanks.
Acked-by: Paul Mackerras <paulus@samba.org>
Andrew, I think this should be safe to go in 2.6.31. Could you
include it in your next batch for Linus, or should I send it to him
directly?
Paul.
next prev parent reply other threads:[~2009-07-09 1:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-08 23:32 Roland Dreier
2009-07-09 1:09 ` Paul Mackerras [this message]
2009-07-21 23:35 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19029.17220.326485.724846@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®