mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mikael Pettersson <mikpe@it.uu.se>
To: Cheng Renquan <crq@kernel.org>
Cc: linux-kbuild@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, crquan@gmail.com
Subject: Re: [PATCH 1/6] add symbol value to help find the real depend
Date: Sun, 12 Jul 2009 12:00:34 +0200	[thread overview]
Message-ID: <19033.46146.685018.240686@pilspetsen.it.uu.se> (raw)
In-Reply-To: <1247386308-19628-2-git-send-email-crq@kernel.org>

Cheng Renquan writes:
 > From: Cheng Renquan <crquan@gmail.com>
 > 
 > kbuild-menuconfig-display-depend-value.patch
 > 
 > Sometimes when configuring need to disable some unused item, but the item is
 > selected by many other items, it's hard to find the real dependency which
 > selected it, This patch add every symbol's value accompanied to make it
 > possible to find the real dependency easily.
 > 
 > An example is CONFIG_RFKILL,
 > 
 >   ---------------------- RF switch subsystem support ----------------------
 >   | CONFIG_RFKILL:                                                        |
 >   |                                                                       |
 >   | Say Y here if you want to have control over RF switches               |
 >   | found on many WiFi and Bluetooth cards.                               |
 >   |                                                                       |
 >   | To compile this driver as a module, choose M here: the                |
 >   | module will be called rfkill.                                         |
 >   |                                                                       |
 >   | Symbol: RFKILL [=m]                                                   |
 >   | Prompt: RF switch subsystem support                                   |
 >   |   Defined at net/rfkill/Kconfig:4                                     |
 >   |   Depends on: NET [=y]                                                |
 >   |   Location:                                                           |
 >   |     -> Networking support (NET [=y])                                  |
 >   |   Selected by: IWLCORE [=n] && NETDEVICES [=y] && !S390 [=S390] && PC |
 >   |                                                                       |
 >   ----------------------------------------------------------------( 99%)---

I like this concept, but I'd like to see it supported with make oldconfig.
Let's say I copy a .config from kernel X into kernel Y (Y>X) and make oldconfig.
Sometimes the new kernel will enable some previously disabled option, and
it would be very useful to see WHY.

To take a concrete example, in my 2.6.30 .config I had:

CONFIG_DRM=m
CONFIG_DRM_RADEON=m
# CONFIG_FB is not set

which when oldconfig'd in 2.6.31-rc changed to

CONFIG_DRM=m
CONFIG_DRM_RADEON=m
CONFIG_FB=m
(+ some more FB stuff)

In this case it would have been nice to get an explanation that DRM_RADEON
was responsible for (wrongly, IMO) selecting FB. Something like

# CONFIG_FB was selected by CONFIG_DRM_RADEON
CONFIG_FB=m

These comments should only be emitted for options added by select that
previously were absent or 'is not set'.

/Mikael

  parent reply	other threads:[~2009-07-12 10:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-12  8:11 [PATCH 0/6] kbuild configuration system improvements Cheng Renquan
2009-07-12  8:11 ` [PATCH 1/6] add symbol value to help find the real depend Cheng Renquan
2009-07-12  8:11   ` [PATCH 2/6] add menu_get_ext_help function to display more information Cheng Renquan
2009-07-12  8:11     ` [PATCH 3/6] menuconfig improvements Cheng Renquan
2009-07-12  8:11       ` [PATCH 4/6] make use of menu_get_ext_help in gconfig Cheng Renquan
2009-07-12  8:11         ` [PATCH 5/6] make use of menu_get_ext_help in qconfig Cheng Renquan
2009-07-12  8:11           ` [PATCH 6/6] make use of menu_get_ext_help in "make config" Cheng Renquan
2009-07-12 10:00   ` Mikael Pettersson [this message]
2009-07-12 17:14     ` [PATCH 1/6] add symbol value to help find the real depend Cheng Renquan
2009-07-18  7:21 ` [PATCH 0/6] kbuild configuration system improvements Sam Ravnborg
2009-07-18 10:47   ` Cheng Renquan
2009-07-22 20:43   ` Randy Dunlap
2009-07-22 21:48     ` Sam Ravnborg
2009-07-23  0:12       ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19033.46146.685018.240686@pilspetsen.it.uu.se \
    --to=mikpe@it.uu.se \
    --cc=akpm@linux-foundation.org \
    --cc=crq@kernel.org \
    --cc=crquan@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®