mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: Alex Bee <knaerzche@gmail.com>, Kalle Valo <kvalo@kernel.org>,
	<linux-wireless@vger.kernel.org>, <brcm80211@lists.linux.dev>,
	<brcm80211-dev-list.pdl@broadcom.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] wifi: brcmfmac: of: Support interrupts-extended
Date: Sat, 22 Jun 2024 15:38:33 +0200	[thread overview]
Message-ID: <190402b87a8.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> (raw)
In-Reply-To: <20240621225558.280462-1-knaerzche@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 609 bytes --]

On June 22, 2024 12:56:02 AM Alex Bee <knaerzche@gmail.com> wrote:

> This "new" version of defining external interrupts is around for a very
> long time now and supported and preferred by irq_of_parse_and_map
> respectively of_irq_parse_one.
>
> Support it in brcmfmac as well by checking if either "interrupts" or
> "interrupts-extended" property exists as indication if irq_of_parse_and_map
> should be called.

All very interesting, but why should we add code for something that is not 
specified in the bindings documentation?

NAK (for now). Feel free to update the bindings document.

Regards,
Arend



[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]

  reply	other threads:[~2024-06-22 13:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-21 22:55 Alex Bee
2024-06-22 13:38 ` Arend Van Spriel [this message]
2024-06-22 13:49   ` Arend Van Spriel
2024-06-22 14:07     ` Alex Bee
2024-06-22 14:40       ` Alex Bee
2024-06-22 17:46       ` Arend Van Spriel
2024-06-22 20:57         ` Alex Bee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=190402b87a8.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211@lists.linux.dev \
    --cc=knaerzche@gmail.com \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®