From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753851AbcC1CzC (ORCPT ); Sun, 27 Mar 2016 22:55:02 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:45561 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753324AbcC1Cy7 (ORCPT ); Sun, 27 Mar 2016 22:54:59 -0400 X-AuditID: cbfee690-f79e56d0000012c4-0f-56f89d003cc7 Date: Mon, 28 Mar 2016 02:54:56 +0000 (GMT) From: MyungJoo Ham Subject: Re: [PATCH v6 04/21] PM / devfreq: Add new DEVFREQ_TRANSITION_NOTIFIER notifier To: =?utf-8?Q?=EC=B5=9C=EC=B0=AC=EC=9A=B0?= , =?utf-8?Q?=EB=B0=95=EA=B2=BD=EB=AF=BC?= , =?utf-8?Q?=ED=81=AC=EC=89=AC=EC=8B=9C=ED=86=A0=ED=94=84?= , "kgene@kernel.org" Cc: "rjw@rjwysocki.net" , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "linux@arm.linux.org.uk" , "linux.amoon@gmail.com" , "m.reichl@fivetechno.de" , "tjakobi@math.uni-bielefeld.de" , =?utf-8?Q?=EB=8C=80=EC=9D=B8=EA=B8=B0?= , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" Reply-to: myungjoo.ham@samsung.com MIME-version: 1.0 X-MTR: 20160328024829192@myungjoo.ham Msgkey: 20160328024829192@myungjoo.ham X-EPLocale: ko_KR.utf-8 X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-MLAttribute: X-RootMTR: 20160328024829192@myungjoo.ham X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N X-ConfirmMail: N,general Content-type: text/plain; charset=utf-8 MIME-version: 1.0 Message-id: <190611333.27621459133690582.JavaMail.weblogic@epmlwas02a> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMIsWRmVeSWpSXmKPExsWyRsSkWJdh7o8wgw8XRCwu75rD5sDo8XmT XABjFJdNSmpOZllqkb5dAldGy+mpTAWbhCp2rFzG3MD4QbCLkZNDSEBdYtGSk2wgtoSAicTK /gnsELaYxIV764HiXEA1SxklGg6shSvq/PMcKjGHUeLLxVYWkASLgKrElalHgLo5ONgE9CRm fk4GMYUFIiSOTMgFqRARmMAksfhfAUgrs8BCdoknPy4xQxyhJLFm3yuwMbwCghInZz5hgdil KrG6axcjRFxNorf5JtQN4hIX5l6COpRXYkb7U6h6OYlpX9cwQ9jSEudnbWCEeWbx98dQcX6J Y7d3MEHYAhJTzxyEqtGSaLv6Csrmk1iz8C0LTP2uU8uZYXbd3zIXqldCYmvLE1YQm1lAUWJK 90Ow15kFNCXW79JH9wqvgJvEpr+/GEF+lxCYyCHxfvYkxgmMSrOQ1M1CMmoWwihkJQsYWVYx iqYWJBcUJ6UXmegVJ+YWl+al6yXn525iBKaF0/+eTdjBeO+A9SFGAQ5GJR7eDMsfYUKsiWXF lbmHGE2BkTSRWUo0OR+YfPJK4g2NzYwsTE1MjY3MLc2UxHlfS/0MFhJITyxJzU5NLUgtii8q zUktPsTIxMEp1cDI075v2czbzxrWPPn9/vXZq6tPPFhmJvwtMdZhxd0/wUEzsjq0GxTUr91t ybyrIyFk8mFtrXuIg/Qa7ekK6rN2fSwwYbTfdcT2tUNvE0OosuP21D37JUo/Nv67Jm5sFH/N sin/xgW1J7GH2dj/SS5NXMK4xa7uLG/jYZ+fF1zj46wnFKm/z+BWYinOSDTUYi4qTgQAt0v4 EAYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCKsWRmVeSWpSXmKPExsVy+t/tfl2GuT/CDJq7BCwu75rD5sDo8XmT XABjVJpNRmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtBQ JYWyxJxSoFBAYnGxkr6dTVF+aUmqQkZ+cYmtUrShuZGekYGeqZGeoXGslaGBgZEpUE1CWkbL 6alMBZuEKnasXMbcwPhBsIuRk0NIQF1i0ZKTbCC2hICJROef51C2mMSFe+uBbC6gmjmMEl8u trKAJFgEVCWuTD3C3sXIwcEmoCcx83MyiCksECFxZEIuSIWIwAQmicX/CkBamQUWsks8+XGJ GWKXksSafa/AxvAKCEqcnPmEBWKXqsTqrl2MEHE1id7mm1A3iEtcmHuJHcLmlZjR/hSqXk5i 2tc1zBC2tMT5WRsYYW5e/P0xVJxf4tjtHUwQtoDE1DMHoWq0JNquvoKy+STWLHzLAlO/69Ry Zphd97fMheqVkNja8oQVxGYWUJSY0v0Q7HVmAU2J9bv00b3CK+AmsenvL8YJjLKzkKRmIeme hdCNrGQBI8sqRtHUguSC4qT0CiO94sTc4tK8dL3k/NxNjOAU9GzRDsZ/560PMQpwMCrx8GZY /ggTYk0sK67MPcQowcGsJMKb2A4U4k1JrKxKLcqPLyrNSS0+xGgKjLKJzFKiyfnA9JhXEm9o bGxiZmJqaWJhYGquJM4b8HddmJBAemJJanZqakFqEUwfEwenVAOjxYxZJTyz18xX4mTe+Wnn C5taHn61NPn4h/pvpDo+tp92XFx4PqJIYfcx0/ZF/Q5NCTdvcVpqlzxj0+co4y+RO+z9JDDu ubBZw7tcFfWblxujT/m+bnxlMvPvUd5pR9NMHvbumldWe+ox44vYZwI5KwznPpLbPEcweUvG i3LuPeu6s3kEt9YpsRRnJBpqMRcVJwIAHDQkclcDAAA= DLP-Filter: Pass X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u2S2tAp3007242 > > This patch adds the new DEVFREQ_TRANSITION_NOTIFIER notifier to send > the notification when the frequency of device is changed. > This notifier has two state as following: > - DEVFREQ_PRECHANGE : Notify it before chaning the frequency of device > - DEVFREQ_POSTCHANGE : Notify it after changed the frequency of device > > And this patch adds the resourced-managed function to release the resource > automatically when error happen. > > Signed-off-by: Chanwoo Choi > [m.reichl and linux.amoon: Tested it on exynos4412-odroidu3 board] > Tested-by: Markus Reichl > Tested-by: Anand Moon > --- > drivers/devfreq/devfreq.c | 163 +++++++++++++++++++++++++++++++++++++++++++++- > include/linux/devfreq.h | 58 ++++++++++++++++- > 2 files changed, 219 insertions(+), 2 deletions(-) [] > diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h > index aa0b8424ebc3..152ea342529c 100644 > --- a/include/linux/devfreq.h > +++ b/include/linux/devfreq.h > @@ -19,6 +19,13 @@ > > #define DEVFREQ_NAME_LEN 16 > > +/* DEVFREQ notifier interface */ > +#define DEVFREQ_TRANSITION_NOTIFIER (0) > + > +/* Transition notifiers of DEVFREQ_TRANSITION_NOTIFIER */ > +#define DEVFREQ_PRECHANGE (0) > +#define DEVFREQ_POSTCHANGE (1) > + > struct devfreq; > > /** > @@ -177,6 +184,13 @@ struct devfreq { > unsigned int *trans_table; > unsigned long *time_in_state; > unsigned long last_stat_updated; > + > + struct srcu_notifier_head transition_notifier_list; > +}; Like other properties of struct devfreq, please add descriptions above. Other than that, it looks good.