From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 500203A8729 for ; Tue, 17 Mar 2026 10:34:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773743687; cv=none; b=oO9BtNcnqEOkQUH0vgaJ1u6XUD3R2EL5S+e72nKDP23HcF3JmpmYtPKbNw9HR+KOQhEP7PzaTox9aM05W6O+s/pUTbHqkbUDGD0KLregs+Fnj7UfUPhoK3zD60wcvkFeun5gEQBBdR8pI2hl/j2P2aEeVpLCa76CeR0NdYTwUYk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773743687; c=relaxed/simple; bh=cOJ0pqLB05cW7l8D0d5y/xnlGOGTKB72z83QuCFoWlI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ggw/869W42wSHlP9bQcHomGWu9SM4Phx09oxafau15YylD3+Vba4q07l8u9GPEhB4b0F2i1tVme9lhEGj9E6H7BkHkeE7WYqLmku3KSjEecbVw6kpP5cek4lfTxeg1wKPLC5QnFgtBLRFasCKKzmCJ80XLLl8Y/hWCnKpNfccmI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CRhIAl2f; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=jhU5lRmo; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CRhIAl2f"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="jhU5lRmo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773743685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ny0IuTqhujPnnvktMKwVQKRIYww+FI37mlIAqoGoFS8=; b=CRhIAl2fIPD+9Zy9h0eoRCjxNxwJZCHNhieCDyVKw+pk0ulC2P8ZQ0r3WiqH4F/4t9+Jir RDCIYJcIzYKbORr69wetXv612iqpo43JDWxSPFZDSE+/5GiqtjwMB/VsgGJFdTq6BUZfLC 4JaosOAdwLARoIXbDE5nd5UkMesDN1w= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-407-LA8CPtsGO3-cuDS05LyD3g-1; Tue, 17 Mar 2026 06:34:44 -0400 X-MC-Unique: LA8CPtsGO3-cuDS05LyD3g-1 X-Mimecast-MFC-AGG-ID: LA8CPtsGO3-cuDS05LyD3g_1773743683 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-43b42cd4becso415719f8f.1 for ; Tue, 17 Mar 2026 03:34:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773743683; x=1774348483; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ny0IuTqhujPnnvktMKwVQKRIYww+FI37mlIAqoGoFS8=; b=jhU5lRmoFBsvE9mcPAHRQtqhz+tZgTxj6HqNeh47C2/ltxxWR2vWB7ck4X4SlGru0D c5rYqONkzbGUPKlbFAYIVRt1sOuBV6yyQeCJErqIf0vpp172ZYpMgvHxzcmLQ25KVPo6 tNIzSurYa9nHVyWF5RlptqzbmavlzWGl425840CVOqbf6oxzQKeXjGTvMtZT4KF55HMF 2MwVVDRxtbat5H8XKwkko91NHVhQBsfPv/dzLeqTtCV6BZzQiXeROJWYbho6DAPU+Vco QkEO+UBETXqW/2mEe4ooZ1wt8wgqU0SLbrWM1ynZsDklfWf3UjSLx+yiK0+Zkpl3p60y eNfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773743683; x=1774348483; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ny0IuTqhujPnnvktMKwVQKRIYww+FI37mlIAqoGoFS8=; b=lCHLrkBi0sd2VURxpGQVQxHe0GtJifh5R8e+g6hWrV3NtSqoVv91ydFi2VqrJ2SrsM TP920iDxWBwmoshM7gTiIUD9rfLvP7FwvoZQA1yr+wft4qLk0cMikhFCO7bK1+zCKwgE 701V6NeAyszh9eBHjIG8h1zK/yYgxYxHEMzSwwpBDEA8+Ll2txP69CHCoNrFMHp2GjoG toe90oTRDv9s7LPewY9NEmgqm27VIWIviZTDnSDjJbsvbCJb1TsL6019RxTn69bb17Hv PCbLs1aMOg3TFewToaBYWjYMdQrBeH7rjpvjMY4LdQ7CobjWHQ/sFfoFxVAfdy4ixy0C RzDg== X-Forwarded-Encrypted: i=1; AJvYcCVrbsh1n+tXzrlC+TFlkhfy902IcJuCrZ8FJ/ODyGdB+/WxaK0tvYYD2MKcLzH8+Ba7bvzM/qcOjSXC1gI=@vger.kernel.org X-Gm-Message-State: AOJu0YyBSGQT4aDQ0+/jU7O8KbwfkNUjxkSx/c4jLKyhjEIBBiEDy83G 1sFHJ0xH2aBRKwujhMHhNzO9NRVQ444XLDiCo3BQHFHBYaDawJzrdVyAczlWeYGS+7ZjFte08/p R05shQa2bC9JrHcchE4K5NBd6NdKr77XyHS7jAQwXyx0ACOg/uXtCW2eBPB9KMHohvA== X-Gm-Gg: ATEYQzzYe9FQaUR+46r4U0T0r95wYeDX4cpZt9yIxNiAF3VqbfdXpu4n87KuhbXtCPQ EJKbJz0oVCUYkeV2BVthZc2i+Ap3Q8cx/7pKlN8kWq49jSSiV52ZsPyB7zZG3tJkrBqKzTMb/kH OQCT/aCODT8SfcyRLfbASk8sRSobOuBJ3e84ZHFzf76mOAow2R2noF0CEGXmNQAatnkcc4Hc1oH eQkspfltE7sYAu5EG/rui6zicVCLuWNhDX/FfRvCCnOulGaq+NGUvQKY3kYlTWiSQ0A7p9NphHs CA1Ny0QHm1eMAmyo75zawUGs1CpfzHhJim/KTFnnQ7GtZnBt5NW99QwVxg1nsX+T/qVLSAsnP8u gcDGZ6EDT9HEONR4i8pYGlgharrHKCncP2/zCLW2/HUjdyP7mC24ZLzg= X-Received: by 2002:a5d:5d06:0:b0:439:9812:35ea with SMTP id ffacd0b85a97d-43b498127a9mr5655211f8f.3.1773743682886; Tue, 17 Mar 2026 03:34:42 -0700 (PDT) X-Received: by 2002:a5d:5d06:0:b0:439:9812:35ea with SMTP id ffacd0b85a97d-43b498127a9mr5655135f8f.3.1773743682342; Tue, 17 Mar 2026 03:34:42 -0700 (PDT) Received: from [192.168.88.32] ([216.128.11.95]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b3e9a4fcdsm22271699f8f.8.2026.03.17.03.34.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 03:34:41 -0700 (PDT) Message-ID: <19078c41-5ee8-402a-9b60-fc4ab0fb8ece@redhat.com> Date: Tue, 17 Mar 2026 11:34:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/15] net: Use trace_invoke_##name() at guarded tracepoint call sites To: "Vineeth Pillai (Google)" Cc: Steven Rostedt , Peter Zijlstra , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Aaron Conole , Eelco Chaudron , Ilya Maximets , Marcelo Ricardo Leitner , Xin Long , Jon Maloy , Kuniyuki Iwashima , Samiullah Khawaja , Hangbin Liu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, dev@openvswitch.org, linux-sctp@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-trace-kernel@vger.kernel.org References: <20260312150523.2054552-1-vineeth@bitbyteword.org> <20260312150523.2054552-5-vineeth@bitbyteword.org> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260312150523.2054552-5-vineeth@bitbyteword.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/12/26 4:04 PM, Vineeth Pillai (Google) wrote: > Replace trace_foo() with the new trace_invoke_foo() at sites already > guarded by trace_foo_enabled(), avoiding a redundant > static_branch_unlikely() re-evaluation inside the tracepoint. > trace_invoke_foo() calls the tracepoint callbacks directly without > utilizing the static branch again. > > Suggested-by: Steven Rostedt > Suggested-by: Peter Zijlstra > Signed-off-by: Vineeth Pillai (Google) > Assisted-by: Claude:claude-sonnet-4-6 Side question: which is the merge plan here? since this patch depends on 1/15 I guess it's via the trace tree, am I correct? /P