From: Paul Mackerras <paulus@samba.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
dwalker@fifo99.com, mingo@redhat.com, hpa@zytor.com,
linux-kernel@vger.kernel.org, johnstul@us.ibm.com,
tglx@linutronix.de, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:timers/core] timekeeping: Increase granularity of read_persistent_clock()
Date: Tue, 25 Aug 2009 13:49:10 +1000 [thread overview]
Message-ID: <19091.24374.210127.155521@drongo.ozlabs.ibm.com> (raw)
In-Reply-To: <20090824082318.GD2424@elte.hu>
Ingo Molnar writes:
> * Paul Mackerras <paulus@samba.org> wrote:
> > In a stable, non-rebasing branch, sure. But putting untested
> > patches into such a branch would be a bit silly, so I assumed you
> > hadn't done that. :)
>
> You have not answered my primary question though AFAICS. There's
> _more_ build breakages in Linus's tree (in a volume-scaled form), so
> why dont you request rebases there?
Well, I don't see a lot of build breakages in Linus' tree, in fact.
What goes into Linus' tree is supposed to have been tested by
subsystem maintainers first, and if there is stuff that goes across
several architectures, it should have been posted to linux-arch
first. In other words, with Linus' tree the focus is on filtering out
at least the more obvious problems before they get into Linus' tree.
Sometimes that doesn't work, and then we yell at the person
responsible for a bit and then move on.
On the other hand, subsystem and architecture maintainers (such as
yourself) should be doing a reasonable amount of testing before
committing patches to any non-rebasing branch. Some maintainers use
quilt for this, others use testing branches that explicitly get
reconstructed frequently and are not for others to build on.
> If you requested them you'd have a snowball's chance in hell, Linus
> has never rebased the upstream tree, ever. Once pushed out for
> others to pull it's cast into stone. Yes, sometimes the build
> breaks, especially on rarely used architectures. We fix them.
Yet I see you pulling patches out of tip quite frequently. When I
update my local copy of your tip/perfcounters branches, maybe one time
in three I see a forced update of at least one of those branches.
You don't seem to have separate testing and non-rebasing branches.
Instead you seem to treat the more recent commits as testing and the
older ones as non-rebasing. I would suggest that that way of
operating isn't as clear and predictable for your downstream users as
it would be if you used separate branches.
> The more frequently an architecture is tested, the more it is used
> in practice, the more a driver and an architecture matters the
> shorter the bisection breakage window becomes. The upstream kernel
> is a self-tuning process of quality, even without rebases and
> backmerges.
>
> (DaveM does something quite similar to Linus too AFAICS, he too
> never rebases the networking tree.)
I don't follow the networking tree, but I do know that DaveM doesn't
publish commits until a reasonable period of time has passed since
committed them and he has done some basic testing of them.
Your way seems to be to push commits into tip very quickly and publish
them, and then do testing, then revert recent commits if they cause
problems.
> I'm thinking about starting to do the same for all -tip trees too: i
> do reasonable testing before pushing it out, on the most common
> architecture and driver selection, and once pushed out it's cast
> into stone Git-wise.
I think that's an excellent idea. If you want to let people help you
with the testing you could also publish the commits you're testing on
a testing branch. I would also advise a minimum latency for patches
to move from testing to the cast-in-stone branch of (say) one day
unless there is a very good reason for pushing them out more quickly.
If you have separate branches then it's clear to downstream users that
they should base their work on your cast-in-stone branch not your
testing branch.
I assume your "reasonable testing" includes building at least one
powerpc config, since you found the breakage on powerpc yourself.
> I actually start regretting that i do rebases too frequently - some
> people (not you really, but you gave me the perfect example to reply
> to) want more and seem to think they are _entitled_ to rebases and
> are entitled to backmerges. The thing is, rebases are not free. They
> are risky and error-prone, and they destroy Git history.
To be honest, I didn't think I was asking for a rebase of something
which was already cast in stone, since I didn't think you would have
cast a commit in stone before doing a build test on powerpc.
Paul.
next prev parent reply other threads:[~2009-08-25 3:55 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-14 13:47 [patch 00/15] clocksource / timekeeping rework V4 (resend V3 + bug fix) Martin Schwidefsky
2009-08-14 13:47 ` [patch 01/15] introduce timekeeping_leap_insert Martin Schwidefsky
2009-08-15 9:01 ` [tip:timers/core] timekeeping: Introduce timekeeping_leap_insert tip-bot for John Stultz
2009-08-14 13:47 ` [patch 02/15] remove clocksource inline functions Martin Schwidefsky
2009-08-15 9:01 ` [tip:timers/core] timekeeping: Remove " tip-bot for Martin Schwidefsky
2009-08-14 13:47 ` [patch 03/15] reset of cycle_last for tsc clocksource Martin Schwidefsky
2009-08-15 9:01 ` [tip:timers/core] timekeeping: Move reset of cycle_last for tsc clocksource to tsc tip-bot for Martin Schwidefsky
2009-08-14 13:47 ` [patch 04/15] cleanup clocksource selection Martin Schwidefsky
2009-08-15 1:42 ` john stultz
2009-08-15 1:43 ` john stultz
2009-08-17 7:34 ` Martin Schwidefsky
2009-08-15 9:02 ` [tip:timers/core] clocksource: Cleanup " tip-bot for Martin Schwidefsky
2009-08-14 13:47 ` [patch 05/15] clocksource watchdog highres enablement Martin Schwidefsky
2009-08-15 9:02 ` [tip:timers/core] clocksource: Delay " tip-bot for Martin Schwidefsky
2009-08-14 13:47 ` [patch 06/15] clocksource watchdog resume logic Martin Schwidefsky
2009-08-15 9:02 ` [tip:timers/core] clocksource: Simplify " tip-bot for Martin Schwidefsky
2009-08-14 13:47 ` [patch 07/15] clocksource watchdog refactoring Martin Schwidefsky
2009-08-15 9:02 ` [tip:timers/core] clocksource: Refactor clocksource watchdog tip-bot for Martin Schwidefsky
2009-08-14 13:47 ` [patch 08/15] clocksource watchdog work Martin Schwidefsky
2009-08-15 9:03 ` [tip:timers/core] clocksource: Move watchdog downgrade to a work queue thread tip-bot for Martin Schwidefsky
2009-08-14 13:47 ` [patch 09/15] introduce struct timekeeper Martin Schwidefsky
2009-08-15 9:03 ` [tip:timers/core] timekeeping: Introduce " tip-bot for Martin Schwidefsky
2009-08-14 13:47 ` [patch 10/15] add xtime_shift and ntp_error_shift to " Martin Schwidefsky
2009-08-15 9:03 ` [tip:timers/core] timekeeping: Add " tip-bot for Martin Schwidefsky
2009-08-15 9:04 ` [patch 10/15] add " Thomas Gleixner
2009-08-14 13:47 ` [patch 11/15] move NTP adjusted clock multiplier " Martin Schwidefsky
2009-08-15 9:03 ` [tip:timers/core] timekeeping: Move " tip-bot for Martin Schwidefsky
2009-08-14 13:47 ` [patch 12/15] timekeeper read clock helper functions Martin Schwidefsky
2009-08-15 9:03 ` [tip:timers/core] timekeeping: Add timekeeper read_clock " tip-bot for Martin Schwidefsky
2009-08-14 13:47 ` [patch 13/15] update clocksource with stop_machine Martin Schwidefsky
2009-08-15 9:04 ` [tip:timers/core] timekeeping: Update " tip-bot for Martin Schwidefsky
2009-08-14 13:47 ` [patch 14/15] read_persistent_clock should return a timespec Martin Schwidefsky
2009-08-15 9:04 ` [tip:timers/core] timekeeping: Increase granularity of read_persistent_clock() tip-bot for Martin Schwidefsky
2009-08-22 10:32 ` Ingo Molnar
2009-08-22 15:15 ` Martin Schwidefsky
2009-08-22 15:33 ` Ingo Molnar
2009-08-22 20:23 ` Martin Schwidefsky
2009-08-23 8:53 ` Ingo Molnar
2009-08-23 9:03 ` [tip:timers/core] timekeeping: Increase granularity of read_persistent_clock(), build fix tip-bot for Martin Schwidefsky
2009-08-23 3:33 ` [tip:timers/core] timekeeping: Increase granularity of read_persistent_clock() Paul Mackerras
2009-08-23 8:47 ` Ingo Molnar
2009-08-24 3:20 ` Paul Mackerras
2009-08-24 8:23 ` Ingo Molnar
2009-08-25 3:49 ` Paul Mackerras [this message]
2009-08-25 8:26 ` Ingo Molnar
2009-08-25 9:57 ` Paul Mackerras
2009-08-25 10:17 ` Ingo Molnar
2009-08-25 11:33 ` Paul Mackerras
2009-08-25 13:50 ` Ingo Molnar
2009-08-25 21:33 ` Theodore Tso
2009-08-25 22:03 ` Ingo Molnar
2009-08-26 0:26 ` Paul Mackerras
2009-08-26 0:22 ` Paul Mackerras
2009-08-25 23:48 ` Paul Mackerras
2009-08-26 9:44 ` Benjamin Herrenschmidt
2009-08-14 13:47 ` [patch 15/15] introduce read_boot_clock Martin Schwidefsky
2009-08-15 9:04 ` [tip:timers/core] timekeeping: Introduce read_boot_clock tip-bot for Martin Schwidefsky
2009-08-14 14:08 ` [patch 00/15] clocksource / timekeeping rework V4 (resend V3 + bug fix) Thomas Gleixner
2009-08-14 14:22 ` Martin Schwidefsky
2009-08-14 22:56 ` john stultz
2009-08-15 1:46 ` john stultz
2009-08-15 9:01 ` Thomas Gleixner
2009-08-15 9:52 ` Ingo Molnar
2009-08-15 10:08 ` Thomas Gleixner
2009-08-17 7:40 ` Martin Schwidefsky
2009-08-17 8:45 ` Thomas Gleixner
2009-08-17 9:28 ` [circular locking bug] " Ingo Molnar
2009-08-17 17:53 ` Martin Schwidefsky
2009-08-18 15:09 ` Martin Schwidefsky
2009-08-19 10:06 ` [tip:timers/core] clocksource: Avoid clocksource watchdog circular locking dependency tip-bot for Martin Schwidefsky
2009-08-19 20:25 ` [circular locking bug] Re: [patch 00/15] clocksource / timekeeping rework V4 (resend V3 + bug fix) Ingo Molnar
2009-08-20 9:28 ` Martin Schwidefsky
2009-08-20 9:58 ` Ingo Molnar
2009-08-20 10:35 ` Martin Schwidefsky
2009-08-20 16:14 ` Thomas Gleixner
2009-08-20 16:53 ` Martin Schwidefsky
2009-08-20 19:08 ` Thomas Gleixner
2009-08-19 9:46 ` [tip:timers/core] clocksource: Protect the watchdog rating changes with clocksource_mutex tip-bot for Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19091.24374.210127.155521@drongo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=dwalker@fifo99.com \
--cc=hpa@zytor.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®