From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754132Ab3LQV2p (ORCPT ); Tue, 17 Dec 2013 16:28:45 -0500 Received: from host171.canaca.com ([67.55.55.225]:42294 "EHLO host171.canaca.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751887Ab3LQV2n (ORCPT ); Tue, 17 Dec 2013 16:28:43 -0500 Message-ID: <190d226e64e177a3cb631b8fc6f4787c.squirrel@mungewell.org> In-Reply-To: <1387295334-1744-1-git-send-email-dh.herrmann@gmail.com> References: <1387295334-1744-1-git-send-email-dh.herrmann@gmail.com> Date: Tue, 17 Dec 2013 16:28:41 -0500 Subject: Re: [PATCH 0/4] Input: ABS2 and friends From: simon@mungewell.org To: "David Herrmann" Cc: linux-input@vger.kernel.org, "Dmitry Torokhov" , "Jiri Kosina" , "Benjamin Tissoires" , "Peter Hutterer" , "Antonio Ospite" , linux-kernel@vger.kernel.org, input-tools@lists.freedesktop.org, "David Herrmann" User-Agent: SquirrelMail/1.4.22 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host171.canaca.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - mungewell.org X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Hi > > This implements the recently discussed ABS2 API. It's working fine on my > machine with libevdev. Comments welcome! Just looking at the documentation file, I have a couple of suggestions. 1). Make a note on the direction of gravity wrt the example image. Ie what which axis/value will be positive with the device laid flat/stationary on a desk. Might just prevent some confusion later. 2). Calibration, Accels and Gyros are noisy in different ways. Gyros tend to be wrong in the long term, giving some consistant bias which should be calibrated out. Accels are noisy in the short term, but generally right over a long period. Am I correct that the event framework will provide time-stamping of data, thus making computation of relative movements possible. Simon