From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from canpmsgout01.his.huawei.com (canpmsgout01.his.huawei.com [113.46.200.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E81D2385D89 for ; Thu, 25 Jun 2026 08:51:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.216 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782377484; cv=none; b=ZKt95juCfy+nFCsj4Q4WWilZTC55esi2Oalg1jYUIyXoEWx7bxrRg3RTKRpHsOyhJZbDHYlCw/SBvvTx5Iog7U4J+u0i/RqOE6K6F1vuxc4P1gzNaWw0eNwjSeM1aWFDTG8JzLyFB9HG9MuDm1bZWDS5pM5dKV/uphuDEPtGTFQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782377484; c=relaxed/simple; bh=4NypIj0TIT8B2azRCkvEHKfXsa731cpcujBJimRXQHo=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=b1Qp3tTMA5RcQiM8diP9oA5PbkH4tQvS807c4m1FD4svsnNPJdFX1c2fYhBo9gOH16AF6UG0dgx47difpv/y6OKLlTODQ2gjVN7TSHvD4757D8WHXCdTgREvJTZ2Jbnb4tRUcPxcWx1GsV2JfLRJ73wZnXDVhQFTN6xw9ZIKtls= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=pXE2/Lq8; arc=none smtp.client-ip=113.46.200.216 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="pXE2/Lq8" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=vgG6+D68sy9iRTc5R0iCJ3olXs5OjWjTcVd+XbrgDPE=; b=pXE2/Lq89Ou8/Tcgq+tmjFS4Q/beQPc2UPLS3CkVp5jPHIyNLyCKSsCNxMkJYTRGrIvvkiyY6 eBebrAR6GFM6wFm5jYHV4vL91naBsZeJqwaVWWpAjt85V/rnTITtnz40/YSgsImntltOOgu4VO6 RvRnqWpfx0JjCqBVOB0XZkg= Received: from mail.maildlp.com (unknown [172.19.163.104]) by canpmsgout01.his.huawei.com (SkyGuard) with ESMTPS id 4gmC3n0Jrwz1T4H1; Thu, 25 Jun 2026 16:42:29 +0800 (CST) Received: from dggpemf500011.china.huawei.com (unknown [7.185.36.131]) by mail.maildlp.com (Postfix) with ESMTPS id 440EC4048F; Thu, 25 Jun 2026 16:51:11 +0800 (CST) Received: from [10.67.109.254] (10.67.109.254) by dggpemf500011.china.huawei.com (7.185.36.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 25 Jun 2026 16:51:09 +0800 Message-ID: <190f6862-25a8-495e-b96d-8a1a6d244bd3@huawei.com> Date: Thu, 25 Jun 2026 16:51:08 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v15 03/11] arm64/ptrace: Use syscall_get_nr() helper for syscall_trace_enter() To: Ada Couprie Diaz CC: , , , , , , , , , , , , , , , , , , , , , , References: <20260511092103.1974980-1-ruanjinjie@huawei.com> <20260511092103.1974980-4-ruanjinjie@huawei.com> <5ea376d7-388a-418c-acde-9ebe1da96202@arm.com> From: Jinjie Ruan In-Reply-To: <5ea376d7-388a-418c-acde-9ebe1da96202@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: kwepems200002.china.huawei.com (7.221.188.68) To dggpemf500011.china.huawei.com (7.185.36.131) On 6/24/2026 9:42 PM, Ada Couprie Diaz wrote: > On 11/05/2026 10:20, Jinjie Ruan wrote: > >> Use syscall_get_nr() to get syscall number for syscall_trace_enter(). >> This aligns arm64's internal tracing logic with the generic >> entry framework. >> >> [Changes] >> 1. Use syscall_get_nr() helper: >>     - Replace direct regs->syscallno access with >>       syscall_get_nr(current, regs). >>     - This helper is functionally equivalent to direct access on arm64. >> >> 2. Re-read syscall number after tracepoint: >>    - Re-fetch the syscall number after trace_sys_enter() as it may have >>      been modified by BPF or ftrace probes, matching generic entry >> behavior. >> >> [Why this matters] >> - Aligns arm64 with the generic entry interface. >> - Makes future migration to generic entry framework. > This is missing what it makes the future migration . Easier, possible ? > (Same in patch 02, but I missed it !) Hi Ada, Yes, a word was missing: 'simpler' or 'smoother'. Best regards, Jinjie >> - Properly handles syscall number modifications by tracers. >> - Uses standard architecture-independent helpers. >> >> No functional changes intended. >> >> Cc: Mark Rutland >> Cc: Will Deacon >> Cc: Catalin Marinas >> Reviewed-by: Linus Walleij >> Reviewed-by: Yeoreum Yun >> Reviewed-by: Kevin Brodsky >> Signed-off-by: Jinjie Ruan >> --- > > Otherwise, > > Reviewed-by: Ada Couprie Diaz >