From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DB201684A5 for ; Tue, 30 Jul 2024 06:37:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722321437; cv=none; b=EErgh/4/nm1lA2I852fufYZWj4xc/mrVP0DmcC6ZaygHxYA3Lfdk6C2q4bpeUzu/6lNeKR0E3BA128Neqo8XTdkejZ9l9NDphjGt1JxttSNIlLLdhVEZZs29v9SNhtJHZxIm151XiLSkyQSRnZ4UDzTiX71oI/EDdjzrTCcVvYE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722321437; c=relaxed/simple; bh=N47Qs6ylcphzAUtYxaZMJgXp9Hzc7IfQwO9V19FO3ms=; h=From:To:CC:Date:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=DOJZ0PmtqOIpWWHJKqSW/aQVqzLS26SJtJrFHXMkhY3bdHgu/jn+C0RCrQTO2Dd6LhcPUpNS+MAn+PzPmSmpScFHCoiuPMfBqh0Pd1h7hVP612Fj1o6gbFgS3zTA3u185bWfu2nhh4K5Q9cS7VYyr82i/XSQPc390u5ZObv+8kc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=UNxOmMl+; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="UNxOmMl+" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-2cf78366187so2446839a91.3 for ; Mon, 29 Jul 2024 23:37:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1722321434; x=1722926234; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:user-agent :references:in-reply-to:message-id:date:cc:to:from:from:to:cc :subject:date:message-id:reply-to; bh=d8n8rYBKoxfcGnZbJLvEREPokWsFDiloFhCfdKHeZA0=; b=UNxOmMl+jxkf6YnKJctgui1i7rf8X2l5K0keWflVRIkS1DItWOrNWcPJrspO2gAkjI WBH/fXwA7G8oPkTTE4/ZVuy3j+/9tGyASds7ghFKPU2RNcjTZDAUvTvnFfb5ccK+cxHW 0Ahfm7d5beHfMwrRS7PxuAw9NXYnhmcwF/O3g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722321434; x=1722926234; h=content-transfer-encoding:mime-version:subject:user-agent :references:in-reply-to:message-id:date:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=d8n8rYBKoxfcGnZbJLvEREPokWsFDiloFhCfdKHeZA0=; b=OOO2aPFCXjCc9EDnoBcWuYb664cLC2FWWuNBZOFnXGj/mw5hXi4EH3LfReP+w4rbSF mDsy9+UJ4OucWr+VBI+cuj9B70BpaeEIFw9YFyf3Eyk8famMBKw+WmS5STkJU97FEsLm iA+6HCfEqWtDskHCA1qf+jEx+7OsAX4V8EV2KiubBKMydr3BwhMxGaB4TFJuQhXTpfF/ XGTXzoRMYyxixYMVXIZzCkl+1QWkto+QkVjdQwq1JlMOmI7Ym2FA4BnbKsQmhQr7Gbqc XkNfU7JwW2lz9yXuHD+VhSVgqcWjI9fuorUBO7ES5z4lSAqEXAfR5O2xZDqxm/WJ5qey ELPw== X-Forwarded-Encrypted: i=1; AJvYcCWAmeHESnB8DxbNHqmqvR2WWPc2qZf6gCYJROLjqHrAWcmwcJ9zHKe01rOuTIFkV25Ld8DWkPkHWZNK/wjMtXAFjeqY/NUkTIco10U6 X-Gm-Message-State: AOJu0YzRbQEe6UeYgq/rQ0WDGMzUmIVa09WL3zWY6fDQF56r4xCvsLBe FC73Je0SgnaBFP7Fc52vFiNodOaNiBFyRKU665sxS9N6lxdtQcA1K7ra7j8q5g== X-Google-Smtp-Source: AGHT+IEbAYsTcrcjdD3UrZN6PQy+Do67Ei8GuSEd9YQg6UqH56tJFOZ2LAJA39UhwaNb5oNVG9ACLg== X-Received: by 2002:a17:90a:6b4c:b0:2c9:7ebd:b957 with SMTP id 98e67ed59e1d1-2cf7e1df0abmr10618508a91.11.1722321434495; Mon, 29 Jul 2024 23:37:14 -0700 (PDT) Received: from [192.168.178.38] (f215227.upc-f.chello.nl. [80.56.215.227]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2cdb7608b88sm11733257a91.56.2024.07.29.23.37.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Jul 2024 23:37:14 -0700 (PDT) From: Arend Van Spriel To: Jacobe Zang , , , , , , , , , , Linus Walleij CC: , , , , , , , , , , , , , , , , Date: Tue, 30 Jul 2024 08:37:05 +0200 Message-ID: <191025b5268.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> In-Reply-To: <20240730033053.4092132-3-jacobe.zang@wesion.com> References: <20240730033053.4092132-1-jacobe.zang@wesion.com> <20240730033053.4092132-3-jacobe.zang@wesion.com> User-Agent: AquaMail/1.51.5 (build: 105105504) Subject: Re: [PATCH v5 2/5] dt-bindings: net: wireless: brcm4329-fmac: add clock description for AP6275P Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="us-ascii" Content-Transfer-Encoding: 8bit + Linus W On July 30, 2024 5:31:15 AM Jacobe Zang wrote: > Not only AP6275P Wi-Fi device but also all Broadcom wireless devices allow > external low power clock input. In DTS the clock as an optional choice in > the absence of an internal clock. > > Reviewed-by: Arend van Spriel > Signed-off-by: Jacobe Zang > --- > .../bindings/net/wireless/brcm,bcm4329-fmac.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git > a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > index 2c2093c77ec9a..a3607d55ef367 100644 > --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > @@ -122,6 +122,14 @@ properties: > NVRAM. This would normally be filled in by the bootloader from platform > configuration data. > > + clocks: > + items: > + - description: External Low Power Clock input (32.768KHz) > + > + clock-names: > + items: > + - const: lpo > + We still have an issue that this clock input is also present in the bindings specification broadcom-bluetooth.yaml (not in bluetooth subfolder). This clock is actually a chip resource. What happens if both are defined and both wifi and bt drivers try to enable this clock? Can this be expressed in yaml or can we only put a textual warning in the property descriptions? Regards, Arend