From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB42E1953BB for ; Tue, 30 Jul 2024 10:08:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722334114; cv=none; b=jZR2PuGL1K2iQ5w+yBRyyLwSSW3IrL8UTSIfRxMvJ57NjN47nT1JnzjeoBHS/D6DKpDQ4v+NoidBAmGkiej3exLkghFCDq7BlHVAIgxQat4+wSVdzKqPZFFimXJ5dRyD10C/6eBKJiPqtR9Z/pD/hpAjdHqlHsnUBn3Y65D1pk0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722334114; c=relaxed/simple; bh=RnWCz84PVjtWkbkwbunfz/EotkXeNNxFhFHG+6twB7Q=; h=From:To:CC:Date:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=dYnmf3uPZQTqvEea1VQ0hB7qqOa4ViQZKMBSxqMorc0s9WfsnHP8nuXDMHPKgYg/om6Kpv4QwZUQko1t9Ls1Gh/b1i8UT5AnQ++LyV+mx/Y0qMV2Sqiz4kGtPqqpJUI01lwjrUs+rmnRgUGeNpcMciYgY+lQcSpkqlVzXEfeABg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=PQpTmfjT; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="PQpTmfjT" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-70d18112b60so3076058b3a.1 for ; Tue, 30 Jul 2024 03:08:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1722334111; x=1722938911; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:user-agent :references:in-reply-to:message-id:date:cc:to:from:from:to:cc :subject:date:message-id:reply-to; bh=it0G31C3nK4iT57/TuCykaOG5f+2KUhsEgQE63zlvQ8=; b=PQpTmfjTzCmEF7EbHiq6uxU1mWdmHpROX1MM9QkmV5hT1WbnF/ybwwjG6qVCNW/GeH 141Y/xA/WgrZf8eZV1yUWYqoJNkjyMuyCwpoN//+/qkCoCDsHlD3FlS87kncBuF35dqf ymw3/+ySbj9OVC2VnuXq1nPF0R2OmdcXwP+ls= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722334111; x=1722938911; h=content-transfer-encoding:mime-version:subject:user-agent :references:in-reply-to:message-id:date:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=it0G31C3nK4iT57/TuCykaOG5f+2KUhsEgQE63zlvQ8=; b=E7H8ZyJoDHsWUVQNVii1bDUVwjPWDJxBg1+Enxv4FAjTCO95wZ7FS8pyTFsyfr7HQB YiyHZHXpd0zMBwfgljQ4cO62djPVcSY1+ktbIkYZRcGIKesRm3Czc4Vd/Yzze+rDziEC /nrc43toCkj2z9VWZJ6dCaQGfOQKUKkEUeM0ZNNgZFZGZ1OFkPyUiOIYRVc3J+/4pS2K JZU02QFixhBBFARopOJ2KPFAHnRcBkP7b8uc54CvgOq/VFaI5jflJRmvgwaOvsBKxo+H VjsSRNySZO+A135xYvgjUARd0BD9c1ilhfZAqNxb8QAvY3ZVqGx3CShzeBVr2qatBA4I TNzA== X-Forwarded-Encrypted: i=1; AJvYcCX95XUAvcBsoIDjW5MIafZ0fDQEnzvz4rdlnKCaMI9nSN99tMVMAkrPkk02t8SRXdkcqSugZizGfgRXbCjpd2/f4w8t0azLymPqMe96 X-Gm-Message-State: AOJu0YzjBfE1yFHMItOQoL7XESvwGIJZka27+EMDY+T8CNt14H5ShoZR erly9AvbCd22Eo9LZTR9u0/4u74ii1+mZq3v9xga6N9qa1fAbqzN15w1wJi8Gg== X-Google-Smtp-Source: AGHT+IGshW2OzxRzfxWGvcbO0sAFmjyAkWIraUtC7GDL6IIXZLZQRc2Ic/SOA1XlSk6flzreTwMvTw== X-Received: by 2002:a05:6a00:3e22:b0:70b:5368:a212 with SMTP id d2e1a72fcca58-70efe49ddcbmr2198191b3a.15.1722334110893; Tue, 30 Jul 2024 03:08:30 -0700 (PDT) Received: from [192.168.178.38] (f215227.upc-f.chello.nl. [80.56.215.227]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70ead6e33e2sm8106343b3a.28.2024.07.30.03.08.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jul 2024 03:08:30 -0700 (PDT) From: Arend Van Spriel To: Jacobe Zang , Krzysztof Kozlowski , , , , , , , , , , Linus Walleij CC: , , , , , , , , , , , , , , , , Nick Xie Date: Tue, 30 Jul 2024 12:08:19 +0200 Message-ID: <191031cb638.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> In-Reply-To: References: <20240730033053.4092132-1-jacobe.zang@wesion.com> <20240730033053.4092132-3-jacobe.zang@wesion.com> <191025b5268.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> <191030eac78.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> User-Agent: AquaMail/1.51.5 (build: 105105504) Subject: Re: [PATCH v5 2/5] dt-bindings: net: wireless: brcm4329-fmac: add clock description for AP6275P Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="us-ascii" Content-Transfer-Encoding: 8bit On July 30, 2024 12:00:25 PM Jacobe Zang wrote: >>> On 30/07/2024 08:37, Arend Van Spriel wrote: >>>> + Linus W >>>> >>>> On July 30, 2024 5:31:15 AM Jacobe Zang wrote: >>>> >>>>> Not only AP6275P Wi-Fi device but also all Broadcom wireless devices allow >>>>> external low power clock input. In DTS the clock as an optional choice in >>>>> the absence of an internal clock. >>>>> >>>>> Reviewed-by: Arend van Spriel >>>>> Signed-off-by: Jacobe Zang >>>>> --- >>>>> .../bindings/net/wireless/brcm,bcm4329-fmac.yaml | 8 ++++++++ >>>>> 1 file changed, 8 insertions(+) >>>>> >>>>> diff --git >>>>> a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml >>>>> b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml >>>>> index 2c2093c77ec9a..a3607d55ef367 100644 >>>>> --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml >>>>> +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml >>>>> @@ -122,6 +122,14 @@ properties: >>>>> NVRAM. This would normally be filled in by the bootloader from platform >>>>> configuration data. >>>>> >>>>> + clocks: >>>>> + items: >>>>> + - description: External Low Power Clock input (32.768KHz) >>>>> + >>>>> + clock-names: >>>>> + items: >>>>> + - const: lpo >>>>> + >>>> >>>> We still have an issue that this clock input is also present in the >>>> bindings specification broadcom-bluetooth.yaml (not in bluetooth >>>> subfolder). This clock is actually a chip resource. What happens if both >>>> are defined and both wifi and bt drivers try to enable this clock? Can this >>>> be expressed in yaml or can we only put a textual warning in the property >>>> descriptions? >>> >>> Just like all clocks, what would happen? It will be enabled. >> >> Oh, wow! Cool stuff. But seriously is it not a problem to have two entities >> controlling one and the same clock? Is this use-case taken into account by >> the clock framework? > > I have enabled the same clock both in bluetooth and wifi just now, they worked > well. Maybe this make sense? What happens if you unload one of the drivers? Also would like to know if you are using an nvram file. If so can you share it's content. Regards, Arend