From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4B201990BE for ; Tue, 30 Jul 2024 11:17:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722338230; cv=none; b=kGycE/r2COHMXX0PZP9gCTpuCDdlnfmX6BsgLnB7oHVJ2Z1pgvzzrVuR0KyHbaFX2pOcA+C5YJfD7HKGtcThTAz7XdfJ16VKMGyuM4R954cqBb/TvfyHky+SjwOUm8CeKaKtieJVoEZClr2GDIexVMSvlKUPtGG/le99vTigEi0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722338230; c=relaxed/simple; bh=0c0bFjkp6lOGtIuddq5kJa8o0xZsFNb6mXA9glrX6aU=; h=From:To:CC:Date:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=FjMRHqHM702GpoqLMi9rhn69D+SbSFSuBrJYhmX4wU79F7nCIlwGQFe3iTiw7xicdyaGJgdDenz7pbH93fZKo0Pz3CWVTzp/h/tC3FjTamVB2SVbl7MQM6uAcBfLmGDVZobrxy2wJKdAzpE8GiYtRz4ACLdILksCp+Pcs+j5wbA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Nd+EfQ+w; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Nd+EfQ+w" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-70d150e8153so2707027b3a.0 for ; Tue, 30 Jul 2024 04:17:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1722338227; x=1722943027; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:user-agent :references:in-reply-to:message-id:date:cc:to:from:from:to:cc :subject:date:message-id:reply-to; bh=zMjbsaf9Qg0PIMOUCDvNeB4fJscDIysusSNb+GlHnFs=; b=Nd+EfQ+wIj9qw10KlWIT2v8R7MM1vJIS5xk08TZMHj2pkl0eLoEl0US5hFI9orFTta ZKMaaevAYeNzsm500qLWn8xShKGVzHYwsBBYXLfVyc9dRMhL7HO7BzlAlWESqeivzsVl 3pRVfp1L1arNye74db56Fk4hFLzHr/yhjpf5s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722338227; x=1722943027; h=content-transfer-encoding:mime-version:subject:user-agent :references:in-reply-to:message-id:date:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zMjbsaf9Qg0PIMOUCDvNeB4fJscDIysusSNb+GlHnFs=; b=m/0zCIAUV+KlfSxSXNDOYTXBKZmxEG8zlOEWtcHVkJYA2Db2sXTFq7mIoHwsWsGm4Y NLuMglWR26kS7X7+UQZOkMaNaTDdYkaIJbe9ThDUgGrvX3PbY0UKoxllRqKMFMpkk6Rg KeT3K/hU8aSArGq+l3BFrCbWsPivuXwIY2kQFaZ/D1/gEJdX7g8oGKYJsT1Ehu+IWRT9 vSoLcsFnAvszIFEehmPikV0WAGIbHUMXbsuQgOJ+E9K9iWFihz0D6zoNnHXh5v8ikL5k ZB4vOzFlp7BuW0Vewrt0kQAG5DUoxRvLMTJz8HtOwWAi87vABOrx12PtIuoVelmPeTvp iDxg== X-Forwarded-Encrypted: i=1; AJvYcCXtbGSSKDZSVktgS7oEFZ7FH41cUZUX+xq9O7oLq2aS8U3z79s4z3jH5C00xAKUrxrZziN97c2CkEohS2SbxLy7qzYqJnKsKaC4mqiW X-Gm-Message-State: AOJu0Yz4pWU0Or8rtU5oFaz0SBoi/ETNztMeWQo1jo9i34U3Za+LUFVs rC0d9NT7yscqHbo2iILTxkn6mLc2ZhnPwbZIHMf4DFc6gFK0VJELNgi6rk2caA== X-Google-Smtp-Source: AGHT+IH4GPuLW4JZ70pCnepe2Vow6yWK71i6a+LS+KmDte3yg0ALlYZIjJj1WsTlusgr/MqCrENMNw== X-Received: by 2002:a05:6a20:7346:b0:1be:c41d:b6b7 with SMTP id adf61e73a8af0-1c4e47fb70fmr3042955637.19.1722338226714; Tue, 30 Jul 2024 04:17:06 -0700 (PDT) Received: from [192.168.178.38] (f215227.upc-f.chello.nl. [80.56.215.227]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70ead81272esm8462046b3a.97.2024.07.30.04.16.59 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jul 2024 04:17:06 -0700 (PDT) From: Arend Van Spriel To: Krzysztof Kozlowski , Jacobe Zang , , , , , , , , , , Linus Walleij CC: , , , , , , , , , , , , , , , , Date: Tue, 30 Jul 2024 13:16:57 +0200 Message-ID: <191035b8c28.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> In-Reply-To: <3d3b8e0a-7492-4db1-bd73-c30a488edaa7@kernel.org> References: <20240730033053.4092132-1-jacobe.zang@wesion.com> <20240730033053.4092132-3-jacobe.zang@wesion.com> <191025b5268.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> <191030eac78.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> <3d3b8e0a-7492-4db1-bd73-c30a488edaa7@kernel.org> User-Agent: AquaMail/1.51.5 (build: 105105504) Subject: Re: [PATCH v5 2/5] dt-bindings: net: wireless: brcm4329-fmac: add clock description for AP6275P Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="us-ascii" Content-Transfer-Encoding: 8bit On July 30, 2024 12:18:20 PM Krzysztof Kozlowski wrote: > On 30/07/2024 11:52, Arend Van Spriel wrote: >> On July 30, 2024 11:01:43 AM Krzysztof Kozlowski wrote: >> >>> On 30/07/2024 08:37, Arend Van Spriel wrote: >>>> + Linus W >>>> >>>> On July 30, 2024 5:31:15 AM Jacobe Zang wrote: >>>> >>>>> Not only AP6275P Wi-Fi device but also all Broadcom wireless devices allow >>>>> external low power clock input. In DTS the clock as an optional choice in >>>>> the absence of an internal clock. >>>>> >>>>> Reviewed-by: Arend van Spriel >>>>> Signed-off-by: Jacobe Zang >>>>> --- >>>>> .../bindings/net/wireless/brcm,bcm4329-fmac.yaml | 8 ++++++++ >>>>> 1 file changed, 8 insertions(+) >>>>> >>>>> diff --git >>>>> a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml >>>>> b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml >>>>> index 2c2093c77ec9a..a3607d55ef367 100644 >>>>> --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml >>>>> +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml >>>>> @@ -122,6 +122,14 @@ properties: >>>>> NVRAM. This would normally be filled in by the bootloader from platform >>>>> configuration data. >>>>> >>>>> + clocks: >>>>> + items: >>>>> + - description: External Low Power Clock input (32.768KHz) >>>>> + >>>>> + clock-names: >>>>> + items: >>>>> + - const: lpo >>>>> + >>>> >>>> We still have an issue that this clock input is also present in the >>>> bindings specification broadcom-bluetooth.yaml (not in bluetooth >>>> subfolder). This clock is actually a chip resource. What happens if both >>>> are defined and both wifi and bt drivers try to enable this clock? Can this >>>> be expressed in yaml or can we only put a textual warning in the property >>>> descriptions? >>> >>> Just like all clocks, what would happen? It will be enabled. >> >> Oh, wow! Cool stuff. But seriously is it not a problem to have two entities >> controlling one and the same clock? Is this use-case taken into account by >> the clock framework? > > Yes, it is handled correctly. That's a basic use-case, handled by CCF > since some years (~12?). Anyway, whatever OS is doing (or not doing) > with the clocks is independent of the bindings here. The question is Agree. Probably the bindings would not be the place to document this if it would be an issue. > about hardware - does this node, which represents PCI interface of the > chip, has/uses the clocks. The schematics I found for the wifi module and the khadas edge platform show these are indeed wired to the chip. Regards, Arend > Best regards, > Krzysztof