From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 506B63F86E2 for ; Wed, 5 Aug 2026 09:37:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785922680; cv=none; b=NjTo31MggUXYAhdilpTpb251J6HgXBuF35aGJTgvb5d4LVPhnZMOxaLvxNdltWxoIk+flZanjNqRq2q1ZIbx7diuTQqP9PZ5XFg54m8l0b2+xHqw0vUa27TCoUMZ9XuAxzBw6JrIRsMMTXyppGZt5/joa/1HLs0t0L3cxJTqFKE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785922680; c=relaxed/simple; bh=KMR6SWM19erGsffKdL2Iv9/3DBMFJ3A5y8JxmficuJI=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=HlCVFnHzKHBLZFQCR3JxJ/BybdunZFgkb/W9YmAHoLuFSKZe1DqFcKgojm7Ln+jNFFtZK+GqDU4XNXVQLiFK9xPsIPpUFmnylyRacxvB0K+zU5vKqIw7zN17bU50eQhmnHAlW6NmWcV8he9sarMckGTtwrUfxPaH9digYx7m0fs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EoMsr0r1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XVxgxLPd; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EoMsr0r1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XVxgxLPd" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6758dFQp2132533 for ; Wed, 5 Aug 2026 09:37:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bMILTWQ3u1gjsljNym/1x+Kl/G5TJKj09mRXvfx+800=; b=EoMsr0r1f4NBTCMO aOpTeOK+9Wrnx5rVf/Y6USVH82y0msZ/zm4VKHmfgEohVzw/AJp17Vop8Tp1j4uB vFdDFMryU+4tYEDr8xx6em+pxofb0Pnp7DVRSm55mhO/ONfOLwh+GnNtbkQXaV05 vips8j8WEqpmGhg6AjUjUHQ5+UkdjHlbTYrcJEZtWmwOa4UXCjiHIwkofSEvGRek XSKiXWv4oKp3Ru83s0hM3zO82NJXG6lbbDJmO9X56sc3Ojr3sQyvhs0zK6hsmS89 UMGJv4da/eghcSkm1Zu1rR3jStResHIJWgCq+fWOjoOO7f9R0CAo+9Vag2b9CVwf W4GGHw== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fum56buyu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 05 Aug 2026 09:37:57 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-38fcaa5f82cso895550a91.3 for ; Wed, 05 Aug 2026 02:37:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785922677; x=1786527477; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=bMILTWQ3u1gjsljNym/1x+Kl/G5TJKj09mRXvfx+800=; b=XVxgxLPd1NwVjuW8paPp5MpdTVU4K/sysI8hNPzYnTI8927qJIo/mnNjaQVnn3fZZu PsmYbGYMxHqvqXXvCyfqQ74RwbVC9hL2DY/yqMMIajkQ0+Iiej18+M7xJI9ZsZoFvYwK f5bugkaei4hZsC72N0Dnrii5z/QdLRBwymjmkfUaYjTomEfwRl3TZU1qFwEMekO0vSi0 WbsaBx9KhF3FLQ4W8Vg5A+oRN+uFBSoiFTkr8A9jKV0/je8SlxY6d2N39ZUlqAVTmmeJ RLkcZjAHgmunQ2M6CXgtWXZ9rqJXmIs21n7WzEOgQF3a2ne3AJRbVFwVDeEZDmdAC89D ygAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785922677; x=1786527477; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bMILTWQ3u1gjsljNym/1x+Kl/G5TJKj09mRXvfx+800=; b=ULjFnLJy+zhgUfincrVWTT/mhbEERa84RrCFw+g1VKRsavpWloQEC68OFjiCdiSGKU NnmOvO7dySCmWl5BI4Gaip8z+LpePP7fOdhCpMKVm0tgialiyFrmCVvM5hXQ2x1tZ225 6erYIZcb+ps58A/ihD8MoXZoYddth2J8lFui1NdGolg6Y7QPO70CJBKaDgJllqvDquO5 Nnv5frzzGsDASGZLIbu4gf6x+5qKeGtujQw+DwvD/JeKHK3/VRcsnx4TyQ8447rkkZPO VXIlylILlyRPBNwmFll6szjqFBjrC751QBO+j14MX/f9UI+NIPh3JFy8JOT+4fQJzS1c VpLg== X-Forwarded-Encrypted: i=1; AHgh+Rq2cexP0I7m6kbsxK4c1LD0zrefMQgWIXV610O9Z5z0y5lRI2Ir7fXLzgt6IfGAOdlAOipFVYGXzeHHZeA=@vger.kernel.org X-Gm-Message-State: AOJu0YwTRudyk0IyY0zqJwVENMaKYd0BYh9mGXhDpVe35jZ1ESUWWynm fh2+gFkr0an+ul4GflFXUeoKIT0ochZ99X4Rm+PNscarfjDdbvKFf0cYmd9tfgCSMB7Uxvavapp y0gsR2Pv5wun0LxCegBfJSoIFuV11XqcNG8ZgiSGZ+naRV6twAkJvtkTHOrM83l8vjU7k0V4mud E= X-Gm-Gg: AR+sD1123twJ+oeVQVLVW9BMbKNBzhuH5ohEUQTdgWFefu9EQ+QHr0fIviLVERTqGwd kGQg2mncUbA/seC7OdAJ+vNh2Fbb0lABKqNbXpy2N7ncixF0pj0BJq+xy8/mN240TM919mwJtyy Vj1SKsKgRwjnv8TG/8uieG+nZJ78kpQJxUkNblsYJmoukeo21S2QJh6Ma7b2QMI3NLcgg4xpaXl TL5/6abEGu+knA2cj19zOpky3f5pZtz9X3brK4mtNtbp61VJeUcvKdUMuW6ZnVlRBU2f6LJf1ty d1xSni2d/YaJZltDsHCIiHTD3ehQwnI8VYtu/9XN/iKUMm6VJJn+UBMFxi0tyER8kSqbmXnblGe CatLrDjlHG1WdkX3gTUmBXExfpOXX2sk= X-Received: by 2002:a17:90b:2d84:b0:38f:18f9:785 with SMTP id 98e67ed59e1d1-3903c538263mr5524738a91.8.1785922676962; Wed, 05 Aug 2026 02:37:56 -0700 (PDT) X-Received: by 2002:a17:90b:2d84:b0:38f:18f9:785 with SMTP id 98e67ed59e1d1-3903c538263mr5524717a91.8.1785922676489; Wed, 05 Aug 2026 02:37:56 -0700 (PDT) Received: from [10.218.14.97] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3903917a5d0sm2756152a91.6.2026.08.05.02.37.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 02:37:56 -0700 (PDT) Message-ID: <19104992-25ba-42bc-a7b9-c45f4b57c22f@oss.qualcomm.com> Date: Wed, 5 Aug 2026 15:07:51 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] i2c: qcom-geni: Simplify PM resume error handling To: Mukesh Kumar Savaliya , andi.shyti@kernel.org, linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, viken.dadhaniya@oss.qualcomm.com References: <20260805070013.494426-1-mukesh.savaliya@oss.qualcomm.com> Content-Language: en-US From: Praveen Talari In-Reply-To: <20260805070013.494426-1-mukesh.savaliya@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA1MDA3NiBTYWx0ZWRfX6//C2xH73CeA f6S9oPy1YIKWY/WpU8TcniYAhFipdUMvXhFFiylwC50v+0r+qTBkLnNLcQYHuGP5KQkzTlq0+93 5UbKLfQrNokMyEPILcUzdm9yl0njGxGRMv001TQk9K+P1OiYYj5A8Wttt+wUf1qw1T33S0lh22s Ie1AAQUNuR6BsLA0aKekygvU0RfsNMPidgc6ytQkl49h6eVixIOjhHWq4oEmtct5PE4q7RjtL7y Mxbn4qWV/7uGxE9//cl10JDEY2DcDs4Wt0vij/xea7LJVrnSKp9VcEJT3IWOIZJHA2I+20YQ1Pz Au+BbSIaNpiQx3tKlhQ5ZmBEs5clT1mDrxFeYdo7Na7iMJ6djCwejwFE2Qjn2NEbvDKZj3Kl9EQ XA2o3GcXmrBkVsu1dsrTu7D9G+LcKxtyijRjvs5waNyo1kTKPiiuYXOIPdmlSPHmCCeXsXWGexJ 3zS6Jm5tY3Th4a+W18w== X-Proofpoint-Spam-Info: AW1haW4tMjYwODA1MDA3NiBTYWx0ZWRfX4mrlqU5qN+Lu ul06tehb8hgEScmg4GQbWInLt3DQbigfyAXW/85f0RulqDe3QJk8pmbwGKAeqjrvmLynGSHboag dlUfCenCdWAnkzOgBqd5Q0G6D0fiNtY= X-Proofpoint-GUID: TFoCAJKRpZ9JszgfoMi0xj44NUZTFD_2 X-Proofpoint-ORIG-GUID: TFoCAJKRpZ9JszgfoMi0xj44NUZTFD_2 X-Authority-Analysis: v=2.4 cv=GL441ONK c=1 sm=1 tr=0 ts=6a730475 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=6z8TwaGRFWoLiM2ZyNYA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-05_03,2026-08-04_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 spamscore=0 malwarescore=0 clxscore=1015 bulkscore=0 adultscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608050076 Hi Mukesh On 05-08-2026 12:30, Mukesh Kumar Savaliya wrote: > The driver currently logs pm_runtime_resume_and_get() failures with > dev_err() and returns the error code separately. > > Replace this with dev_err_probe(), which combines the dev_err() log > message and the return value propagation into a single call, consistent > with how all other error paths in this driver already report failures. > > No functional change intended. > > Signed-off-by: Mukesh Kumar Savaliya > --- > drivers/i2c/busses/i2c-qcom-geni.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c > index d5c977e34994..96015e077b69 100644 > --- a/drivers/i2c/busses/i2c-qcom-geni.c > +++ b/drivers/i2c/busses/i2c-qcom-geni.c > @@ -994,10 +994,8 @@ static int geni_i2c_init(struct geni_i2c_dev *gi2c) > int ret; > > ret = pm_runtime_resume_and_get(gi2c->se.dev); > - if (ret < 0) { > - dev_err(gi2c->se.dev, "error turning on device :%d\n", ret); > - return ret; > - } > + if (ret < 0) > + return dev_err_probe(gi2c->se.dev, ret, "error turning on device\n"); This change is not required, as this API will be used in the deep sleep use case to reinitialise the SE. Thanks, Praveen Talari > > proto = geni_se_read_proto(&gi2c->se); > if (proto == GENI_SE_INVALID_PROTO) {