From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF6EC22FAE1 for ; Fri, 25 Apr 2025 07:43:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745567021; cv=none; b=tB1mNYOjmXvdxjQpx5NfvYcB8dUFkBAtQgeQsum5EvI3Opx5IoqbWKn50WOoMdKpigIMPnitG4ZZVi+GqQA0gnyhuqIM9fc4FwMC7VI1ByWcj6QKGdmXS6IbikLDgSnpejaj8laFA29PhpdnujYedVkiojYckyHxEv9SSUB/abE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745567021; c=relaxed/simple; bh=RF5u3Cq87TwOLFsWHm1vkwgz2dI6PKr2yr8ARHyhbvo=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=dBCTlc+sYg+mj3WGlBBUyVz7aoRZPCNepOjiJmPlUwp4o7A2zpGjLn7k1Tv2Ew9fMBjbtrKyJIn581f/1XiYiStwvkkvJWZMt8gt1jBQcvpEwImnBV0UCA5mHvHbLoU7Hv0yHb72KrfQV8MBIgxK4HMO92AeZ0vs/WZoQck8C4k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yYCqmALy; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yYCqmALy" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-39c14016868so1769077f8f.1 for ; Fri, 25 Apr 2025 00:43:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745567016; x=1746171816; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=MNoMaPgin2LuROKeFezNhJvJ6HVFqpURRsX+Xtl9BkQ=; b=yYCqmALyl8YIGHedDPVXegCE0+KYS/BL2EntOWSgLhUXAHj16fst6k3cV5/+HamYvo 8Q72G42E2HO84mXj7yHnfhX+lmegVYnwqTqQv9wqv8N+ZJj4uU7xQBsero8VvK1v5cM9 X6wb/jKmp6YnDk+gWBxRnDvDdPiu92+1O3o5mTStALORkL+m2D9zcMx34OsJh2R8ZxnN LPK/lctsMgJlX458XhA8dQLSsFW3d1jm6x3zMH3w1ouGBSmOfJcKWsRlIbV5kpw0eNis GaFFLLkKVZqsrRbeaaTkH9z6b3ievCBTkDo2U1KxHov60etyV3G5PpL69Cw7HHLaDBCo VPfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745567016; x=1746171816; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=MNoMaPgin2LuROKeFezNhJvJ6HVFqpURRsX+Xtl9BkQ=; b=ecAkED21WKd+aYTTITaAsvYiizveV81TcTZvGIeQnoOmLch1PKNGZk7qWQhLN2m08m zR/4TABxOCpKBidJCGpdFLFc7hAdzcbNJFL8gFWgojmYUU5nkqYKw92MQep/dwemwB27 Nh/McqUdR6y0ZBhcydAl1n+OHNbTRSI5uNW1S2GCCiMBzf3myFj/kx2bTFD3VwCF/ydg Dxf9QRhBAdCUfAMN5nV4OaOjOnWcK+pXzPOYWtKxNwtYVKnLPgig/5OzVUr3+/gXi0vX pLl/5A5O/Dc5X4gSsq6f6X8+Rb+i3katynHFsxUCnDpk1CEPJ1AKNSm5cOKAXULUTtIm Ewcw== X-Forwarded-Encrypted: i=1; AJvYcCXownN8ozWpJyKA9kO+u5N8B0qPiveB0PYhL16MHf7/Pzgnd9His2HGbmcKQM3MaSkygIrB8OZz++iWR4U=@vger.kernel.org X-Gm-Message-State: AOJu0YxCTRCYe7OdcdNTlBiPWaY3Vtvg/cuhx2l4YbpUBenkdKjIeznX USYUMzopI8/efmn8umJb8UHrBgYtyj7GbkUQEb5m15FqcPSanHMqa51lfEGzBNc= X-Gm-Gg: ASbGncvLJDXHBTjk4iUzRBkThwHyEitcRsNE4I7CydnsX8WAbzT/0I0lEr48GhaMtob 4qzV12Rcw7CmGyKmK9U1gSK+f83kwyzv4g/RxKSRGVriwJPAa4dAW7NG6cwofGPy2YOkc1Fw6QA TRlRvdRBVXt8PNMcDMdMLwFSegY79Hsly6cBsWwSpVceGE4EvVBrnQkMjPqSFfczXOczQS7sFNY QXG0uFY5pEpORH0XUjQoFxJCnv9SYrE5oD3nLrrmWy9DF/pgljsnPLC4x7zCpILsNxrjGjgA1Jh PSih5jhihUYREMyhxeW3kNkrSr9lUdsXcP3DiOVI4poM8V3glq88xInFEfzOg0qrsbYBbsT5FuZ 5r+UxV2PFs7RQJac= X-Google-Smtp-Source: AGHT+IEYDEnK+DppRMpM3j2SrK7PqFBY4X+h7RhUtwLKjrkFwJJED2Z4WquFPdid/2YU/O9dpPGueA== X-Received: by 2002:a05:6000:1786:b0:391:2d61:4561 with SMTP id ffacd0b85a97d-3a074e14820mr857047f8f.6.1745567015914; Fri, 25 Apr 2025 00:43:35 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:d16:61ed:6880:1168? ([2a01:e0a:3d9:2080:d16:61ed:6880:1168]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073c9ba61sm1567902f8f.9.2025.04.25.00.43.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Apr 2025 00:43:35 -0700 (PDT) Message-ID: <191491fa-2c4c-4aa1-b0e8-7750532460a0@linaro.org> Date: Fri, 25 Apr 2025 09:43:34 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v5 5/8] scsi: ufs: core: Enable multi-level gear scaling To: Ziqi Chen , quic_cang@quicinc.com, bvanassche@acm.org, mani@kernel.org, beanhuo@micron.com, avri.altman@wdc.com, junwoo80.lee@samsung.com, martin.petersen@oracle.com, quic_nguyenb@quicinc.com, quic_nitirawa@quicinc.com, peter.wang@mediatek.com, quic_rampraka@quicinc.com Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, Alim Akhtar , "James E.J. Bottomley" , Manivannan Sadhasivam , Andrew Halaney , open list , Linux regressions mailing list References: <20250213080008.2984807-1-quic_ziqichen@quicinc.com> <20250213080008.2984807-6-quic_ziqichen@quicinc.com> <0155bd45-4c57-44d5-8b0c-852003aef5e0@quicinc.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <0155bd45-4c57-44d5-8b0c-852003aef5e0@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 25/04/2025 09:29, Ziqi Chen wrote: > Hi Neil, > > We analyzed this issue today , I don't think it is related to this patch: The bisect point to the patch where the issue appears, it may be another one of this patchset. > > [    9.383728] ufshcd-qcom 1d84000.ufshc: pwr ctrl cmd 0x2 with mode 0x11 completion timeout > ... > ... > ... > [    9.588545] host_regs: 00000090: 00000002 15710000 00000002 00000003 > > The timeout error log shows the mode 0x11 is the correct argument3 value of this pwr mode DME_SET cmd. > > int ufshcd_uic_change_pwr_mode(struct ufs_hba *hba, u8 mode) > { >     struct uic_command uic_cmd = { >         .command = UIC_CMD_DME_SET, >         .argument1 = UIC_ARG_MIB(PA_PWRMODE), >         .argument3 = mode, >     }; > ... > ... >  dev_err(hba->dev, >         "uic cmd 0x%x with arg3 0x%x completion timeout\n", >          uic_cmd->command, uic_cmd->argument3); > > > This prints means that we gave correct argument3 here. > > But from the host register dump , we can see the argument3 written to register (address 0x***9C) is '0x00000003' which is a invalid value. > > And according to the UFSHCI JEDEC, the return value of ConfigResultCode regiser (address 0x***0x98) is 0x00000002 also told us the value written to argument3 register is a INVALID_MIB_ATTRIBUTE_VALUE, this is the reason causes this timeout issue. > > " 02h INVALID_MIB_ATTRIBUTE_VALUE " > > However, though we don't know the final root cause, we can know there is mistake occur during writing register. The argument3 value is 0x11, but after writing to register , the readback value from register is 0x3... Anyway , this patch didn't touch the path of register writing. > > Are you easy to reproduce this issue ? How many instances do you observed ? We never received similar report from our internal UFS test team and stabitily test team. If it is easy to reproduce , you can add readback prints at the place where after writing register to check it. The issue is easy to reproduce, just boot the rb3gen2 with vanilla v6.15-rc1 and default defconfig. > > ufshcd_dispatch_uic_cmd(struct ufs_hba *hba, struct uic_command *uic_cmd) > { >     lockdep_assert_held(&hba->uic_cmd_mutex); > >     WARN_ON(hba->active_uic_cmd); > >     hba->active_uic_cmd = uic_cmd; > >     /* Write Args */ >     ufshcd_writel(hba, uic_cmd->argument1, REG_UIC_COMMAND_ARG_1); >     ufshcd_writel(hba, uic_cmd->argument2, REG_UIC_COMMAND_ARG_2); >     ufshcd_writel(hba, uic_cmd->argument3, REG_UIC_COMMAND_ARG_3); > > -> you can add print here: >   pr_err ("READ BACK argument3 from register 0x%x: 0x%x", >       REG_UIC_COMMAND_ARG_3, ufshcd_readl(hba, REG_UIC_COMMAND_ARG_3); I've run the kernel with: =====================><================================= diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index 0534390c2a35..232328ff6365 100644 --- a/drivers/ufs/core/ufshcd.c +++ b/drivers/ufs/core/ufshcd.c @@ -2494,6 +2494,14 @@ ufshcd_dispatch_uic_cmd(struct ufs_hba *hba, struct uic_command *uic_cmd) ufshcd_writel(hba, uic_cmd->argument2, REG_UIC_COMMAND_ARG_2); ufshcd_writel(hba, uic_cmd->argument3, REG_UIC_COMMAND_ARG_3); + { + uint32_t reg3 = ufshcd_readl(hba, REG_UIC_COMMAND_ARG_3); + + if (reg3 != uic_cmd->argument3) + pr_err("different READ BACK argument3 from register 0x% != 0x%x", + uic_cmd->argument3, reg3); + } + ufshcd_add_uic_command_trace(hba, uic_cmd, UFS_CMD_SEND); /* Write UIC Cmd */ =====================><================================= And this print never appears. But the log clearly shows the kernel tries to scale back from gear1 to gear4: >> [ 10.538102] ufshcd-qcom 1d84000.ufshc: ufshcd_scale_gear: failed err -110, old gear: (tx 1 rx 1), new gear: (tx 4 rx 4) did you validate the gear scaling on the sc7280 with the mainline UFS & PHY drivers ? Neil > > > > Best Regards, > Ziqi > > On 4/24/2025 11:35 PM, Neil Armstrong wrote: >> Hi, >> >> On 13/02/2025 09:00, Ziqi Chen wrote: >>> From: Can Guo >>> >>> With OPP V2 enabled, devfreq can scale clocks amongst multiple frequency >>> plans. However, the gear speed is only toggled between min and max during >>> clock scaling. Enable multi-level gear scaling by mapping clock frequencies >>> to gear speeds, so that when devfreq scales clock frequencies we can put >>> the UFS link at the appropriate gear speeds accordingly. >>> >>> Signed-off-by: Can Guo >>> Co-developed-by: Ziqi Chen >>> Signed-off-by: Ziqi Chen >>> Reviewed-by: Bean Huo >>> Reviewed-by: Bart Van Assche >>> Tested-by: Neil Armstrong >>> --- >>> >>> v1 -> v2: >>> Rename the lable "do_pmc" to "config_pwr_mode". >>> >>> v2 -> v3: >>> Use assignment instead memcpy() in function ufshcd_scale_gear(). >>> >>> v3 -> v4: >>> Typo fixed for commit message. >>> >>> v4 -> v5: >>> Change the data type of "new_gear" from 'int' to 'u32'. >>> --- >>>   drivers/ufs/core/ufshcd.c | 44 ++++++++++++++++++++++++++++++--------- >>>   1 file changed, 34 insertions(+), 10 deletions(-) >>> >>> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c >>> index 8d295cc827cc..9908c0d6a1e1 100644 >>> --- a/drivers/ufs/core/ufshcd.c >>> +++ b/drivers/ufs/core/ufshcd.c >>> @@ -1308,16 +1308,26 @@ static int ufshcd_wait_for_doorbell_clr(struct ufs_hba *hba, >>>   /** >>>    * ufshcd_scale_gear - scale up/down UFS gear >>>    * @hba: per adapter instance >>> + * @target_gear: target gear to scale to >>>    * @scale_up: True for scaling up gear and false for scaling down >>>    * >>>    * Return: 0 for success; -EBUSY if scaling can't happen at this time; >>>    * non-zero for any other errors. >>>    */ >>> -static int ufshcd_scale_gear(struct ufs_hba *hba, bool scale_up) >>> +static int ufshcd_scale_gear(struct ufs_hba *hba, u32 target_gear, bool scale_up) >>>   { >>>       int ret = 0; >>>       struct ufs_pa_layer_attr new_pwr_info; >>> +    if (target_gear) { >>> +        new_pwr_info = hba->pwr_info; >>> +        new_pwr_info.gear_tx = target_gear; >>> +        new_pwr_info.gear_rx = target_gear; >>> + >>> +        goto config_pwr_mode; >>> +    } >>> + >>> +    /* Legacy gear scaling, in case vops_freq_to_gear_speed() is not implemented */ >>>       if (scale_up) { >>>           memcpy(&new_pwr_info, &hba->clk_scaling.saved_pwr_info, >>>                  sizeof(struct ufs_pa_layer_attr)); >>> @@ -1338,6 +1348,7 @@ static int ufshcd_scale_gear(struct ufs_hba *hba, bool scale_up) >>>           } >>>       } >>> +config_pwr_mode: >>>       /* check if the power mode needs to be changed or not? */ >>>       ret = ufshcd_config_pwr_mode(hba, &new_pwr_info); >>>       if (ret) >>> @@ -1408,15 +1419,19 @@ static void ufshcd_clock_scaling_unprepare(struct ufs_hba *hba, int err, bool sc >>>   static int ufshcd_devfreq_scale(struct ufs_hba *hba, unsigned long freq, >>>                   bool scale_up) >>>   { >>> +    u32 old_gear = hba->pwr_info.gear_rx; >>> +    u32 new_gear = 0; >>>       int ret = 0; >>> +    new_gear = ufshcd_vops_freq_to_gear_speed(hba, freq); >>> + >>>       ret = ufshcd_clock_scaling_prepare(hba, 1 * USEC_PER_SEC); >>>       if (ret) >>>           return ret; >>>       /* scale down the gear before scaling down clocks */ >>>       if (!scale_up) { >>> -        ret = ufshcd_scale_gear(hba, false); >>> +        ret = ufshcd_scale_gear(hba, new_gear, false); >>>           if (ret) >>>               goto out_unprepare; >>>       } >>> @@ -1424,13 +1439,13 @@ static int ufshcd_devfreq_scale(struct ufs_hba *hba, unsigned long freq, >>>       ret = ufshcd_scale_clks(hba, freq, scale_up); >>>       if (ret) { >>>           if (!scale_up) >>> -            ufshcd_scale_gear(hba, true); >>> +            ufshcd_scale_gear(hba, old_gear, true); >>>           goto out_unprepare; >>>       } >>>       /* scale up the gear after scaling up clocks */ >>>       if (scale_up) { >>> -        ret = ufshcd_scale_gear(hba, true); >>> +        ret = ufshcd_scale_gear(hba, new_gear, true); >>>           if (ret) { >>>               ufshcd_scale_clks(hba, hba->devfreq->previous_freq, >>>                         false); >>> @@ -1723,6 +1738,8 @@ static ssize_t ufshcd_clkscale_enable_store(struct device *dev, >>>           struct device_attribute *attr, const char *buf, size_t count) >>>   { >>>       struct ufs_hba *hba = dev_get_drvdata(dev); >>> +    struct ufs_clk_info *clki; >>> +    unsigned long freq; >>>       u32 value; >>>       int err = 0; >>> @@ -1746,14 +1763,21 @@ static ssize_t ufshcd_clkscale_enable_store(struct device *dev, >>>       if (value) { >>>           ufshcd_resume_clkscaling(hba); >>> -    } else { >>> -        ufshcd_suspend_clkscaling(hba); >>> -        err = ufshcd_devfreq_scale(hba, ULONG_MAX, true); >>> -        if (err) >>> -            dev_err(hba->dev, "%s: failed to scale clocks up %d\n", >>> -                    __func__, err); >>> +        goto out_rel; >>>       } >>> +    clki = list_first_entry(&hba->clk_list_head, struct ufs_clk_info, list); >>> +    freq = clki->max_freq; >>> + >>> +    ufshcd_suspend_clkscaling(hba); >>> +    err = ufshcd_devfreq_scale(hba, freq, true); >>> +    if (err) >>> +        dev_err(hba->dev, "%s: failed to scale clocks up %d\n", >>> +                __func__, err); >>> +    else >>> +        hba->clk_scaling.target_freq = freq; >>> + >>> +out_rel: >>>       ufshcd_release(hba); >>>       ufshcd_rpm_put_sync(hba); >>>   out: >> >> This change causes UFS crash on the RB3gen2, after UFS successfully probe and scan: >> >> [    9.383728] ufshcd-qcom 1d84000.ufshc: pwr ctrl cmd 0x2 with mode 0x11 completion timeout >> [    9.393272] ufshcd-qcom 1d84000.ufshc: UFS Host state=1 >> [    9.403126] msm_dpu ae01000.display-controller: [drm:adreno_request_fw [msm]] *ERROR* failed to load a660_sqe.fw >> [    9.408484] ufshcd-qcom 1d84000.ufshc: 0 outstanding reqs, tasks=0x0 >> [    9.425577] ufshcd-qcom 1d84000.ufshc: saved_err=0x0, saved_uic_err=0x0 >> [    9.432433] ufshcd-qcom 1d84000.ufshc: Device power mode=1, UIC link state=1 >> [    9.439716] ufshcd-qcom 1d84000.ufshc: PM in progress=0, sys. suspended=0 >> [    9.446742] ufshcd-qcom 1d84000.ufshc: Auto BKOPS=0, Host self-block=0 >> [    9.453468] ufshcd-qcom 1d84000.ufshc: Clk gate=1 >> ... >> [   10.529259] ufshcd-qcom 1d84000.ufshc: ufshcd_change_power_mode: power mode change failed -110 >> [   10.538102] ufshcd-qcom 1d84000.ufshc: ufshcd_scale_gear: failed err -110, old gear: (tx 1 rx 1), new gear: (tx 4 rx 4) >> [   10.542841] WARNING: CPU: 0 PID: 274 at drivers/ufs/core/ ufshcd.c:5504 ufshcd_sl_intr+0x64c/0x6a4 >> ... >> >> CI Run sample: https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba- tester/-/jobs/233352#L1479 >> >> Bisect run log: >> # bad: [0af2f6be1b4281385b618cb86ad946eded089ac8] Linux 6.15-rc1 >> # good: [38fec10eb60d687e30c8c6b5420d86e8149f7557] Linux 6.14 >> git bisect start 'v6.15-rc1' 'v6.14' >> # bad: [fd71def6d9abc5ae362fb9995d46049b7b0ed391] Merge tag 'for-6.15- tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux >> git bisect bad fd71def6d9abc5ae362fb9995d46049b7b0ed391 >> # good: [fb1ceb29b27cda91af35851ebab01f298d82162e] Merge tag 'platform- drivers-x86-v6.15-1' of git://git.kernel.org/pub/scm/linux/kernel/git/ pdx86/platform-drivers-x86 >> git bisect good fb1ceb29b27cda91af35851ebab01f298d82162e >> # good: [1952e19c02ae8ea0c663d30b19be14344b543068] Merge tag 'wireless- next-2025-03-20' of https://git.kernel.org/pub/scm/linux/kernel/git/ wireless/wireless-next >> git bisect good 1952e19c02ae8ea0c663d30b19be14344b543068 >> # bad: [1a9239bb4253f9076b5b4b2a1a4e8d7defd77a95] Merge tag 'net- next-6.15' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next >> git bisect bad 1a9239bb4253f9076b5b4b2a1a4e8d7defd77a95 >> # good: [22093997ac9220d3c606313efbf4ce564962d095] Merge tag 'ata-6.15- rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/libata/linux >> git bisect good 22093997ac9220d3c606313efbf4ce564962d095 >> # bad: [336b4dae6dfecc9aa53a3a68c71b9c1c1d466388] Merge tag 'iommu- updates-v6.15' of git://git.kernel.org/pub/scm/linux/kernel/git/iommu/linux >> git bisect bad 336b4dae6dfecc9aa53a3a68c71b9c1c1d466388 >> # bad: [0711f1966a523d77d4c5f00776a7bd073d56251a] scsi: mpt3sas: Fix buffer overflow in mpt3sas_send_mctp_passthru_req() >> git bisect bad 0711f1966a523d77d4c5f00776a7bd073d56251a >> # good: [369552fd03f296261023872b8fc983d1fc55c8e9] Merge patch series "mpt3sas driver udpates" >> git bisect good 369552fd03f296261023872b8fc983d1fc55c8e9 >> # bad: [42273e893157501ae119ea5459f3a7d2420c56d6] Merge patch series "scsi: scsi_debug: Add more tape support" >> git bisect bad 42273e893157501ae119ea5459f3a7d2420c56d6 >> # bad: [7e72900272b61c11f2fd4020d4f186124d0d171b] Merge patch series "Support Multi-frequency scale for UFS" >> git bisect bad 7e72900272b61c11f2fd4020d4f186124d0d171b >> # good: [c02fe9e222d16bed8c270608c42f77bc62562ac3] scsi: ufs: qcom: Implement the freq_to_gear_speed() vop >> git bisect good c02fe9e222d16bed8c270608c42f77bc62562ac3 >> # bad: [eff26ad4c34fc78303c14be749e10ca61c4d211f] scsi: ufs: core: Check if scaling up is required when disable clkscale >> git bisect bad eff26ad4c34fc78303c14be749e10ca61c4d211f >> # bad: [129b44c27c8a51cb74b2f68fde57f2a2e7f5696b] scsi: ufs: core: Enable multi-level gear scaling >> git bisect bad 129b44c27c8a51cb74b2f68fde57f2a2e7f5696b >> # first bad commit: [129b44c27c8a51cb74b2f68fde57f2a2e7f5696b] scsi: ufs: core: Enable multi-level gear scaling >> >> #regzbot introduced 129b44c27c8a51cb74b2f68fde57f2a2e7f5696b >> >> Thanks, >> Neil >> >