From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
"Shuah Khan" <shuah@kernel.org>
Cc: usama.anjum@collabora.com, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] selftests/timens: Print TAP headers
Date: Fri, 2 May 2025 17:13:42 +0500 [thread overview]
Message-ID: <19160409-948f-4ae6-894a-6cfefcef4d4c@collabora.com> (raw)
In-Reply-To: <20250502-selftests-timens-fixes-v1-1-fb517c76f04d@linutronix.de>
On 5/2/25 5:03 PM, Thomas Weißschuh wrote:
> The TAP specification requires that the output begins with a header line.
> These headers lines are missing in the timens tests.
>
> Print such a line.
>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> tools/testing/selftests/timens/clock_nanosleep.c | 2 ++
> tools/testing/selftests/timens/exec.c | 2 ++
> tools/testing/selftests/timens/futex.c | 2 ++
> tools/testing/selftests/timens/gettime_perf.c | 2 ++
> tools/testing/selftests/timens/procfs.c | 2 ++
> tools/testing/selftests/timens/timens.c | 2 ++
> tools/testing/selftests/timens/timer.c | 2 ++
> tools/testing/selftests/timens/timerfd.c | 2 ++
> tools/testing/selftests/timens/vfork_exec.c | 2 ++
> 9 files changed, 18 insertions(+)
>
> diff --git a/tools/testing/selftests/timens/clock_nanosleep.c b/tools/testing/selftests/timens/clock_nanosleep.c
> index 72d41b955fb2263ae74c34b446fb322d1bd50c6a..346bff3d128dfa8c8c743cc2eba74917994bb2f7 100644
> --- a/tools/testing/selftests/timens/clock_nanosleep.c
> +++ b/tools/testing/selftests/timens/clock_nanosleep.c
> @@ -115,6 +115,8 @@ int main(int argc, char *argv[])
> {
> int ret, nsfd;
>
> + ksft_print_header();
> +
> nscheck();
>
> ksft_set_plan(4);
> diff --git a/tools/testing/selftests/timens/exec.c b/tools/testing/selftests/timens/exec.c
> index d12ff955de0d8f6665fa957e81438e373af9f92c..a644162d56fdc86827b83a45f83c2597c253aa6a 100644
> --- a/tools/testing/selftests/timens/exec.c
> +++ b/tools/testing/selftests/timens/exec.c
> @@ -36,6 +36,8 @@ int main(int argc, char *argv[])
> return 0;
> }
>
> + ksft_print_header();
> +
> nscheck();
>
> ksft_set_plan(1);
> diff --git a/tools/testing/selftests/timens/futex.c b/tools/testing/selftests/timens/futex.c
> index 6b2b9264e851caed06a628589eda0bf81ff33f16..339633ae037a74d2026ca835ac8600cd0394ae01 100644
> --- a/tools/testing/selftests/timens/futex.c
> +++ b/tools/testing/selftests/timens/futex.c
> @@ -66,6 +66,8 @@ int main(int argc, char *argv[])
> pid_t pid;
> struct timespec mtime_now;
>
> + ksft_print_header();
> +
> nscheck();
>
> ksft_set_plan(2);
> diff --git a/tools/testing/selftests/timens/gettime_perf.c b/tools/testing/selftests/timens/gettime_perf.c
> index 6b13dc277724126a9d2d5e17c805217760df72ad..d6658b7b754877fbf67237d6c22787a2a89066ce 100644
> --- a/tools/testing/selftests/timens/gettime_perf.c
> +++ b/tools/testing/selftests/timens/gettime_perf.c
> @@ -67,6 +67,8 @@ int main(int argc, char *argv[])
> time_t offset = 10;
> int nsfd;
>
> + ksft_print_header();
> +
> ksft_set_plan(8);
>
> fill_function_pointers();
> diff --git a/tools/testing/selftests/timens/procfs.c b/tools/testing/selftests/timens/procfs.c
> index 1833ca97eb247b1b45b7a86f0ca800d4a6e58c74..0a9ff90ee69a9327ed905428f1462fa189ffd830 100644
> --- a/tools/testing/selftests/timens/procfs.c
> +++ b/tools/testing/selftests/timens/procfs.c
> @@ -180,6 +180,8 @@ int main(int argc, char *argv[])
> {
> int ret = 0;
>
> + ksft_print_header();
> +
> nscheck();
>
> ksft_set_plan(2);
> diff --git a/tools/testing/selftests/timens/timens.c b/tools/testing/selftests/timens/timens.c
> index 387220791a052e6013bd0fb4162f123d85152183..a9c0534ef8f67184c34882ae163472c179f593e4 100644
> --- a/tools/testing/selftests/timens/timens.c
> +++ b/tools/testing/selftests/timens/timens.c
> @@ -151,6 +151,8 @@ int main(int argc, char *argv[])
> time_t offset;
> int ret = 0;
>
> + ksft_print_header();
> +
> nscheck();
>
> check_supported_timers();
> diff --git a/tools/testing/selftests/timens/timer.c b/tools/testing/selftests/timens/timer.c
> index 5b939f59dfa4d64e4c2e4dc8eb6a644d44211f13..51babe63e233bdaaef35c1cafbcb5b5cc91c021e 100644
> --- a/tools/testing/selftests/timens/timer.c
> +++ b/tools/testing/selftests/timens/timer.c
> @@ -75,6 +75,8 @@ int main(int argc, char *argv[])
> pid_t pid;
> struct timespec btime_now, mtime_now;
>
> + ksft_print_header();
> +
> nscheck();
>
> check_supported_timers();
> diff --git a/tools/testing/selftests/timens/timerfd.c b/tools/testing/selftests/timens/timerfd.c
> index a4196bbd6e33f41b6a3ae346070037aff1cf4087..e58bc8b64ce2738dccb8c2a2c88e592c237b55d5 100644
> --- a/tools/testing/selftests/timens/timerfd.c
> +++ b/tools/testing/selftests/timens/timerfd.c
> @@ -82,6 +82,8 @@ int main(int argc, char *argv[])
> pid_t pid;
> struct timespec btime_now, mtime_now;
>
> + ksft_print_header();
> +
> nscheck();
>
> check_supported_timers();
> diff --git a/tools/testing/selftests/timens/vfork_exec.c b/tools/testing/selftests/timens/vfork_exec.c
> index 5b8907bf451dde3f3e2699f87797c155b9115aab..b957e1a651243adde41ec5cd57bbd12a7cac9eeb 100644
> --- a/tools/testing/selftests/timens/vfork_exec.c
> +++ b/tools/testing/selftests/timens/vfork_exec.c
> @@ -91,6 +91,8 @@ int main(int argc, char *argv[])
> return check("child after exec", &now);
> }
>
> + ksft_print_header();
> +
> nscheck();
>
> ksft_set_plan(4);
>
--
Regards,
Usama
next prev parent reply other threads:[~2025-05-02 12:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 12:03 [PATCH 0/3] selftests/timens: Various small fixes Thomas Weißschuh
2025-05-02 12:03 ` [PATCH 1/3] selftests/timens: Print TAP headers Thomas Weißschuh
2025-05-02 12:13 ` Muhammad Usama Anjum [this message]
2025-05-07 21:06 ` Shuah Khan
2025-05-09 15:41 ` Thomas Weißschuh
2025-05-09 18:53 ` Shuah Khan
2025-05-09 19:07 ` Kees Cook
2025-05-02 12:03 ` [PATCH 2/3] selftests/timens: Make run_tests() functions static Thomas Weißschuh
2025-05-02 12:13 ` Muhammad Usama Anjum
2025-05-02 12:03 ` [PATCH 3/3] selftests/timens: timerfd: Use correct clockid type in tclock_gettime() Thomas Weißschuh
2025-05-02 12:14 ` Muhammad Usama Anjum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19160409-948f-4ae6-894a-6cfefcef4d4c@collabora.com \
--to=usama.anjum@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®