From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753942AbZKBErT (ORCPT ); Sun, 1 Nov 2009 23:47:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753912AbZKBErS (ORCPT ); Sun, 1 Nov 2009 23:47:18 -0500 Received: from ozlabs.org ([203.10.76.45]:54925 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753825AbZKBErR (ORCPT ); Sun, 1 Nov 2009 23:47:17 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19182.22063.788927.708332@cargo.ozlabs.ibm.com> Date: Mon, 2 Nov 2009 14:46:55 +1100 From: Paul Mackerras To: Frederic Weisbecker Cc: Ingo Molnar , LKML , Arjan van de Ven , Arjan van de Ven , "K.Prasad" , Alan Stern , Arnaldo Carvalho de Melo , Steven Rostedt , Jan Kiszka , Jiri Slaby , Li Zefan , Avi Kivity , Mike Galbraith , Masami Hiramatsu , Paul Mundt , Jan Kiszka Subject: [PATCH 1/6] perf/core: Provide a kernel-internal interface to get to performance counters In-Reply-To: <1257109753-6464-2-git-send-email-fweisbec@gmail.com> References: <4AE55B1B.2030006@web.de> <1257109753-6464-2-git-send-email-fweisbec@gmail.com> X-Mailer: VM 8.0.12 under 22.2.1 (i486-pc-linux-gnu) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Frederic Weisbecker writes: > /* > + * perf_event_create_kernel_counter > + * MUST be called from a kernel thread. Why? The reason for this requirement isn't obvious to me. It would be good to have the reason documented in the comment for the sake of people modifying the code in future. Paul.