From: "Martin J. Bligh" <mbligh@aracnet.com>
To: Andrew Morton <akpm@digeo.com>, colpatch@us.ibm.com
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] (2.5.66-mm2) War on warnings
Date: Tue, 01 Apr 2003 07:22:37 -0800 [thread overview]
Message-ID: <19200000.1049210557@[10.10.2.4]> (raw)
drivers/base/node.c: In function `register_node_type':
drivers/base/node.c:96: warning: suggest parentheses around assignment used as truth value
drivers/base/memblk.c: In function `register_memblk_type':
drivers/base/memblk.c:54: warning: suggest parentheses around assignment used as truth value
Bah.
--- linux-2.5.66-mm2/drivers/base/node.c 2003-04-01 06:40:02.000000000 -0800
+++ 2.5.66-mm2/drivers/base/node.c 2003-04-01 06:37:32.000000000 -0800
@@ -93,7 +93,7 @@ int __init register_node_type(void)
{
int error;
if (!(error = devclass_register(&node_devclass)))
- if (error = driver_register(&node_driver))
+ if ((error = driver_register(&node_driver)))
devclass_unregister(&node_devclass);
return error;
}
--- linux-2.5.66-mm2/drivers/base/memblk.c 2003-04-01 06:40:02.000000000 -0800
+++ 2.5.66-mm2/drivers/base/memblk.c 2003-04-01 06:38:14.000000000 -0800
@@ -51,7 +51,7 @@ int __init register_memblk_type(void)
{
int error;
if (!(error = devclass_register(&memblk_devclass)))
- if (error = driver_register(&memblk_driver))
+ if ((error = driver_register(&memblk_driver)))
devclass_unregister(&memblk_devclass);
return error;
}
next reply other threads:[~2003-04-01 15:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-01 15:22 Martin J. Bligh [this message]
2003-04-01 15:27 ` Jeff Garzik
2003-04-01 16:13 ` Martin J. Bligh
2003-04-01 18:37 ` Matthew Dobson
2003-04-01 19:30 ` Matthew Dobson
2003-04-01 19:32 ` Matthew Dobson
2003-04-01 19:36 ` Martin J. Bligh
2003-04-01 16:14 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='19200000.1049210557@[10.10.2.4]' \
--to=mbligh@aracnet.com \
--cc=akpm@digeo.com \
--cc=colpatch@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®