From: Shuah Khan <skhan@linuxfoundation.org>
To: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Shuah Khan <shuah@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v5 0/2] selftests/resctrl: Print a message if the result of MBM&CMT tests is failed on Intel CPU
Date: Tue, 29 Mar 2022 09:37:17 -0600 [thread overview]
Message-ID: <1920a6b6-bc1b-31db-4c1b-efccc189daa5@linuxfoundation.org> (raw)
In-Reply-To: <20220323080928.1586408-1-tan.shaopeng@jp.fujitsu.com>
On 3/23/22 2:09 AM, Shaopeng Tan wrote:
> Hello,
>
> The aim of this series is to print a message to let users know a possible
> cause of failure, if the result of MBM&CMT tests is failed on Intel CPU.
> In order to detect Intel vendor, I extended AMD vendor detect function.
>
> Difference from v4:
> - Fixed the typos.
> - Changed "get_vendor() != ARCH_AMD" to "get_vendor() == ARCH_INTEL".
> - Reorder the declarations based on line length from longest to shortest.
> https://lore.kernel.org/lkml/20220316055940.292550-1-tan.shaopeng@jp.fujitsu.com/ [PATCH v4]
>
> This patch series is based on v5.17.
>
> Shaopeng Tan (2):
> selftests/resctrl: Extend CPU vendor detection
> selftests/resctrl: Print a message if the result of MBM&CMT tests is
> failed on Intel CPU
>
> tools/testing/selftests/resctrl/cat_test.c | 2 +-
> tools/testing/selftests/resctrl/resctrl.h | 5 ++-
> .../testing/selftests/resctrl/resctrl_tests.c | 45 +++++++++++++------
> tools/testing/selftests/resctrl/resctrlfs.c | 2 +-
> 4 files changed, 37 insertions(+), 17 deletions(-)
>
I can queue this up for Linux 5.18-rc2. Thanks for fixing the error
path with clear messages for failures.
thanks,
-- Shuah
next prev parent reply other threads:[~2022-03-29 15:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 8:09 Shaopeng Tan
2022-03-23 8:09 ` [PATCH v5 1/2] selftests/resctrl: Extend CPU vendor detection Shaopeng Tan
2022-03-28 18:38 ` Reinette Chatre
2022-03-29 15:34 ` Shuah Khan
2022-03-23 8:09 ` [PATCH v5 2/2] selftests/resctrl: Print a message if the result of MBM&CMT tests is failed on Intel CPU Shaopeng Tan
2022-03-29 15:34 ` Shuah Khan
2022-03-29 15:37 ` Shuah Khan [this message]
2022-04-25 21:19 ` [PATCH v5 0/2] " Reinette Chatre
2022-04-25 23:00 ` Shuah Khan
2022-04-25 23:20 ` Reinette Chatre
2022-04-26 10:09 ` tan.shaopeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1920a6b6-bc1b-31db-4c1b-efccc189daa5@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
--cc=tan.shaopeng@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®