From: Oliver Neukum <oneukum@suse.de>
To: Ming Lei <ming.lei@canonical.com>
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [RFC PATCH 3/3] USB: forbid memory allocation with I/O during bus reset if storage interface exits
Date: Mon, 15 Oct 2012 14:30:57 +0200 [thread overview]
Message-ID: <1921559.OPsFBnvatA@linux-lqwf.site> (raw)
In-Reply-To: <CACVXFVPi=fq1NP-nuWQi34xTpGgWbaceW1Hbzcq38RqQMF_T-w@mail.gmail.com>
On Monday 15 October 2012 20:06:36 Ming Lei wrote:
> On Mon, Oct 15, 2012 at 5:34 PM, Oliver Neukum <oneukum@suse.de> wrote:
> >
> > I think limiting this to devices which have a storage device is not
> > productive. What if you are using iSCSI or nbd? In the long run
>
> You mean other non-mass storage or non-uas usb interfaces may
> be involved in iSCSI or nbd? If not, the patch should be OK.
> If yes, could you list them?
All network devices?
> > we will see busses attached to busses and as soon as the daughter
> > bus is hotpluggable you are thwarted anyway. Just do it unconditionally.
>
> IMO, doing it unconditionally is not good because big chunk buffer
> is often allocated in probe() path.
It would be a chunk that has just been freed.
Regards
Oliver
next prev parent reply other threads:[~2012-10-15 12:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 5:14 [RFC PATCH 0/3] mm/PM/USB: force memory allocation with no io in need Ming Lei
2012-10-15 5:14 ` [RFC PATCH 1/3] mm: teach mm by current context info to not do I/O during memory allocation Ming Lei
2012-10-15 14:33 ` Alan Stern
2012-10-15 14:41 ` Ming Lei
2012-10-15 15:47 ` Minchan Kim
2012-10-16 1:56 ` Ming Lei
2012-10-16 5:49 ` Minchan Kim
2012-10-16 7:08 ` Ming Lei
2012-10-16 13:09 ` Minchan Kim
2012-10-16 13:47 ` Ming Lei
2012-10-16 13:53 ` Minchan Kim
2012-10-15 5:14 ` [RFC PATCH 2/3] PM / Runtime: force memory allocation with no I/O during runtime_resume callbcack Ming Lei
2012-10-15 14:14 ` Alan Stern
2012-10-15 14:35 ` Ming Lei
2012-10-15 5:14 ` [RFC PATCH 3/3] USB: forbid memory allocation with I/O during bus reset if storage interface exits Ming Lei
2012-10-15 9:34 ` Oliver Neukum
2012-10-15 12:06 ` Ming Lei
2012-10-15 12:30 ` Oliver Neukum [this message]
2012-10-15 13:21 ` Ming Lei
2012-10-15 16:04 ` Oliver Neukum
2012-10-15 16:48 ` Greg Kroah-Hartman
2012-10-16 7:41 ` Ming Lei
2012-10-15 16:48 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1921559.OPsFBnvatA@linux-lqwf.site \
--to=oneukum@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®