From: Daniel Almeida <daniel.almeida@collabora.com>
To: Danilo Krummrich <dakr@kernel.org>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v15 2/3] rust: io: mem: add a generic iomem abstraction
Date: Fri, 18 Jul 2025 09:23:26 -0300 [thread overview]
Message-ID: <19218014-4C48-4BE4-AE27-1DD309F8245F@collabora.com> (raw)
In-Reply-To: <DBEL719XP5CO.FKBDQ4QRZST0@kernel.org>
Hi Danilo,
> On 17 Jul 2025, at 16:45, Danilo Krummrich <dakr@kernel.org> wrote:
>
> On Thu Jul 17, 2025 at 5:55 PM CEST, Daniel Almeida wrote:
>> +impl<const SIZE: usize> IoMem<SIZE> {
>> + fn ioremap(resource: &Resource) -> Result<Self> {
>> + // Note: It looks like there aren't any 32-bit architectures that define
>> + // ioremap_np. This means that sometimes this conversion will fail. If
>> + // we performed a lossy cast, i.e., using `as`, then `bindings::ioremap`
>> + // would return NULL anyway.
>
> Why would ioremap() return NULL if you perform a lossy cast?
>
> Anyways, I find it a bit difficult to decode the actual problem from the above
> description.
>
> I feel it would be better to just explain that some ioremap() implementations
> use types that depend on the CPU word width rather than the bus address width.
>
> If you agree, no need to resend though, we can change it when applying the
> series.
>
>> + // TODO: Properly address this in the C code to avoid this `try_into`.
>> + let size = resource.size().try_into()?;
>> + if size == 0 {
>> + return Err(EINVAL);
>> + }
>
Ok, I do agree that what you said is better. Feel free to use it then.
— Daniel
next prev parent reply other threads:[~2025-07-18 12:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 15:55 [PATCH v15 0/3] rust: platform: add Io support Daniel Almeida
2025-07-17 15:55 ` [PATCH v15 1/3] rust: io: add resource abstraction Daniel Almeida
2025-07-17 15:55 ` [PATCH v15 2/3] rust: io: mem: add a generic iomem abstraction Daniel Almeida
2025-07-17 19:45 ` Danilo Krummrich
2025-07-18 12:23 ` Daniel Almeida [this message]
2025-07-19 13:51 ` Danilo Krummrich
2025-07-19 14:08 ` [PATCH] rust: io: mem: enable IoRequest doc-tests Danilo Krummrich
2025-07-20 17:47 ` Danilo Krummrich
2025-07-17 15:55 ` [PATCH v15 3/3] rust: platform: add resource accessors Daniel Almeida
2025-07-19 13:15 ` Danilo Krummrich
2025-07-19 16:19 ` Miguel Ojeda
2025-07-19 16:29 ` Miguel Ojeda
2025-07-19 8:01 ` [PATCH v15 0/3] rust: platform: add Io support Greg Kroah-Hartman
2025-07-19 10:16 ` Danilo Krummrich
2025-07-20 0:34 ` Daniel Almeida
2025-07-20 17:46 ` Danilo Krummrich
2025-07-23 7:35 ` Dirk Behme
2025-07-23 13:33 ` Daniel Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19218014-4C48-4BE4-AE27-1DD309F8245F@collabora.com \
--to=daniel.almeida@collabora.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®