mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: linux@treblig.org, chuck.lever@oracle.com, neilb@suse.de
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NFSD: remove unused structs 'nfsd3_voidargs'
Date: Fri, 31 May 2024 06:09:27 -0400	[thread overview]
Message-ID: <1922c6893fd78b5c9af1549ac109d097341c4b0e.camel@kernel.org> (raw)
In-Reply-To: <20240531000838.332082-1-linux@treblig.org>

On Fri, 2024-05-31 at 01:08 +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'nfsd3_voidargs' in nfs[23]acl.c is unused since
> commit 788f7183fba8 ("NFSD: Add common helpers to decode void args
> and
> encode void results").
> 
> Remove them.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  fs/nfsd/nfs2acl.c | 2 --
>  fs/nfsd/nfs3acl.c | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/fs/nfsd/nfs2acl.c b/fs/nfsd/nfs2acl.c
> index 12b2b9bc07bf..4e3be7201b1c 100644
> --- a/fs/nfsd/nfs2acl.c
> +++ b/fs/nfsd/nfs2acl.c
> @@ -308,8 +308,6 @@ static void nfsaclsvc_release_access(struct
> svc_rqst *rqstp)
>  	fh_put(&resp->fh);
>  }
>  
> -struct nfsd3_voidargs { int dummy; };
> -
>  #define ST 1		/* status*/
>  #define AT 21		/* attributes */
>  #define pAT (1+AT)	/* post attributes - conditional */
> diff --git a/fs/nfsd/nfs3acl.c b/fs/nfsd/nfs3acl.c
> index 73adca47d373..5e34e98db969 100644
> --- a/fs/nfsd/nfs3acl.c
> +++ b/fs/nfsd/nfs3acl.c
> @@ -221,8 +221,6 @@ static void nfs3svc_release_getacl(struct
> svc_rqst *rqstp)
>  	posix_acl_release(resp->acl_default);
>  }
>  
> -struct nfsd3_voidargs { int dummy; };
> -
>  #define ST 1		/* status*/
>  #define AT 21		/* attributes */
>  #define pAT (1+AT)	/* post attributes - conditional */

Reviewed-by: Jeff Layton <jlayton@kernel.org>

  reply	other threads:[~2024-05-31 10:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-31  0:08 linux
2024-05-31 10:09 ` Jeff Layton [this message]
2024-05-31 13:20 ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1922c6893fd78b5c9af1549ac109d097341c4b0e.camel@kernel.org \
    --to=jlayton@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux@treblig.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®