From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752160AbdK0Mnr (ORCPT <rfc822;w@1wt.eu>);
        Mon, 27 Nov 2017 07:43:47 -0500
Received: from lelnx193.ext.ti.com ([198.47.27.77]:10739 "EHLO
        lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751598AbdK0Mnq (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 27 Nov 2017 07:43:46 -0500
Subject: Re: [PATCH 2/2] ARM: davinci: make davinci_soc_info structures const
To: Bhumika Goyal <bhumirks@gmail.com>, <julia.lawall@lip6.fr>,
        <khilman@kernel.org>, <linux@armlinux.org.uk>,
        <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>
References: <1508148504-2771-1-git-send-email-bhumirks@gmail.com>
 <1508148504-2771-3-git-send-email-bhumirks@gmail.com>
From: Sekhar Nori <nsekhar@ti.com>
Message-ID: <19265c2a-4ae4-a2f8-3ddf-01c2a4c2b11a@ti.com>
Date: Mon, 27 Nov 2017 18:12:59 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <1508148504-2771-3-git-send-email-bhumirks@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday 16 October 2017 03:38 PM, Bhumika Goyal wrote:
> This is a followup patch for [PATCH 1/2].

This line is not relevant once the patch gets committed.

> 
> Make the structures const as they are either passed to the function

Patch description should be readable independent of subject line so we
need to be more specific than "the structures"

> davinci_common_init having the argument as const or their field cpu_clks
> of type struct clk_lookup * is passed to the function davinci_clk_init.
> So, the fields are never modified and the structures can be const. 
> 
> Done using Coccinelle.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

I made fixes to commit description per above and here is the updated text.

"
ARM: davinci: make davinci_soc_info structures const

Make davinci_soc_info structures const as they are either passed to the
function davinci_common_init having the argument as const or their field
cpu_clks of type struct clk_lookup * is passed to the function
davinci_clk_init.

So, the fields are never modified and the structures can be const.

Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
[nsekhar@ti.com: minor commit message adjustment]
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
"

With that I applied the patch to v4.16/fixes-non-critical

Thanks,
Sekhar