From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750854AbbCREMl (ORCPT ); Wed, 18 Mar 2015 00:12:41 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:38279 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750721AbbCREMj (ORCPT ); Wed, 18 Mar 2015 00:12:39 -0400 X-AuditID: cbfee68d-f79296d000004278-af-5508fb321f22 Date: Wed, 18 Mar 2015 04:12:34 +0000 (GMT) From: MyungJoo Ham Subject: Re: [PATCH] PM / devfreq: Fix faulty error message To: Deva Ramasubramanian Cc: =?utf-8?Q?=EB=B0=95=EA=B2=BD=EB=AF=BC?= , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Reply-to: myungjoo.ham@samsung.com MIME-version: 1.0 X-MTR: 20150318015255577@myungjoo.ham Msgkey: 20150318015255577@myungjoo.ham X-EPLocale: ko_KR.utf-8 X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-MLAttribute: X-RootMTR: 20150318015255577@myungjoo.ham X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N X-ConfirmMail: N,general Content-type: text/plain; charset=utf-8 MIME-version: 1.0 Message-id: <1926965615.269101426651953270.JavaMail.weblogic@epmlwas07d> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrIIsWRmVeSWpSXmKPExsWyRsSkSNfoN0eowbmNchaXd81hc2D0+LxJ LoAxissmJTUnsyy1SN8ugSvjxqtZjAXTRCua7y1jaWA8I9LFyMkhJKAusWjJSTYQW0LAROLI 4inMELaYxIV764HiXEA1SxklHj+5w97FyAFWtH5KNER8DqPExR0nWEHiLAKqEt828oOYbAJ6 EjM/J4OMERawlvgydQnYeBGgzms/e1lAbGaBw4wST98GQpygJLFm3yuwOK+AoMTJmU9YIE5Q lVjy7hg7RFxNYva2hewQcXGJC3MvQdm8EjPan0LVy0lM+7oG6nxpifOzNjDCvLL4+2OoOL/E sds7mCBsAYmpZw5C1WhJ3Gw9ATWTT2LNwrcsMPW7Ti1nhtl1f8tcqF4Jia0tT1ghflGUmNL9 EBw6zAKaEut36aN7hVfAQ2Ln7ImMoFCTEJjIITHl2gz2CYxKs5DUzUIyahbCKGQlCxhZVjGK phYkFxQnpRcZ6hUn5haX5qXrJefnbmIEpoTT/5717mC8fcD6EKMAB6MSD6/EVY5QIdbEsuLK 3EOMpsA4msgsJZqcD0w8eSXxhsZmRhamJqbGRuaWZkrivIpSP4OFBNITS1KzU1MLUovii0pz UosPMTJxcEo1MHZGsJ0zPJjQEbFvxh6tEIVf3Vv3H7vmnaXFLcD2c85ypksTOz2vhpUcyGo+ e9Nkts1hlt9Nk3a7eDyazzPnYvvESltdRh3en+vOJF2r0WtV7/iQGdKXZ29pKHiKnbGgoins WqHbtNRfKiq5e8MSZ7w8H/T46o1m0/enG23W7mR/1bLg+qnoVCWW4oxEQy3mouJEAPUjvOsE AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrEKsWRmVeSWpSXmKPExsVy+t/tPl2j3xyhBideiltc3jWHzYHR4/Mm uQDGqDSbjNTElNQihdS85PyUzLx0WyXv4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKCh SgpliTmlQKGAxOJiJX07m6L80pJUhYz84hJbpWhDcyM9IwM9UyM9Q+NYK0MDAyNToJqEtIwb r2YxFkwTrWi+t4ylgfGMSBcjJ4eQgLrEoiUn2boYOTgkBEwk1k+JBglLCIhJXLi3HijMBVQy h1Hi4o4TrCA1LAKqEt828oOYbAJ6EjM/J4OUCwtYS3yZuoQNxBYBmnLtZy8LiM0scJhR4unb QIhNShJr9r0Ci/MKCEqcnPmEBWKVqsSSd8fYIeJqErO3LWSHiItLXJh7CcrmlZjR/hSqXk5i 2tc1zBC2tMT5WRsYYU5e/P0xVJxf4tjtHUwQtoDE1DMHoWq0JG62noCaySexZuFbFpj6XaeW M8Psur9lLlSvhMTWliesEL8oSkzpfsgO8jqzgKbE+l366F7hFfCQ2Dl7IuMERtlZSFKzkHTP QuhGVrKAkWUVo2hqQXJBcVJ6haFecWJucWleul5yfu4mRnD6ebZwB+OX89aHGAU4GJV4eCWu coQKsSaWFVfmHmKU4GBWEuHVagEK8aYkVlalFuXHF5XmpBYfYjQFxthEZinR5HxgaswriTc0 NjYxMzG1NLEwMDVXEuf9fy43REggPbEkNTs1tSC1CKaPiYNTqoGRPXKLOM+T178X+2fJ2KzN /aCaKsx2gsFx9R4baYGSrLzlrh9c4qZwXTvFm1clcoSF6Vl8UONn2xeS1cly1q+D7Q/JS+zh eNvzZYZ0zxf79KQrv/K23Sy5X8UgEnwx/5bq7mvpb77mvznJr3yjJn/qQSG+3MwNPw7vn/pm nplu9XPHi7PtvC2UWIozEg21mIuKEwF0RnUcVQMAAA== DLP-Filter: Pass X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t2I4Cxtn006748 > The misleading log "releasing devfreq which doesn't exist" prints out > for well behaved clients. This is due to the fact that _remove_devfreq > calls itself recursively by proxy (via put_device()). The second time > _devfreq_remove is called the respective device has already been > deleted, causing the misleading warning. > > So just skip printing the message if _devfreq_remove was called via > put_device(). > > Signed-off-by: Deva Ramasubramanian > --- > drivers/devfreq/devfreq.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > index 30b538d8..bee59db 100644 > --- a/drivers/devfreq/devfreq.c > +++ b/drivers/devfreq/devfreq.c > @@ -399,7 +399,8 @@ static void _remove_devfreq(struct devfreq *devfreq) > mutex_lock(&devfreq_list_lock); > if (IS_ERR(find_device_devfreq(devfreq->dev.parent))) { > mutex_unlock(&devfreq_list_lock); > - dev_warn(&devfreq->dev, "releasing devfreq which doesn't exist\n"); > + if (!skip) > + dev_warn(&devfreq->dev, "releasing devfreq which doesn't exist\n"); There is no variable 'skip' in the function. (you get build error.) And with patch 585fc83ece43be63, we do not call the function recursively, either. --- drivers/devfreq/devfreq.c: In function ‘_remove_devfreq’: drivers/devfreq/devfreq.c:402:8: error: ‘skip’ undeclared (first use in this function) drivers/devfreq/devfreq.c:402:8: note: each undeclared identifier is reported only once for each function it appears in make[2]: *** [drivers/devfreq/devfreq.o] Error 1 make[1]: *** [drivers/devfreq] Error 2 make[1]: *** Waiting for unfinished jobs.... --- I'll update the function description. Cheers, MyungJoo. > return; > } > list_del(&devfreq->node); > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I