mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shivendra Pratap <shivendra.pratap@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Sebastian Reichel <sre@kernel.org>, Rob Herring <robh@kernel.org>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Souvik Chakravarty <Souvik.Chakravarty@arm.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Andy Yan <andy.yan@rock-chips.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Konrad Dybcio <konradybcio@kernel.org>,
	cros-qcom-dts-watchers@chromium.org,
	Vinod Koul <vkoul@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>,
	Stephen Boyd <swboyd@chromium.org>,
	Andre Draszik <andre.draszik@linaro.org>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	Elliot Berman <quic_eberman@quicinc.com>,
	Srinivas Kandagatla <srini@kernel.org>
Subject: Re: [PATCH v13 07/10] firmware: psci: Implement vendor-specific resets as reboot-mode
Date: Mon, 28 Jul 2025 21:24:06 +0530	[thread overview]
Message-ID: <1926e6e0-70a4-67fa-5e91-cd0155af1eac@oss.qualcomm.com> (raw)
In-Reply-To: <2a39c0ab-edd4-402c-95a0-a6286f03102a@kernel.org>



On 7/28/2025 5:53 PM, Krzysztof Kozlowski wrote:
> On 28/07/2025 14:03, Dmitry Baryshkov wrote:
>>>
>>>> and the reboot-mode is defined in the
>>>> previous patch. So, I'd assume, the path is defined.
>>>
>>> As I said, path is not. only psci/reboot-mode is.
>>
>> Do we have an _actual_ use case where PSCI node is not at at root node? 
> 
> Yes, many cases, because it belongs as well to firmware node.
> 
>> If not, it's obviously a deficiency of the schema. Could you please 
>> provide suggestions on how to describe that in DT schema?
> 
> I do not see deficiency. There is no ABI that psci must be root node, so
> there is no issue to fix there.
> 
> If you want to add such ABI, I will answer: no, don't, because we do not
> want paths or node names to be the ABI.
> 
> Compatible is the ABI.
Will define a compatible for psci->reboot-mode node and use it to find the
node. Hope its fine to define a compatible for reboot-mode which is defined
as a property inside psci?

thanks.
> 
> Best regards,
> Krzysztof

  parent reply	other threads:[~2025-07-28 15:54 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-27 16:24 [PATCH v13 00/10] Implement vendor resets for PSCI SYSTEM_RESET2 Shivendra Pratap
2025-07-27 16:24 ` [PATCH v13 01/10] power: reset: reboot-mode: Synchronize list traversal Shivendra Pratap
2025-07-27 16:24 ` [PATCH v13 02/10] power: reset: reboot-mode: Add device tree node-based registration Shivendra Pratap
2025-07-27 16:24 ` [PATCH v13 03/10] power: reset: reboot-mode: Add support for 64 bit magic Shivendra Pratap
2025-07-27 16:24 ` [PATCH v13 04/10] Documentation: ABI: Add sysfs-class-reboot-mode-reboot_modes Shivendra Pratap
2025-07-30  9:06   ` André Draszik
2025-07-30 13:08     ` Shivendra Pratap
2025-07-27 16:24 ` [PATCH v13 05/10] power: reset: reboot-mode: Expose sysfs for registered reboot_modes Shivendra Pratap
2025-07-27 16:24 ` [PATCH v13 06/10] dt-bindings: arm: Document reboot mode magic Shivendra Pratap
2025-07-27 16:24 ` [PATCH v13 07/10] firmware: psci: Implement vendor-specific resets as reboot-mode Shivendra Pratap
2025-07-28  4:53   ` Krzysztof Kozlowski
2025-07-28  9:44     ` Dmitry Baryshkov
2025-07-28 11:52       ` Krzysztof Kozlowski
2025-07-28 12:03         ` Dmitry Baryshkov
2025-07-28 12:23           ` Krzysztof Kozlowski
2025-07-28 13:23             ` Sudeep Holla
2025-07-28 15:37               ` Dmitry Baryshkov
2025-07-28 15:54             ` Shivendra Pratap [this message]
2025-07-28 18:29               ` Dmitry Baryshkov
2025-07-29  3:14                 ` Shivendra Pratap
2025-07-28 16:08           ` Shivendra Pratap
2025-07-30  8:44   ` André Draszik
2025-07-30 13:03     ` Shivendra Pratap
2025-07-30 15:23       ` André Draszik
2025-07-30 17:31         ` Arnd Bergmann
2025-07-31 11:05           ` André Draszik
2025-07-31  5:35         ` Shivendra Pratap
2025-07-31 10:25           ` André Draszik
2025-07-27 16:24 ` [PATCH v13 08/10] arm64: dts: qcom: qcm6490-idp: Add PSCI SYSTEM_RESET2 types Shivendra Pratap
2025-07-27 16:24 ` [PATCH v13 09/10] arm64: dts: qcom: qcs6490-rb3gen2: " Shivendra Pratap
2025-07-27 16:24 ` [PATCH v13 10/10] arm64: dts: qcom: sa8775p-ride: " Shivendra Pratap
2025-07-30  8:50 ` [PATCH v13 00/10] Implement vendor resets for PSCI SYSTEM_RESET2 André Draszik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1926e6e0-70a4-67fa-5e91-cd0155af1eac@oss.qualcomm.com \
    --to=shivendra.pratap@oss.qualcomm.com \
    --cc=Souvik.Chakravarty@arm.com \
    --cc=andersson@kernel.org \
    --cc=andre.draszik@linaro.org \
    --cc=andy.yan@rock-chips.com \
    --cc=arnd@arndb.de \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mukesh.ojha@oss.qualcomm.com \
    --cc=quic_eberman@quicinc.com \
    --cc=robh@kernel.org \
    --cc=sre@kernel.org \
    --cc=srini@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=swboyd@chromium.org \
    --cc=vkoul@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®