From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965347AbbJVPvd (ORCPT ); Thu, 22 Oct 2015 11:51:33 -0400 Received: from gloria.sntech.de ([95.129.55.99]:58005 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964875AbbJVPva (ORCPT ); Thu, 22 Oct 2015 11:51:30 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Doug Anderson Cc: Krzysztof Kozlowski , Javier Martinez Canillas , "linux-kernel@vger.kernel.org" , Markus Reichl , Anand Moon , linux-samsung-soc , Alim Akhtar , Marek Szyprowski , "linux-mmc@vger.kernel.org" , Alexandre Courbot , Ulf Hansson Subject: Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler Date: Thu, 22 Oct 2015 17:51:17 +0200 Message-ID: <19278822.W8IRxl9izA@diego> User-Agent: KMail/4.14.10 (Linux/4.2.0-1-amd64; KDE/4.14.12; x86_64; ; ) In-Reply-To: References: <1445440540-21525-1-git-send-email-javier@osg.samsung.com> <56283F27.9060804@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, 22. Oktober 2015, 08:34:38 schrieb Doug Anderson: > Note that personally I would only choose the "highest" priority as an > absolute last resort. Leaving a little extra slack in there means > that when the next person comes up with a really good reason to run > before you do that they can do it without changing your code. just to reiterate, restart-handlers are generally not meant as "things to do before restart", but "are supposed to restart the system, nothing else" [0]. Just in this case there hasn't been a better solution found for the needed reset even in emergency-reboots ... but this misappropriation of restart- handlers should not spread into further realms, so there shouldn't be a "next person" ;-) . [0] http://permalink.gmane.org/gmane.linux.kernel/1968815