Re: [PATCH 2/2] soc: xilinx: Fix event manager CPU hotplug state cleanup

[Prasanna Kumar T S M <ptsm@linux.microsoft.com>]

Hi Jay,

On 03-11-2026 17:56, Jay Buddhabhatti wrote:
> Hi Prasanna,
> 
> On Mon, Nov 02, 2026 at 10:35:15PM -0800, Prasanna Kumar T S M wrote:
>  > On driver removal, the event manager removes the CPUHP_AP_ONLINE_DYN
>  > CPU hotplug state instead of the its actual state. This can leave the
>  > event manager callbacks dangling. Use the actual CPU hotplug state
>  > during driver removal.
>  >
>  > Hotplug registration failures are also ignored, allowing probe to
>  > succeed without the callbacks needed to enable event interrupts on
>  > CPUs brought online later.
>  >
>  > Fixes: c7fdb2404f66 ("drivers: soc: xilinx: add xilinx event 
> management driver")
>  > Signed-off-by: Prasanna Kumar T S M ptsm@linux.microsoft.com
> 
> This looks good to me.
> 
> A couple of small nits:
> 
> - "instead of the its actual state" -> "instead of its actual state"

Thanks for catching this.

> - Minor alignment on the cpuhp_setup_state() continuation lines;
>    checkpatch --strict complains.
>      CHECK: Alignment should match open parenthesis
>      #49: FILE: drivers/soc/xilinx/xlnx_event_manager.c:663:
>      +       hp_state = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN,
>      +                       "soc/event:starting", xlnx_event_cpuhp_start,
> 
>      total: 0 errors, 0 warnings, 1 checks, 44 lines checked

I missed this.

I think the issues are minor. Is it possible to fix this while merging 
the patch?

> 
> Worth Cc: stable@vger.kernel.org as well, given the Fixes tag.

Do I need to send v2 to address this?

> 
> Reviewed-by: Jay Buddhabhatti <jay.buddhabhatti@amd.com>
> 
> Thanks,
> Jay

Thanks,
Prasanna Kumar