From: bot+bpf-ci@kernel.org
To: pilgrimtao@gmail.com,martin.lau@linux.dev,ast@kernel.org,daniel@iogearbox.net,andrii@kernel.org,eddyz87@gmail.com,song@kernel.org,yonghong.song@linux.dev,john.fastabend@gmail.com,kpsingh@kernel.org,sdf@fomichev.me,haoluo@google.com,jolsa@kernel.org,shuah@kernel.org,chengkaitao@kylinos.cn,linux-kselftest@vger.kernel.org
Cc: bpf@vger.kernel.org,linux-kernel@vger.kernel.org,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,clm@meta.com,ihor.solodrai@linux.dev
Subject: Re: [PATCH v6 5/5] bpf/verifier: refactor kfunc checks to table-driven approach
Date: Wed, 4 Mar 2026 15:08:50 +0000 (UTC) [thread overview]
Message-ID: <1930dcf1fee8f4ee2083797bebd2ffead5d0588d6f3d8137fa099da85a5a005c@mail.kernel.org> (raw)
In-Reply-To: <20260304143459.78059-6-pilgrimtao@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 841 bytes --]
> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> --- a/kernel/bpf/verifier.c
> +++ b/kernel/bpf/verifier.c
[ ... ]
> static bool is_bpf_res_spin_lock_kfunc(u32 btf_id)
> {
>+ return btf_id_in_kfunc_table(btf_id, bpf_res_spin_lock_kfuncs,
>+ ARRAY_SIZE(bpf_res_spin_lock_kfuncs));
> }
The continuation line here has one fewer space than the other three call
sites (is_bpf_list_api_kfunc, is_bpf_rbtree_api_kfunc, and
check_kfunc_is_graph_node_api), so ARRAY_SIZE doesn't align to the
opening parenthesis of btf_id_in_kfunc_table(). Should this be aligned
to match the others?
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/22674350640
next prev parent reply other threads:[~2026-03-04 15:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 14:34 [PATCH v6 0/5] bpf: Extend the bpf_list family of APIs Chengkaitao
2026-03-04 14:34 ` [PATCH v6 1/5] bpf: Introduce the bpf_list_del kfunc Chengkaitao
2026-03-06 0:00 ` Kumar Kartikeya Dwivedi
2026-03-06 0:14 ` Kumar Kartikeya Dwivedi
2026-03-06 0:28 ` Kumar Kartikeya Dwivedi
2026-03-04 14:34 ` [PATCH v6 2/5] bpf: Add bpf_list_add_impl to insert node after a given list node Chengkaitao
2026-03-06 0:36 ` Kumar Kartikeya Dwivedi
2026-03-04 14:34 ` [PATCH v6 3/5] bpf: Add bpf_list_is_edge/empty kfuncs Chengkaitao
2026-03-04 15:08 ` bot+bpf-ci
2026-03-06 0:47 ` Kumar Kartikeya Dwivedi
2026-03-04 14:34 ` [PATCH v6 4/5] selftests/bpf: Add test cases for bpf_list_del/add/is_edge/empty Chengkaitao
2026-03-06 0:52 ` Kumar Kartikeya Dwivedi
2026-03-04 14:34 ` [PATCH v6 5/5] bpf/verifier: refactor kfunc checks to table-driven approach Chengkaitao
2026-03-04 15:08 ` bot+bpf-ci [this message]
2026-03-04 15:59 ` Leon Hwang
2026-03-04 15:51 ` [PATCH v6 0/5] bpf: Extend the bpf_list family of APIs Leon Hwang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1930dcf1fee8f4ee2083797bebd2ffead5d0588d6f3d8137fa099da85a5a005c@mail.kernel.org \
--to=bot+bpf-ci@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chengkaitao@kylinos.cn \
--cc=clm@meta.com \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=ihor.solodrai@linux.dev \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=martin.lau@linux.dev \
--cc=pilgrimtao@gmail.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®