From: Mikael Pettersson <mikpe@it.uu.se>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Roel Kluin <roel.kluin@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Mikael Pettersson <mikpe@it.uu.se>,
penberg@cs.helsinki.fi, Brian Gerst <brgerst@gmail.com>,
andi@firstfloor.org, Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-crypto@vger.kernel.org, Herbert@gondor.apana.org.au
Subject: Re: [PATCH v1] compiler: prevent dead store elimination
Date: Mon, 1 Mar 2010 10:32:00 +0100 [thread overview]
Message-ID: <19339.35216.412591.13392@pilspetsen.it.uu.se> (raw)
In-Reply-To: <20100228211511.60981829@infradead.org>
Arjan van de Ven writes:
> On Sat, 27 Feb 2010 21:47:42 +0100
> Roel Kluin <roel.kluin@gmail.com> wrote:
> > +void secure_bzero(void *p, size_t n)
> > +{
> > + memset(p, 0, n);
> > + ARRAY_PREVENT_DSE(p, n);
> > +}
> > +EXPORT_SYMBOL(secure_bzero);
>
>
> please don't introduce bzero again to the kernel;
>
> make it secure_memset() please.
In principle I would agree, but bzero() avoids the unfortunately
rather common mistake of swapping the int/size_t parameters to
memset(). I.e., people writing memset(p, n, 0) not memset(p, 0, n).
next prev parent reply other threads:[~2010-03-01 9:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-27 20:47 Roel Kluin
2010-02-28 9:55 ` Andi Kleen
2010-02-28 15:34 ` [PATCH v2] " Roel Kluin
2010-03-01 9:29 ` Mikael Pettersson
2010-03-02 12:17 ` Andi Kleen
2010-03-03 23:16 ` [PATCH v3] " Roel Kluin
2010-03-02 12:24 ` [PATCH v2] " Andi Kleen
2010-03-01 0:36 ` [PATCH v1] " Bill Davidsen
2010-03-01 5:15 ` Arjan van de Ven
2010-03-01 9:32 ` Mikael Pettersson [this message]
2010-03-01 9:33 ` Alexey Dobriyan
2010-03-01 22:27 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19339.35216.412591.13392@pilspetsen.it.uu.se \
--to=mikpe@it.uu.se \
--cc=Herbert@gondor.apana.org.au \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=arjan@infradead.org \
--cc=brgerst@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®