From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755279AbbIJIsK (ORCPT ); Thu, 10 Sep 2015 04:48:10 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:53868 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752500AbbIJIsD (ORCPT ); Thu, 10 Sep 2015 04:48:03 -0400 From: Arnd Bergmann To: Peter Ujfalusi Cc: vinod.koul@intel.com, nsekhar@ti.com, linux@arm.linux.org.uk, olof@lixom.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, dmaengine@vger.kernel.org Subject: Re: [PATCH 00/21] dmaengine/ARM: Merge the edma drivers into one Date: Thu, 10 Sep 2015 10:47:28 +0200 Message-ID: <1936630.COymDSFqK4@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1441874270-2399-1-git-send-email-peter.ujfalusi@ti.com> References: <1441874270-2399-1-git-send-email-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:dw3gOs3wb0OGZaRJRX9T+4YVViwaBBJvkVpbDwYQAX3WlmD/gVO Drbm/CF9pB4wlC4QJ1SIpI53+29dbtClFCe2lqsa39oH6SwYgdZCN6ONAuLEp7+1YiK61Zm YjhKHwtKdXGNjjv3eQIfCmAO9JQYcVJwPxkwu8XJZLL6i8b2wLQ0WpLTa/8QdcqaIaGd+Lk vOetc7sThibdtrRwbXVow== X-UI-Out-Filterresults: notjunk:1;V01:K0:CtoxKB1v/XI=:lBm8DnAxDZRa83Lm5RRxhk ISaVPAQbDrnV5vZWxBAZ5WDgC4QwVyXeefHdGfzYtrcgscvfVXC5Sa0Vsq5OSAAUrVLfFZNh5 lUjLM6RZniu2Gaiy+PmsX1LQorAFzguVXGDjv8uo3/gFXEkDuYG858RM9VA40FL7TJFQCSUc1 6NT7y4Oxs4TB7Y7uDNWCnaibzpOBoxIoaTNNKiwlWwABLIgGaXupRfTKJUppUPsVIi5yyBgqQ dz4HtZl/B+wQKkstFs1fTmT66TjMOwRUx3dVwE0n/s6/E+BRDmqVcytF637+dG3GWcvTWWN7z Q5p88aYLM/VP8EYUo8ey+SK12rDklnOc/cfD0FdFz7mjkaFjlszeNlM8Cpik+LEe1oBm4snJ7 +Rv+Fq84RTnq+ueg7tiAxvgO789GClbhLaTlUfyZFfOOML4KyQQHwNCyhnHXerT9RVHSn4oaP 4T6cSAzMPvbMswoYQy0hxnS2tzw8M54XGsrdz9+3BAtTcc0Bg5aWDfJeyPYLb7jwru6FRlL0J NnKUMZO5n41MalxFPOIlbwOqMkYiBukq/bRvOm1pazZQLE050MdMiBnFa0PqbwcyJgf7nvS/W 6P377/FIqKldXMv9QEZtpFvCz8McSrfMdxMPK4Nniqtg3Qe5Z0u0C9qp43a2/1GXAzI1W4EZJ eA1Ro/2VUT6mAqlDh6zAnb1cFb66exiIFZJTb1reakaA1OM16kxHlURKNaGSqxOuvFF6c1ot/ 8LfDgZc94xPlNru4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 10 September 2015 11:37:29 Peter Ujfalusi wrote: > > with this series the edma two driver setup will be changed to have only one > driver to support eDMA3. The legacy edma interface will be removed and eDMA can > only be used via dmaengine API from this point on. > In order to do the merge the following improvements has been done: > - One driver instance per eDMA: > - Any number of eDMA instances are supported (both legacy and DT boot) > - Not relying on global variables, arrays, etc > - Code simplification and optimizations in several places > > This change will also help us to do bigger changes in the eDMA driver since, > since now we have only one driver to work with. > Very nice series, thanks for addressing this long-standing issue! I've briefly read over the series and did not see anything major sticking out, but I did not attempt to do a thorough review. I found two minor things that I commented on that could be improved. Arnd