mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	kernel@pengutronix.de, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
	Leonard Crestez <leonard.crestez@nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Russell King <linux@armlinux.org.uk>,
	Shawn Guo <shawnguo@kernel.org>, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v6 3/6] kernel/reboot.c: export pm_power_off_prepare
Date: Sat, 12 May 2018 13:13:36 +0200	[thread overview]
Message-ID: <1937901.oyadCYFYNo@aspire.rjw.lan> (raw)
In-Reply-To: <20180504185052.bjhfkvpgrblc7tfc@pengutronix.de>

On Friday, May 4, 2018 8:50:52 PM CEST Oleksij Rempel wrote:
> Hallo Andrew,
> I need your ACK or NACK for this patch.
> 
> This function is used to configure external PMIC to interpret
> signal which will be triggered by pm_power_off as power off.
> Since same signal can be used for stand by, I linked PMIC configuration
> with pm_power_off_prepare to avoid possible conflicts.
> 
> On Mon, Mar 05, 2018 at 11:25:20AM +0100, Oleksij Rempel wrote:
> > Export pm_power_off_prepare. It is needed to implement power off on
> > Freescale/NXP iMX6 based boards with external power management
> > integrated circuit (PMIC).
> > 
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> >  kernel/reboot.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/kernel/reboot.c b/kernel/reboot.c
> > index e4ced883d8de..350be6baa60d 100644
> > --- a/kernel/reboot.c
> > +++ b/kernel/reboot.c
> > @@ -49,6 +49,7 @@ int reboot_force;
> >   */
> >  
> >  void (*pm_power_off_prepare)(void);
> > +EXPORT_SYMBOL(pm_power_off_prepare);

Why not EXPORT_SYMBOL_GPL() ?

> >  
> >  /**
> >   *	emergency_restart - reboot the system
> 
> 

  parent reply	other threads:[~2018-05-12 11:14 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-05 10:25 [PATCH RESEND v6 0/6] provide power off support for iMX6 with external PMIC Oleksij Rempel
2018-03-05 10:25 ` [PATCH v6 1/6] ARM: imx6q: provide documentation for new fsl,pmic-stby-poweroff property Oleksij Rempel
2018-03-05 10:25 ` [PATCH v6 2/6] ARM: imx6: register pm_power_off handler if "fsl,pmic-stby-poweroff" is set Oleksij Rempel
2018-05-08 12:40   ` Russell King - ARM Linux
2018-05-09  5:06     ` Oleksij Rempel
2018-05-09  9:02       ` Russell King - ARM Linux
2018-03-05 10:25 ` [PATCH v6 3/6] kernel/reboot.c: export pm_power_off_prepare Oleksij Rempel
2018-05-04 18:50   ` Oleksij Rempel
2018-05-04 20:49     ` Andrew Morton
2018-05-05  7:01       ` Oleksij Rempel
2018-05-08 21:39         ` Rafael J. Wysocki
2018-05-12 11:13     ` Rafael J. Wysocki [this message]
2018-05-14  4:33       ` Oleksij Rempel
2018-05-14  5:10         ` Oleksij Rempel
2018-05-14 10:12           ` Oleksij Rempel
2018-03-05 10:25 ` [PATCH v6 4/6] regulator: pfuze100: add fsl,pmic-stby-poweroff property Oleksij Rempel
2018-03-05 10:25 ` [PATCH v6 5/6] regulator: pfuze100-regulator: provide pm_power_off_prepare handler Oleksij Rempel
2018-03-05 10:25 ` [PATCH v6 6/6] ARM: dts: imx6: RIoTboard provide standby on power off option Oleksij Rempel
2018-04-03  5:59 ` [PATCH RESEND v6 0/6] provide power off support for iMX6 with external PMIC Oleksij Rempel
2018-04-09 11:37 ` Shawn Guo
2018-04-09 11:40   ` Mark Brown
2018-04-09 11:43     ` Oleksij Rempel
  -- strict thread matches above, loose matches on Subject: below --
2017-12-06  7:23 Oleksij Rempel
2017-12-06  7:23 ` [PATCH v6 3/6] kernel/reboot.c: export pm_power_off_prepare Oleksij Rempel
2017-12-06 23:11   ` Christoph Hellwig
2017-12-07  5:36     ` Oleksij Rempel
2017-12-13 14:22       ` Leonard Crestez
2017-10-27  9:48 [PATCH RESEND v6 0/6] provide power off support for iMX6 with external PMIC Oleksij Rempel
2017-10-27  9:48 ` [PATCH v6 3/6] kernel/reboot.c: export pm_power_off_prepare Oleksij Rempel
2017-06-20 14:09 [PATCH v6 0/6] provide power off support for iMX6 with external PMIC Oleksij Rempel
2017-06-20 14:09 ` [PATCH v6 3/6] kernel/reboot.c: export pm_power_off_prepare Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1937901.oyadCYFYNo@aspire.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=akpm@linux-foundation.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=leonard.crestez@nxp.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=o.rempel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®