From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753319AbdBMPsU (ORCPT ); Mon, 13 Feb 2017 10:48:20 -0500 Received: from mail-qt0-f181.google.com ([209.85.216.181]:33468 "EHLO mail-qt0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752581AbdBMPqw (ORCPT ); Mon, 13 Feb 2017 10:46:52 -0500 Subject: Re: [PATCH 2/2] sched/deadline: Throttle a constrained deadline task activated after the deadline To: Steven Rostedt References: <20170213103303.0e3b3953@gandalf.local.home> Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Juri Lelli , Tommaso Cucinotta , Luca Abeni From: Daniel Bristot de Oliveira Message-ID: <193849bc-19a8-da00-ee32-9e1140de1a5d@redhat.com> Date: Mon, 13 Feb 2017 16:46:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170213103303.0e3b3953@gandalf.local.home> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/13/2017 04:33 PM, Steven Rostedt wrote: >> +static inline bool dl_is_constrained(struct sched_dl_entity *dl_se) >> +{ >> + return dl_se->dl_runtime < dl_se->dl_period; >> +} >> + > Is it ever appropriate for a dl task to have runtime == period? What > purpose would that serve? Just run the task as FIFO higher than > everything else. > > Or was this suppose to be dl_deadline < dl_period? Oooooops, my bad :-(, this was supposed to be dl_deadline < dl_period. I will send a v2 fixing it, along with the problem in the comment that peterz mentioned before. Thanks Steven! -- Daniel