From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FC67314B91 for ; Wed, 18 Feb 2026 12:26:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771417616; cv=none; b=O4pG3ZU8Xhte2a0QN+yMUc1ACqtkmSzDMF/YgV3aN8pBujnAW+8rszNkhNqoQi7TBngfO/Ko844oeeNeNqeZjTeIiqMKrKFO6oKEYMw86OJWB79m4UKra+RWacaYMj1qkARVPqszU4q3k+KlGEFj95bYSLtKKO33O+5maS5e6SA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771417616; c=relaxed/simple; bh=uC8ZyDe/LuGv6Mt93cbqkkyOIcYNCMWY7QkgNlR36jM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eNFQKXeFZPotjNt/QqBkwXhp3K4KNcyTSkY1eAvBF3dE83Yykf5mwj7BMiV4YDNpLxfJmMtkLdy2RCrKuXbeKiUCuhMxvRqA69GlPOT3o0DzLKIrcDtGTQWsB6AWXfCD6/HIefuamS3Sk4ZqZEvWDF8VI/c/ZB3G39jDqy/Or64= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jDv7SzTQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=G06nDPY6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jDv7SzTQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="G06nDPY6" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61I5KA7P422183 for ; Wed, 18 Feb 2026 12:26:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8AvmMDOctmFUulH9Soh+ofHw2N0VUD0a2q83TPW2ifo=; b=jDv7SzTQydadV0Le wPPWq+yO6kOn1xJewaIDEy52r2DDLv5lMZRmYyBjM8LZX3Bi983VLI7zQV04BK8I /oQ3NKwfj5isUv6TX27O9IPPxeLEGNz2kJpR47wHsKAuisZIu7owjD824JmpVVdd 6flwvRGmmbZmAX9INfdfcbufkg9Vb6P7fXLf6O6FQ/QQk7R3Sz/qAI2YzLLIc5wq Ws3yVU3L6+9AUEnJpmUufkuhqZtnTRIPWAY7Bf02DQzhNO2kDZYclRx/uT+rsE+J kyv81+7O0PTlT8ee0GyWwB0sVqDFRmr24XTXWCRIgYRKveFALb7T4U0xBZ52Zg+V kKuoNg== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cd76e10c6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Feb 2026 12:26:54 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8c710279d57so393418985a.3 for ; Wed, 18 Feb 2026 04:26:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771417614; x=1772022414; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8AvmMDOctmFUulH9Soh+ofHw2N0VUD0a2q83TPW2ifo=; b=G06nDPY6TEDk3CI2Qp5oDouVqPTwip/piFdHTkbtvlhhp8+oGohyKLw2iFF8lpAD1G O6eFR+0FtVxdc2OOabLoxCnatiIhzrj+n61qqWf2CGkb9M9mN0YPFoYV8KknjTQVlRay xezVJlVdskeZ9KgHGEw269S0de5D9u5UuAwdvEz5oHmEhPyGM9S4W9LEO2Xm5VTuWcjJ 9bNFsLB8BY3Q1KDnLrpRIL7qfGToCX89G7g+Z905p6RZ59Q7jvY6aMtxF4cxyjUDl/D/ VPWgM9q4Mw59F+WsZFT+3t18mh8furBqWq+hdac2iaruJiqXd5xZpHScchmfijUDFVc9 X3UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771417614; x=1772022414; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8AvmMDOctmFUulH9Soh+ofHw2N0VUD0a2q83TPW2ifo=; b=Oj3j8O/4EUTCGKcHb+ITeqRzdt04RLScFmXJtx5UzFBGSygVXZK6//QbxucPOORtPO Lt8M3cdSpiPDHDTdBpvlg54bKQV1h0I1fFgsIxyJZouG/AjtnixBLvzKTxSkriWfpi9g vPHZoNSEHxzgd3xFMytsiPR1idPKOEjL04+btGL4VUqzt69xtnxb/rhhoRH5VaPFCp5J umAgfHx6CUJHjW1TFAWw9TLO0EjUXhO6W8aJVEd54VZhGfWNVpRje8w/txO0u3nCIpOo YifMuIs1pzyg5KnAVktAnHI0kdC6quMz6n/nhHdQa+w6qvdsvuo6UOIshCaF5tbY52IN 1dVA== X-Forwarded-Encrypted: i=1; AJvYcCXLQF9ApTFZNWYMbK71gBYBPo1qvsIDSv47qg9myqHSy/HlTxnaaqxg/0qgpeTkWd1Qj8vdk7mKtVMVRaA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8FJejTSSZ0UgJA9d8aXqwnvcPskDmhQCCGu294AzFAelaxIMF lZuYDjXRrTdVsTUK1agWdedKzy7e+KJyD5nwU4Szx/srnaKDLC9FTMCSiA/XfvX+cAargdpHQ0T aq96pCvVqWxKxGwRzwWkPjkWFVcIZkd6xCISg2mc14ktoEpVDLuhNLcqurcRQd8Y7txg= X-Gm-Gg: AZuq6aKu/F2C3QtdXE0kpMXUuhCYxuVNf+1xGuaUE8fgzV0Fk2vUwTotQ76ugM+IIXM 5rAJi9wMooRCnvhs48G2ONshBZZqByXiVrdP2Y3rxGhvbf56R47/i9W+hdpVR7pDsnEFEx9yqa6 YOFYGE9No1UCuJ8CZ/Qy9K2QFwz0J6upW84JcecNyhwkonlw3jELTqMNWIq8LVTl3ysISvkSUcO 8ztvFeZpsoRQhDVyXSX0zlY3RodvSXYjdfotYnsM+72xTJb1Eb/8jpl27FrSoeUMBSXPk8sFa5N AYg0XinVT/dIHvmcW+ThtCei/xYn3BSr/ZASOhd3xjJ30+u5+qrxeOR68jjWC/qplrVBXKenJID ENS6h/m/F76cRRdrekdR7b9xs6FJPeoNkWvCCmxjr8jODdxTcYlqUb0WrmpiebGOeuMMfEtT/7D VK8yGgMkF25Kywdw== X-Received: by 2002:a05:620a:472b:b0:8ca:4545:aee4 with SMTP id af79cd13be357-8cb40807ca3mr1739412085a.1.1771417613783; Wed, 18 Feb 2026 04:26:53 -0800 (PST) X-Received: by 2002:a05:620a:472b:b0:8ca:4545:aee4 with SMTP id af79cd13be357-8cb40807ca3mr1739409285a.1.1771417613263; Wed, 18 Feb 2026 04:26:53 -0800 (PST) Received: from [192.168.0.242] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8fc735e587sm440840766b.2.2026.02.18.04.26.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Feb 2026 04:26:52 -0800 (PST) Message-ID: <193d236b-864b-45bd-b0a9-6efbdccf6db9@oss.qualcomm.com> Date: Wed, 18 Feb 2026 13:26:49 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 1/3] dt-bindings: sram: qcom,imem: Allow modem-tables subnode To: Krzysztof Kozlowski , Konrad Dybcio Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alex Elder , Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20260217-topic-ipa_imem-v3-0-d6d8ed1dfb67@oss.qualcomm.com> <20260217-topic-ipa_imem-v3-1-d6d8ed1dfb67@oss.qualcomm.com> <20260217-godlike-silent-owl-0a8487@quoll> <36f0a71c-a8b7-4aaa-81c3-1945b268c57f@oss.qualcomm.com> <0bfcb292-4e49-4047-b631-dd3029b43f1c@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <0bfcb292-4e49-4047-b631-dd3029b43f1c@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=OKsqHCaB c=1 sm=1 tr=0 ts=6995b00e cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=gEfo2CItAAAA:8 a=EUspDBNiAAAA:8 a=RnnwUKbM9eazD08LpS8A:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=sptkURWiP4Gy88Gu7hUp:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE4MDEwOSBTYWx0ZWRfXz2dmjgoREaYZ PNco5Ht00KMMiY2nMxQXzsR6ZqTmxL1CQnlkquMAx7YYUf4GLn2dcWvDlZRqRiTIABDXoVQjLj5 gPG421fZnQQyW2juT12FynhXR2DMA+ANgPIHE4RpPTAsMeLSC4B5M1TZwE9vAeW+W6/6PVzzpJo 4aibcPyac7L8Ym6MtVeXg1zd2r5qFbm8dsCDBvnqPPk3PFZFswBDYixBLCtUJl/gPM3RKkxJ8+2 koJFitJIgjj5YOPIrxU2oSIDN9L/EbdItvImyDATGwrdUBLUfziV0Ky6Nr7zyqiTTjwHuFzVwRm KAZyNLUZSLy9jPVzlOH1Qbs4yJO1C2liBK7mfGeJSvXRqfh/onTLmHSm9Q63/E/hVh+gYsNzYq/ u8/ndBII+FqUrXsAiolDYw1iSn9kwBze3/Nc1OafUMd5VlsPI6NMsiuRu/IfN/Ok2cTQZeX1WBF RK6t2AppU+qldNtYmTA== X-Proofpoint-GUID: Ag95RbO-0_3nDlltWQOSe7DUUekArFGj X-Proofpoint-ORIG-GUID: Ag95RbO-0_3nDlltWQOSe7DUUekArFGj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-18_02,2026-02-16_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 impostorscore=0 adultscore=0 suspectscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602180109 On 18-Feb-26 12:56, Krzysztof Kozlowski wrote: > On 18/02/2026 12:05, Konrad Dybcio wrote: >> On 2/17/26 9:25 PM, Krzysztof Kozlowski wrote: >>> On Tue, Feb 17, 2026 at 02:30:31PM +0100, Konrad Dybcio wrote: >>>> From: Konrad Dybcio >>>> >>>> The IP Accelerator hardware/firmware owns a sizeable region within the >>>> IMEM, named 'modem-tables', containing various packet processing >>>> configuration data. >>>> >>>> It's not actually accessed by the OS, although we have to IOMMU-map it >>>> with the IPA device, so that presumably the firmware can act upon it. >>>> >>>> Allow it as a subnode of IMEM. >>> >>> You do not have compatible, so rely on the node name as ABI, which is >>> fine in general but... I do not see usage of it in the driver. Why do >>> you need to define modem-tables child then? >> >> I don't really *need* the node name to be an ABI. However, the current >> binding for IMEM only allows a named "pil-reloc@.." subnode (which is >> consumed via of_find_compatible_node() in the remoteproc subsystem) so I >> figured the intention was to keep the list of allowed subnodes strictly >> moderated >> >> If you'd prefer a blanket pattern declaration with say '^[a-z]@[0-9a-z]+$' >> with just a reg requirement inside, I'm fine with that too > > No, the problem is that you do not use the ABI here at all. Neither > would you use the blanket pattern, so my question stays: why adding ABI > which is not used? The subnode I'm trying to introduce is going to be consumed (via a phandle reference) from the IPA node, as done by the remaining 2 patches in this series. I would much prefer not to touch this binding file, but there's an additionalProperties: false and just adding it as-is results in a: arch/arm64/boot/dts/qcom/sc7280-idp.dtb: sram@146a5000: 'modem-tables@1234' does not match any of the regexes: '^pil-reloc@[0-9a-f]+$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/sram/qcom,imem.yaml# Konrad > > The pil-reloc is being used, as you pointed out. > > Best regards, > Krzysztof